[dm-devel] [PATCH 2/2] multipath-tools: delete retain_hwhandler and detect_prio attributes when they are equal to default values

3 .retain_hwhandler = RETAIN_HWHANDLER_ON, 3 .detect_prio = DETECT_PRIO_ON, Cc: Hannes Reinecke Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez

[dm-devel] [PATCH 1/2] multipath-tools: enable retain_hw_handler and detect_prio by default

Based on previous Hannes's work. He wrote: "And for several versions (years, even) the linux kernel has the ability to correctly detect the device handler, so we should be making 'retain_hw_handler' the default. And if we do this we also want to enable 'detect_prio', to ensure we pick the correct

[dm-devel] [PATCH 1/6] multipath-tools: delete attributes with DEFAULT_* values in hwtable.c

48 .features = DEFAULT_FEATURES, 44 .hwhandler = DEFAULT_HWHANDLER, 28 .prio_name = DEFAULT_PRIO, 1 .minio = DEFAULT_MINIO, 1 .minio_rq = DEFAULT_MINIO_RQ, Cc:

[dm-devel] [PATCH 5/6] multipath-tools: delete fast_io_fail attribute when it is equal to default value

2 .fast_io_fail = 5, Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[dm-devel] [PATCH 0/6] Delete attributes with default values

Xose Vazquez Perez (6): multipath-tools: delete attributes with DEFAULT_* values in hwtable.c multipath-tools: delete prio_args attribute when it is equal to default value multipath-tools: delete no_path_retry attribute when it is equal to default value multipath-tools: delete minio_rq

[dm-devel] [PATCH 3/6] multipath-tools: delete no_path_retry attribute when it is equal to default value

28 .no_path_retry = NO_PATH_RETRY_UNDEF, Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 28 1

Re: [dm-devel] [PATCH 00/14] update and general clean up of multipath.conf.5

On 07/08/2016 07:49 PM, Xose Vazquez Perez wrote: > Final result in PDF(35k): > https://drive.google.com/file/d/0B_B6YmEmO7cDa09mdTlGa1NlSWc raw file: https://drive.google.com/file/d/0B_B6YmEmO7cDcHlIVG5GcVlfWGM to see it in color with less as pager: export LESS_TERMCAP_mb=$'\e[00;35m' export

[dm-devel] [PATCH] multipath-tools: document uid_attribute for scsi and dasd devices

Default for SCSI devices is ID_SERIAL, a standard udev variable. Default for DASD devices is ID_UID, returned by dasdinfo from 390-tools package. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez

Re: [dm-devel] [Question] udev ID_UID attribute ???

On 07/08/2016 05:52 PM, Mike Christie wrote: > On 07/07/2016 04:21 PM, Xose Vazquez Perez wrote: >> Is "ID_UID" really valid? >> >> libmultipath/hwtable.c: .uid_attribute = "ID_UID", >> > > I was wondering the same thing. For ceph rbd, we do not have the normal > scsi serial/wwn values,

Re: [dm-devel] [PATCH] multipathd: fix waiter_attr resource leak

On Fri, Jul 08, 2016 at 09:59:18AM +0200, Christophe Varoqui wrote: ACK -Ben >Ben, Hannes, I'd appreciate your ack on this patch. >Thanks. >On Wed, Jul 6, 2016 at 10:08 AM, <[1]zhang.ka...@zte.com.cn> wrote: > > As a global variable waiter_attr of thread attribute was set up

Re: [dm-devel] [PATCH v3 0/4] Support DAX for device-mapper linear devices

On Thu, Jun 30 2016 at 1:00pm -0400, Mike Snitzer wrote: > On Thu, Jun 23 2016 at 5:05pm -0400, > Mike Snitzer wrote: > > > Jens, please pick up the first 2 block patches and I'll get the other > > 2 DM patches staged for 4.8. > > Hey Jens, > > Looks

Re: [dm-devel] [PATCH 1/1] block: fix blk_queue_split() resource exhaustion

On Fri, Jul 08 2016 at 11:04am -0400, Lars Ellenberg wrote: > For a long time, generic_make_request() converts recursion into > iteration by queuing recursive arguments on current->bio_list. > > This is convenient for stacking drivers, > the top-most driver would take

Re: [dm-devel] Subject: [PATCH 1/1] multipath-tools: fix dm- device filtering

On Fri, Jul 08, 2016 at 08:55:38AM +0200, Christophe Varoqui wrote: ACK -Ben >Hannes, Ben, do you ack this one ? >On Thu, Jun 23, 2016 at 11:06 PM, Dragan Stancevic ><[1]dragan.stance...@canonical.com> wrote: > > Hi Christophe, > can you please take a look at the attached

[dm-devel] [PATCH 03/14] multipath-tools: add partition_delimiter to multipath.conf.5

It was missing in defaults section. Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 10 ++

[dm-devel] [PATCH 06/14] multipath-tools: clarify ONTAP class info at multipath.conf.5

ontap prio is *exclusively* for NetApp ONTAP class and OEM arrays, as IBM NSeries. Cc: Martin George Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez ---

[dm-devel] [PATCH 14/14] multipath-tools: minor edit of multipath/multipath.conf.5

Add final colons and dots, acronyms in uppercase, s/1/One, ... Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 121

[dm-devel] [PATCH 02/14] multipath-tools: add alias_prefix to multipath.conf.5

It was missing in defaults section. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 7 +++ 1 file changed, 7 insertions(+) diff --git

[dm-devel] [PATCH 05/14] multipath-tools: clarify DGC/EMC arrays info at multipath.conf.5

DGC(Data General Corporation) arrays are exclusively CLARiiON CX/AX and EMC VNX families. Cc: Edward Goggin Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez ---

[dm-devel] [PATCH 12/14] multipath-tools: list undocumented prioritizers in multipath.conf.5

Some text is needed. Cc: Olivier Lambert Cc: Manon Goo Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez ---

[dm-devel] [PATCH 04/14] multipath-tools: correct and add default values in multipath.conf.5

Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git

[dm-devel] [PATCH 13/14] multipath-tools: add undocumented features to multipath.conf.5

pg_init_retries - kernel commit c9e45581a pg_init_delay_msecs - kernel commit 4e2d19e46 Cc: Dave Wysochanski Cc: Chandra Seetharaman Cc: Christophe Varoqui Cc: device-mapper development

[dm-devel] [PATCH 10/14] multipath-tools: add default value for hardware_handler in multipath.conf.5

It's unset. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/multipath/multipath.conf.5

[dm-devel] [PATCH 09/14] multipath-tools: mark hardware-dependent features in multipath.conf.5

Some features are hardware-dependent. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 13 + 1 file changed, 13 insertions(+) diff

[dm-devel] [PATCH 07/14] multipath-tools: clarify RDAC class info at multipath.conf.5

RDAC(Redundant Dual Active Controller) done by LSI/Engenio/NetApp are NetApp E-Series/F-Series and OEM arrays from IBM DELL SGI STK and SUN. Cc: Sean Stewart Cc: Christophe Varoqui Cc: device-mapper development

[dm-devel] [PATCH 01/14] multipath-tools: replace bold<->italic in multipath.conf.5

Do it more readable. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 116 +++-- 1 file changed, 59

[dm-devel] [PATCH 0/3] Makefiles housekeeping III

Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez Xose Vazquez Perez (3): multipath-tools: install libs in a standard way multipath-tools: merge OPTFLAGS into CFLAGS

[dm-devel] [PATCH 2/3] multipath-tools: merge OPTFLAGS into CFLAGS

OPTFLAGS is not used anywhere, but maybe it's intrusive for distributions. Cc: Mathieu Trudel-Lapierre Cc: Dragan Stancevic Cc: Louis Bouchard Cc: Ritesh Raj Sarraf Cc:

[dm-devel] [PATCH 1/3] multipath-tools: install libs in a standard way

Drop full path of libmpathpersist when linking, and add a link for libmultipath.so Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmpathpersist/Makefile | 2 +-

Re: [dm-devel] [PATCH 2/2] dm: call PR reserve/unreserve on each underlying device

On 07/08/2016 07:23 AM, Christoph Hellwig wrote: > So far we tried to rely on the SCSI 'all target ports' bit to register > all path, but for many setups this didn't work properly as the different > path aren seen as separate initiators to the target instead of multiple > ports of the same

Re: [dm-devel] [PATCH 1/2] sd: don't use the ALL_TG_PT bit for reservations

On 07/08/2016 07:23 AM, Christoph Hellwig wrote: > These only work if the we use the same initiator ID for all path, > which might not be true if we use different protocols, or even just > different HBAs. > > Instead dm-mpath will grow support to register all path manually > later in this series.

Re: [dm-devel] [Question] udev ID_UID attribute ???

On 07/07/2016 04:21 PM, Xose Vazquez Perez wrote: > Is "ID_UID" really valid? > > libmultipath/hwtable.c: .uid_attribute = "ID_UID", > I was wondering the same thing. For ceph rbd, we do not have the normal scsi serial/wwn values, so I am modifying our udev rule to export ID_UID. I

Re: [dm-devel] [PATCH 0/4] multipath-tools: Ceph rbd support

On 07/08/2016 03:15 AM, Christophe Varoqui wrote: > Hi Mike, > > this patchset was broken by the resync with hannes rcu v2 branch. > Can you rebase it in the light of the changes to the conf pointer access > applied in dbd9ad6f0e555707335ec71e1c5bec1723e02f79 ? > Yeah, no problem. > Thanks. >

[dm-devel] [PATCH 1/1] block: fix blk_queue_split() resource exhaustion

For a long time, generic_make_request() converts recursion into iteration by queuing recursive arguments on current->bio_list. This is convenient for stacking drivers, the top-most driver would take the originally submitted bio, and re-submit a re-mapped version of it, or one or more clones, or

Re: [dm-devel] [PATCH 1/1] multipath-tools: fix dm- device filtering

Thank you! On Fri, Jul 8, 2016 at 2:42 AM, Christophe Varoqui < christophe.varo...@opensvc.com> wrote: > Rebased and merged. > Thanks. > > On Tue, Jul 5, 2016 at 10:46 PM, Dragan Stancevic < > dragan.stance...@canonical.com> wrote: > >> During "service multipath-tools start" /sbin/multipath is

Re: [dm-devel] [PATCH 0/5] Makefiles housekeeping II

I'd rather follow the preference of distributors. On Fri, Jul 8, 2016 at 3:02 PM, Xose Vazquez Perez wrote: > On 07/08/2016 09:16 AM, Christophe Varoqui wrote: > > > Merged patches 1, 2 and 3 of this set. > > > > I postponed merging the patches adding fullpath links in

Re: [dm-devel] block: fix blk_queue_split() resource exhaustion

On Fri, Jul 08 2016 at 8:52am -0400, Lars Ellenberg wrote: > On Fri, Jul 08, 2016 at 07:08:32PM +0800, Ming Lei wrote: > > > So after processing a particular bio, we should then process all the > > > 'child' bios - bios send to underlying devices. Then the 'sibling'

Re: [dm-devel] [PATCH 0/5] Makefiles housekeeping II

On 07/08/2016 09:16 AM, Christophe Varoqui wrote: > Merged patches 1, 2 and 3 of this set. > > I postponed merging the patches adding fullpath links in libs. > Are you sure it is best practice to use fullpaths there ? This is up to you. It works as is. But in "libmpathpersist/Makefile" is done

Re: [dm-devel] [RFC] block: fix blk_queue_split() resource exhaustion

On Fri, Jul 08, 2016 at 07:39:36PM +1000, NeilBrown wrote: > >> To make the patch "perfect", and maybe even more elegant we could treat > >> ->remainder and ->recursion more alike. > >> i.e.: > >> - generic make request has a private "stack" of requests. > >> - before calling

[dm-devel] [PATCH 2/2] dm: call PR reserve/unreserve on each underlying device

So far we tried to rely on the SCSI 'all target ports' bit to register all path, but for many setups this didn't work properly as the different path aren seen as separate initiators to the target instead of multiple ports of the same initiator. Because of that we'll stop setting the 'all target

[dm-devel] PR API fixes for multipathing

I was a bit overeager to thing ALL_TG_PT would solve all our multipathing woes in respect to persistent reservation. Turns out that there are lots of possible setups where it doesn't work, and we'll have to ask device mapper to register all underlying devices instead. -- dm-devel mailing list

[dm-devel] [PATCH 1/2] sd: don't use the ALL_TG_PT bit for reservations

These only work if the we use the same initiator ID for all path, which might not be true if we use different protocols, or even just different HBAs. Instead dm-mpath will grow support to register all path manually later in this series. Signed-off-by: Christoph Hellwig ---

Re: [dm-devel] [RFC] block: fix blk_queue_split() resource exhaustion

On Fri, Jul 8, 2016 at 6:07 AM, NeilBrown wrote: > On Thu, Jul 07 2016, Lars Ellenberg wrote: > >> On Thu, Jul 07, 2016 at 03:35:48PM +1000, NeilBrown wrote: >>> On Wed, Jun 22 2016, Lars Ellenberg wrote: >>> >>> > For a long time, generic_make_request() converts recursion into

Re: [dm-devel] [RFC] block: fix blk_queue_split() resource exhaustion

On Fri, Jul 08 2016, Lars Ellenberg wrote: > On Fri, Jul 08, 2016 at 08:07:52AM +1000, NeilBrown wrote: >> Before I introduced the recursion limiting, requests were handled as an >> in-order tree walk. The code I wrote tried to preserve that but didn't >> for several reasons. I think we need to

Re: [dm-devel] [PATCH 0/4] multipath-tools: Ceph rbd support

Hi Mike, this patchset was broken by the resync with hannes rcu v2 branch. Can you rebase it in the light of the changes to the conf pointer access applied in dbd9ad6f0e555707335ec71e1c5bec1723e02f79 ? Thanks. On Tue, Jul 5, 2016 at 10:12 AM, Mike Christie wrote: > The

Re: [dm-devel] [RFC] block: fix blk_queue_split() resource exhaustion

On Fri, Jul 08, 2016 at 08:07:52AM +1000, NeilBrown wrote: > Before I introduced the recursion limiting, requests were handled as an > in-order tree walk. The code I wrote tried to preserve that but didn't > for several reasons. I think we need to restore the original in-order > walk because it

Re: [dm-devel] [PATCH 1/1] multipath-tools: fix dm- device filtering

Rebased and merged. Thanks. On Tue, Jul 5, 2016 at 10:46 PM, Dragan Stancevic < dragan.stance...@canonical.com> wrote: > During "service multipath-tools start" /sbin/multipath is > called on dm- devices that are filtered but due to a condition > conf->dev_type == DEV_DEVNODE in filtering code

Re: [dm-devel] [PATCH] readsector0: the length of the buffer wrong

Merged. Thanks. On Tue, Jul 5, 2016 at 1:48 PM, wrote: > hi, > > The length of the buffer is 4096, not 4069 in sg_read(). > > --- > libmultipath/checkers/readsector0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [dm-devel] [PATCH] multipathd: restore paths after reconfigure

Merged. Thanks. On Fri, Jul 1, 2016 at 11:46 PM, Benjamin Marzinski wrote: > multipathd has code to finish gathering the information of paths that > were not active at the time they were discovered. When the checker loop > goes to check a path, and notices that it wasn't

Re: [dm-devel] [PATCH 0/5] Makefiles housekeeping II

Merged patches 1, 2 and 3 of this set. I postponed merging the patches adding fullpath links in libs. Are you sure it is best practice to use fullpaths there ? Thanks. On Fri, Jul 1, 2016 at 7:17 PM, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui

Re: [dm-devel] [PATCH] multipath-tools: make defaults values more visible in multipath.conf.5

Merged. Thanks. On Sun, Jul 3, 2016 at 1:06 AM, Xose Vazquez Perez wrote: > Put them in a new paragraph, and in bold. > > Easier to read and cleaner layout. > > man page in PDF at: > https://drive.google.com/file/d/0B_B6YmEmO7cDVTl2djM1YkZMNFE > > Cc: Christophe Varoqui

Re: [dm-devel] [PATCH 0/2] multipath-tools: Licence housekeeping

This patchset is merged. Thanks. On Thu, Jun 30, 2016 at 4:39 PM, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez > >

Re: [dm-devel] [PATCH 0/5] multipath-tools: Makefiles housekeeping

This patchset is merged. Thanks. On Thu, Jun 30, 2016 at 3:44 PM, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez > > >

Re: [dm-devel] [PATCH] multipath-tools: new ONTAP maintainer

Merged. Thanks. On Fri, Jun 24, 2016 at 7:48 PM, Martin George wrote: > Looks good. > > Acked-by: Martin George > > > On 6/23/2016 8:36 PM, Xose Vazquez Perez wrote: > >> Martin George is in charge of the ONTAP family. >> >> Cc: Martin George

Re: [dm-devel] [PATCH 0/4] make tur the default path checker

Patches 1 and 2 are merged. I commited a patch to delete DIRECTIO and TUR checker_name settings to replace patch 3 and 4. Thanks. On Thu, Jun 23, 2016 at 3:42 PM, Xose Vazquez Perez wrote: > Based on previous Hannes's work. > He says: > "For years I've been telling our

Re: [dm-devel] [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI

All nine patches of this set are merged. Thanks. On Tue, Jun 21, 2016 at 2:35 AM, Xose Vazquez Perez wrote: > Devices running 2.x firmware has a different product id for iSCSI. > > Cc: Christophe Varoqui > Cc: device-mapper development

Re: [dm-devel] [PATCH 1/2] multipath-tools: replace spaces with tabs in defaults.h

Merged. Thanks. On Sun, Jun 12, 2016 at 12:14 AM, Xose Vazquez Perez wrote: > replace spaces by tabs in defaults.h > > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez

Re: [dm-devel] [PATCH] multipath/main.c fix a minor typo

Rebased and merged. Thanks. On Fri, Jul 1, 2016 at 1:17 PM, Milan P. Gandhi wrote: > Hello, Below patch fixes a minor typo in multipath/main.c > > Thanks, > Milan. > > Signed-off-by: Milan P. Gandhi > --- > > diff --git a/multipath/main.c