Re: [dm-devel] [PATCH 06/15] libmultipath: Remove an unused function

2016-10-24 Thread Bart Van Assche
On 10/24/16 03:50, Germano Percossi wrote: On 10/21/2016 07:43 PM, Bart Van Assche wrote: The function snprint_config() is not used. Hence remove it. Signed-off-by: Bart Van Assche --- libmultipath/print.c | 6 -- 1 file changed, 6 deletions(-) diff --git

Re: [dm-devel] [PATCH 06/15] libmultipath: Remove an unused function

2016-10-24 Thread Bart Van Assche
On 10/24/2016 07:55 AM, Germano Percossi wrote: Sorry, my reply was meant for mpath_prin_pthread_fn patch but, I guess, given the lack of a declaration in a header file, your answer will be the same. Hello Germano, Inspection of the git log -p output learned me that also

Re: [dm-devel] device mapper and the BLKFLSBUF ioctl

2016-10-24 Thread Mike Snitzer
On Fri, Oct 21 2016 at 4:18P -0400, Mikulas Patocka wrote: > > > On Fri, 21 Oct 2016, Mike Snitzer wrote: > > > On Fri, Oct 21 2016 at 2:33pm -0400, > > Mikulas Patocka wrote: > > > > > Hi > > > > > > I found a bug in dm regarding the BLKFLSBUF

Re: [dm-devel] [PATCH 06/15] libmultipath: Remove an unused function

2016-10-24 Thread Germano Percossi
Sorry, my reply was meant for mpath_prin_pthread_fn patch but, I guess, given the lack of a declaration in a header file, your answer will be the same. Germano On 10/24/2016 03:26 PM, Bart Van Assche wrote: > On 10/24/16 03:50, Germano Percossi wrote: >> On 10/21/2016 07:43 PM, Bart Van Assche

[dm-devel] [PATCH] multipath-tools: identify SUN/T4 as 6020 and 6120

2016-10-24 Thread Xose Vazquez Perez
Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c

Re: [dm-devel] [PATCH 06/15] libmultipath: Remove an unused function

2016-10-24 Thread Germano Percossi
Removing functions packaged in a library just because they are not used in multipath does not seem fine, in general. They could still be used by third party. Germano On 10/21/2016 07:43 PM, Bart Van Assche wrote: > The function snprint_config() is not used. Hence remove it. > > Signed-off-by: