[dm-devel] [PATCH] Remove duplicated code in mpath_alloc_prin_response()

2016-10-30 Thread ding . yemin
From: "ding.yemin" Remove duplicated code in mpath_alloc_prin_response(). Signed-off-by: ding.yemin --- libmpathpersist/mpath_persist.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git

Re: [dm-devel] [PATCH 09/10] add disable_changed_wwids option

2016-10-30 Thread Hannes Reinecke
On 10/29/2016 04:55 AM, Benjamin Marzinski wrote: If a LUN on a storage device gets remapped while in-use by multipath, it's possible that the multipath device will continue writing to this new LUN, causing corruption. This is not multipath's fault (users should go remapping in-use LUNs), but

Re: [dm-devel] [PATCH 10/10] set retrigger_tries to 0 for multipath

2016-10-30 Thread Hannes Reinecke
On 10/29/2016 04:55 AM, Benjamin Marzinski wrote: Multipathd uses retrigger_tries to give udev more chances to to fill in the uid_attribute, so that the path device is correctly set up in the udev database. However the multipath command can't do this, so it should just immediately give up on

Re: [dm-devel] [PATCH 08/10] fix INIT_REQUESTED_UDEV code

2016-10-30 Thread Hannes Reinecke
On 10/29/2016 04:55 AM, Benjamin Marzinski wrote: uev_update_path was not checking pp->initialized to see if multipathd had requested that the path be reinitialized unless the path's read-only state had changed. This kept the reinitialization code from running in most cases where it was

Re: [dm-devel] [PATCH 04/10] multipathd: add "map failures" format wildcard

2016-10-30 Thread Hannes Reinecke
On 10/29/2016 04:55 AM, Benjamin Marzinski wrote: This patch adds a new wildcard, 'x', for the "show maps format" command. This wildcard show the number of map failures that have occurred. A map failure is any time that the multipath device enters a state where it has no paths and is not set to

Re: [dm-devel] [PATCH 06/10] multipath: set cookie before using it.

2016-10-30 Thread Hannes Reinecke
On 10/29/2016 04:55 AM, Benjamin Marzinski wrote: dm_task_set_cookie() expects the cookie to be initialized when it is called, but dm_rename() didn't initialized it, causing renames to fail some of the time. Signed-off-by: Benjamin Marzinski --- libmultipath/devmapper.c |

[dm-devel] [PATCH 02/10] kpartx.rules: respect skip_kpartx flag

2016-10-30 Thread Benjamin Marzinski
Check if DM_SUBSYSTEM_UDEV_FLAG1 is set, and if so, don't run kpartx. If the event was not generated by device-mapper, just use the existing value of DM_SUBSYSTEM_UDEV_FLAG1. Signed-off-by: Benjamin Marzinski --- kpartx/kpartx.rules | 2 ++ 1 file changed, 2 insertions(+)

[dm-devel] [PATCH 04/10] multipathd: add "map failures" format wildcard

2016-10-30 Thread Benjamin Marzinski
This patch adds a new wildcard, 'x', for the "show maps format" command. This wildcard show the number of map failures that have occurred. A map failure is any time that the multipath device enters a state where it has no paths and is not set to queue_if_no_paths. It can be used to see if a

[dm-devel] [PATCH 00/10] misc. multipath patches.

2016-10-30 Thread Benjamin Marzinski
Here are a number of multipath patches. The first two are resends of the skip_kpartx patches that didn't get merged from my last patchset. I didn't see any complaints about them, so I just rebased them. If there are any questions or objections, please let me know. The third and ninth patches

[dm-devel] [PATCH] multipath-tools: clean up and organize multipathd/multipathd.8

2016-10-30 Thread Xose Vazquez Perez
Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipathd/multipathd.8 | 271 1 file changed, 180 insertions(+), 91

[dm-devel] [PATCH 10/10] set retrigger_tries to 0 for multipath

2016-10-30 Thread Benjamin Marzinski
Multipathd uses retrigger_tries to give udev more chances to to fill in the uid_attribute, so that the path device is correctly set up in the udev database. However the multipath command can't do this, so it should just immediately give up on udev, and try to get the wwid directly. Signed-off-by:

Re: [dm-devel] [PATCH] Remove duplicated code in mpath_alloc_prin_response()

2016-10-30 Thread Bart Van Assche
On 10/25/2016 01:19 AM, ding.ye...@zte.com.cn wrote: } + if (size > 0) + { + ptr = malloc(size); + if (ptr) + { + memset(ptr, 0, size); + } + } return ptr; } Hello Ding Yemin,

Re: [dm-devel] REQ_OP for zeroing, was Re: [PATCH 1/4] brd: handle misaligned discard

2016-10-30 Thread Mikulas Patocka
On Wed, 26 Oct 2016, Christoph Hellwig wrote: > On Wed, Oct 26, 2016 at 05:46:11PM -0400, Mikulas Patocka wrote: > > I think the proper thing would be to move "discard_zeroes_data" flag into > > the bio itself - there would be REQ_OP_DISCARD and REQ_OP_DISCARD_ZERO - > > and if the device

[dm-devel] [PATCH] md/dm-mpath: Add NULL pointer check in parse_hw_handler()

2016-10-30 Thread tang . junhui
From: "tang.junhui" m->hw_handler_name value should be checked in parse_hw_handler() after calling kstrdup() to avoid access of NULL pointer. Signed-off-by: tang.junhui --- drivers/md/dm-mpath.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [dm-devel] [PATCH] scsi: update rdac devices at scsi_dh_rdac

2016-10-30 Thread Babu Moger
At this point, I am not the right person to ack this change. However, adding new vendor id's is mostly not an issue. But, removing could be a problem. Sean has to confirm this. On 10/18/2016 10:11 AM, Xose Vazquez Perez wrote: On 10/07/2016 06:55 PM, Xose Vazquez Perez wrote: This patch is

[dm-devel] [PATCH] RCU protection for variable conf in add_map_with_path()

2016-10-30 Thread ding . yemin
From: "ding.yemin" Take the variable "conf" under RCU protection in add_map_with_path()。 Signed-off-by: ding.yemin --- libmultipath/structs_vec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libmultipath/structs_vec.c

[dm-devel] [PATCH] [linux-next] Doc: dm raid: Fix typo in dm-raid.txt

2016-10-30 Thread Masanari Iida
This patch fix spelling typos in Documentation/device-mapper/dm-raid.txt. Signed-off-by: Masanari Iida --- Documentation/device-mapper/dm-raid.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/device-mapper/dm-raid.txt