Re: [dm-devel] [PATCH v2] block: disallow changing max_sectors_kb on a request stacking device

On Mon, Nov 07 2016 at 9:46pm -0500, Martin K. Petersen wrote: > > "Mike" == Mike Snitzer writes: > > Mike, > > Mike> You're suggesting that when the DM multipath device's limits are > Mike> stacked up from the underlying devices: cap the

[dm-devel] [PATCH] multipathd: fix uev_update_path dead lock

From: 10144149 Deadlock occurred in uev_add_path() when >lock would lock twice in uev_update_path() --- multipathd/main.c | 54 ++ multipathd/main.h | 1 + 2 files changed, 31 insertions(+), 24 deletions(-) diff

Re: [dm-devel] [PATCH v2] block: disallow changing max_sectors_kb on a request stacking device

On Mon, Nov 07 2016 at 2:32pm -0500, Jens Axboe wrote: > On 11/07/2016 12:26 PM, Mike Snitzer wrote: > >Otherwise users can easily shoot themselves in the foot by creating the > >situation where the top-level stacked device (e.g. DM multipath) has a > >larger max_sectors_kb

Re: [dm-devel] [PATCH v2] block: disallow changing max_sectors_kb on a request stacking device

On 11/07/2016 12:26 PM, Mike Snitzer wrote: Otherwise users can easily shoot themselves in the foot by creating the situation where the top-level stacked device (e.g. DM multipath) has a larger max_sectors_kb than the underlying device(s). Which will certainly lead to IO errors due to the "over

[dm-devel] [PATCH v2] block: disallow changing max_sectors_kb on a request stacking device

Otherwise users can easily shoot themselves in the foot by creating the situation where the top-level stacked device (e.g. DM multipath) has a larger max_sectors_kb than the underlying device(s). Which will certainly lead to IO errors due to the "over max size limit" check in

[dm-devel] no_path_retry: NO_PATH_RETRY_FAIL vs NO_PATH_RETRY_UNDEF

Hi, NO_PATH_RETRY_UNDEF is 0 no_path_retrySpecify what to do when all paths are down. Possible values are: value > 0 number of retries until disable I/O queueing. failfor immediate failure (no I/O queueing). queue

[dm-devel] [PATCH 2/3] dm-crypt: add ability to use keys from the kernel key retention service

From: Andrey Ryabinin (original patch rebased on top of previous one by Ondrej Kozina) The kernel key service is a generic way to store keys for the use of other subsystems. Currently there is no way to use kernel keys in dm-crypt. This patch aims to fix that. Instead

[dm-devel] [PATCH] libmultipath: remove unnecessary condition in checker_repair

From: PengLiang The checker's validity is an unnecessary checking. It will be checked in checker_selected. Signed-off-by: PengLiang --- libmultipath/checkers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dm-devel] [PATCH] libmultipath: add missing character '(' in select_prio()

From: tang wenji Signed-off-by: tang wenji --- libmultipath/propsel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c index ec1fd92..cff9a33 100644 --- a/libmultipath/propsel.c +++

Re: [dm-devel] multipath bug and patch

I can add those checks instead. I'll look at it this weekend and make up a new set of patches. I'll admit my fix is a bit of a hack. If I remember I did it this way to reduce the amount of change required. I hacked this in something like 2 years ago and kept telling myself I needed to