Re: [dm-devel] [PATCH 7/7] dm-mpath: Fix a race condition in __multipath_map()

On Mon, Nov 21 2016 at 6:57pm -0500, Bart Van Assche wrote: > On 11/21/2016 03:43 PM, Mike Snitzer wrote: > >Shouldn't be possible. The previous stacktrace you shared clearly > >showed that the DM mpath request_queue was using blk-mq (dm_mq_queue_rq > >was in the

Re: [dm-devel] [PATCH 7/7] dm-mpath: Fix a race condition in __multipath_map()

On 11/21/2016 03:43 PM, Mike Snitzer wrote: Shouldn't be possible. The previous stacktrace you shared clearly showed that the DM mpath request_queue was using blk-mq (dm_mq_queue_rq was in the stack). Whereas the stacktrace above is clearly the old request_fn interface. I'm unaware of how the

Re: [dm-devel] [PATCH 7/7] dm-mpath: Fix a race condition in __multipath_map()

On Mon, Nov 21 2016 at 4:44pm -0500, Bart Van Assche wrote: > On 11/15/2016 04:37 PM, Mike Snitzer wrote: > > On Tue, Nov 15 2016 at 6:35pm -0500, > > Bart Van Assche wrote: > > > >> If a single-queue dm device is stacked on top of

[dm-devel] [PATCH] multipath-tools: convert Promise/VTrak to ALUA

It's also supported. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[dm-devel] [PATCH] multipath-tools: add Promise/Vess to hwtable

Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libmultipath/hwtable.c

Re: [dm-devel] [PATCH 7/7] dm-mpath: Fix a race condition in __multipath_map()

On 11/15/2016 04:37 PM, Mike Snitzer wrote: > On Tue, Nov 15 2016 at 6:35pm -0500, > Bart Van Assche wrote: > >> If a single-queue dm device is stacked on top of multi-queue block >> devices and map_tio_request() is called while there are no paths then >> the request

[dm-devel] [PATCH] Add blkzonecmd and blkreport ZAC/ZBC drives

This patch adds: - blkreset to issue Reset (Write Pointer) zone commands - blkreport to retrieve drive zone information Signed-off-by: Shaun Tancheff Signed-off-by: Shaun Tancheff --- .gitignore | 2 + configure.ac|

Re: [dm-devel] [PATCH] Add blkzonecmd and blkreport ZAC/ZBC drives

On Mon, Nov 21, 2016 at 1:51 PM, Bart Van Assche wrote: > On 11/21/2016 11:29 AM, Shaun Tancheff wrote: >> >> This patch adds: >> - blkreset to issue Reset (Write Pointer) zone commands >> - blkreport to retrieve drive zone information >> >> Signed-off-by: Shaun

[dm-devel] [PATCH] Add blkzonecmd and blkreport ZAC/ZBC drives

This patch adds: - blkreset to issue Reset (Write Pointer) zone commands - blkreport to retrieve drive zone information Signed-off-by: Shaun Tancheff Signed-off-by: Shaun Tancheff --- .gitignore | 2 + configure.ac|

Re: [dm-devel] Improve processing efficiency for addition and deletion of multipath devices

On Fri, Nov 18, 2016 at 09:30:57AM +0100, Martin Wilck wrote: > On Fri, 2016-11-18 at 16:24 +0800, tang.jun...@zte.com.cn wrote: > > Hi Martin,  > > > > In your case, my action is:  > > 1) merger uevents 1) 2) to one uevent "add sda sdb", and process them > > togother  > > This will fail because

Re: [dm-devel] [PATCH v3] dm-crypt: add ability to use keys from the kernel key retention service

On Mon, Nov 21 2016 at 9:58P -0500, Ondrej Kozina wrote: > Changes since v2: > - moved rcu_read_lock() closer to key payload processing (thanks Mikulas) > - updated dm-crypt documentation > - updated code comments and unified parameter names in kernel keyring >

Re: [dm-devel] [PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page

On Fri, Nov 11 2016 at 7:05am -0500, Ming Lei wrote: > Firstly we have mature bvec/bio iterator helper for iterate each > page in one bio, not necessary to reinvent a wheel to do that. > > Secondly the coming multipage bvecs requires this patch. > > Also add comments

Re: [dm-devel] [PATCH 08/12] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

On Fri, Nov 11 2016 at 7:05am -0500, Ming Lei wrote: > Avoid to access .bi_vcnt directly, because the bio can be > splitted from block layer, and .bi_vcnt should never have > been used here. > > Signed-off-by: Ming Lei I've staged this for 4.10

[dm-devel] [RFC PATCH] crypto: Add IV generation algorithms

Currently, the iv generation algorithms are implemented in dm-crypt.c. The goal is to move these algorithms from the dm layer to the kernel crypto layer by implementing them as template ciphers so they can be used in relation with algorithms like aes, and with multiple modes like cbc, ecb etc. As

Re: [dm-devel] [PATCH v2] dm-crypt: add ability to use keys from the kernel key retention service

On 11/17/2016 09:06 PM, Ondrej Kozina wrote: On 11/17/2016 05:35 PM, Andrey Ryabinin wrote: On 11/16/2016 11:47 PM, Ondrej Kozina wrote: (Please still consider it to be RFC only, I need to modify the uspace teststuite again due to changes in key_string format. Also the changes to dm-crypt

[dm-devel] [PATCH] multipath-tools: remove NO_PATH_RETRY_FAIL from hwtable

It's the default value. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libmultipath/hwtable.c

Re: [dm-devel] dm-cache issue

On 16.11.2016 16:06, Zdenek Kabelac wrote: Dne 16.11.2016 v 14:45 Teodor Milkov napsal(a): On 16.11.2016 11:24, Zdenek Kabelac wrote: My first 'guess' in this reported case is - the disk I/O traffic seen is related to the 'reload' of cached chunks from disk back to cache. This will happen in