Re: [dm-devel] [PATCH 7/7] dm-mpath: Fix a race condition in __multipath_map()

2016-11-22 Thread Mike Snitzer
On Tue, Nov 22 2016 at 7:48P -0500, Mike Snitzer wrote: > But regardless, what certainly needs fixing is the inconsistency of > inheriting DM_TYPE_MQ_REQUEST_BASED but not setting all_blk_mq to true > (all_blk_mq == true is implied by DM_TYPE_MQ_REQUEST_BASED). > > I'm now

Re: [dm-devel] Improve processing efficiency for addition and deletion of multipath devices

2016-11-22 Thread tang . junhui
So, now we have at least 4 ways to improve mutliapth efficiency: 1) Filtering uevents; 2) Merger uevents; 3) Using separate locks for mpvec and pathvec; 4) Get rid of the gazillion waiter threads. This is exciting, but how do we achieve this blueprint? Can we set up some working groups and

Re: [dm-devel] [PATCH 7/7] dm-mpath: Fix a race condition in __multipath_map()

2016-11-22 Thread Mike Snitzer
On Tue, Nov 22 2016 at 6:47pm -0500, Bart Van Assche wrote: > On 11/21/2016 04:34 PM, Mike Snitzer wrote: > >But you WARN_ON_ONCE(clone && q->mq_ops) will trigger with sq-on-mq. > > Hello Mike, > > This behavior is indeed triggered by the sq-on-mq test. After

[dm-devel] [PATCH] multipath-tools: identify DataCore SANsymphony in hwtable

2016-11-22 Thread Xose Vazquez Perez
Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c

Re: [dm-devel] [PATCH 00/12] block: cleanup direct access to bvec table

2016-11-22 Thread Jens Axboe
On 11/11/2016 05:05 AM, Ming Lei wrote: Hi, This patchset cleans up direct access to bvec table. The 1st patch passes bvec table to bio_init(), so that direct access to bvec table in bio initialization is avoided. For other patches, most of them uses bio_add_page() to replace hardcode style

Re: [dm-devel] [PATCH] New device mapper target ZDM

2016-11-22 Thread Alasdair G Kergon
Well to start with some device-mapper basics, looks at the newer files (e.g. thin-provisioning.txt, cache.txt) in the Documentation directory to see what format to use and how to document the interface. Constructor, status, examples using dmsetup only etc. (BTW We don't use equals signs in our

Re: [dm-devel] [PATCH] New device mapper target ZDM

2016-11-22 Thread Bart Van Assche
On 11/21/16 11:23, Shaun Tancheff wrote: > +/* > -- */ > +/* --ProcFS Support > Routines- */ > +/* > --

Re: [dm-devel] [PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page

2016-11-22 Thread Ming Lei
On Mon, Nov 21, 2016 at 10:49 PM, Mike Snitzer wrote: > On Fri, Nov 11 2016 at 7:05am -0500, > Ming Lei wrote: > >> Firstly we have mature bvec/bio iterator helper for iterate each >> page in one bio, not necessary to reinvent a wheel to do that. >> >>