[dm-devel] [PATCH 0/2] multipath-tools: Add security hardening build flags

2016-12-05 Thread Xose Vazquez Perez
Xose Vazquez Perez (2): multipath-tools: Replace -fstack-protector with -fstack-protector-strong multipath-tools: Add -Werror compilation flags Makefile.inc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Cc: Christophe Varoqui Cc: device-mapper

[dm-devel] [PATCH 2/2] multipath-tools: Add -Werror compilation flags

2016-12-05 Thread Xose Vazquez Perez
Add -Werror=format-security: GCC will refuse to compile code that could be vulnerable to a string format security flaw. At present, this warns about calls to "printf" and "scanf" from untrusted input and contains %n. Add -Werror=implicit-function-declaration: Implicit function declarations allows

[dm-devel] [PATCH 1/2] multipath-tools: Replace -fstack-protector with -fstack-protector-strong

2016-12-05 Thread Xose Vazquez Perez
-fstack-protector-strong Like -fstack-protector but includes additional functions to be protected --- those that have local array definitions, or have references to local frame addresses. gcc-4.9.0(April 22, 2014) required. This flag is used by default in Fedora:

Re: [dm-devel] [PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

2016-12-05 Thread Jens Axboe
On 12/05/2016 03:40 PM, Mike Snitzer wrote: > On Mon, Dec 5, 2016 at 10:07 AM, Jens Axboe wrote: >> >> On 12/05/2016 06:05 AM, Christoph Hellwig wrote: >>> On Fri, Dec 02, 2016 at 08:15:15PM -0700, Jens Axboe wrote: No functional changes with this patch, it's just in

[dm-devel] [PATCH v2] crypto/mcryptd: Check mcryptd algorithm compatibility

2016-12-05 Thread Tim Chen
Algorithms not compatible with mcryptd could be spawned by mcryptd with a direct crypto_alloc_tfm invocation using a "mcryptd(alg)" name construct. This causes mcryptd to crash the kernel if an arbitrary "alg" is incompatible and not intended to be used with mcryptd. It is an issue if AF_ALG

Re: [dm-devel] [PATCH] crypto/mcryptd: Check mcryptd algorithm compatability

2016-12-05 Thread Tim Chen
On Mon, 2016-12-05 at 20:34 +0800, Herbert Xu wrote: > On Fri, Dec 02, 2016 at 04:15:21PM -0800, Tim Chen wrote: > > > > Algorithms not compatible with mcryptd could be spawned by mcryptd > > with a direct crypto_alloc_tfm invocation using a "mcryptd(alg)" > > name construct.  This causes mcryptd

Re: [dm-devel] [PATCH] crypto/mcryptd: Check mcryptd algorithm compatability

2016-12-05 Thread Tim Chen
On Mon, 2016-12-05 at 08:50 -0800, Tim Chen wrote: > On Mon, 2016-12-05 at 20:34 +0800, Herbert Xu wrote: > > > > On Fri, Dec 02, 2016 at 04:15:21PM -0800, Tim Chen wrote: > > > > > > > > > Algorithms not compatible with mcryptd could be spawned by mcryptd > > > with a direct crypto_alloc_tfm

Re: [dm-devel] [PATCH] multipath-tools: add CFLAGS to compilation options for prioritizers and checkers

2016-12-05 Thread Xose Vazquez Perez
On 11/26/2016 11:26 PM, Xose Vazquez Perez wrote: > Is there anything else missing or leftover? Please, drop this patch. Thank you. > $ git grep "(CC)" > Makefile.inc: $(CC) $(CFLAGS) -c -o $@ $< > kpartx/Makefile:$(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS) > $(LIBDEPS) >

Re: [dm-devel] [PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

2016-12-05 Thread Mike Snitzer
On Mon, Dec 5, 2016 at 10:07 AM, Jens Axboe wrote: > > On 12/05/2016 06:05 AM, Christoph Hellwig wrote: > > On Fri, Dec 02, 2016 at 08:15:15PM -0700, Jens Axboe wrote: > >> No functional changes with this patch, it's just in preparation for > >> supporting legacy schedulers on

Re: [dm-devel] [PATCH] crypto/mcryptd: Check mcryptd algorithm compatability

2016-12-05 Thread Herbert Xu
On Fri, Dec 02, 2016 at 04:15:21PM -0800, Tim Chen wrote: > Algorithms not compatible with mcryptd could be spawned by mcryptd > with a direct crypto_alloc_tfm invocation using a "mcryptd(alg)" > name construct. This causes mcryptd to crash the kernel if > "alg" is incompatible and not intended

Re: [dm-devel] how do i push my changes in dm layer to main stream

2016-12-05 Thread Zdenek Kabelac
Dne 5.12.2016 v 07:29 muneendra kumar napsal(a): Hi, This is a general question. If i do any changes in both multipath tool and dm driver (kernel). How do i push my changes into main stream. Can someone explain me the process so that it will help me a lot. Hi You propose your changes here

Re: [dm-devel] [PATCH] dm space map: always set ev if sm_ll_mutate() succeeds

2016-12-05 Thread Edward Thornber
ack On Sun, Dec 04, 2016 at 11:26:38PM -0600, Benjamin Marzinski wrote: > If no block was allocated or freed, sm_ll_mutate() wasn't setting > *ev, leaving the variable unitialized. sm_ll_insert(), > sm_disk_inc_block(), and sm_disk_new_block() all check ev to see > if there was an allocation

Re: [dm-devel] dm-cache issue

2016-12-05 Thread Teodor Milkov
So, I ended up with the following setup: * Modified /etc/init.d/lvm2 to explicitly deactivate logical volumes: /lvm lvchange -a n --select name=~.*/ o Createlvm2-clean-shutdown /if deactivation is successful.// * Turn off automatic LV activation by

[dm-devel] how do i push my changes in dm layer to main stream

2016-12-05 Thread muneendra kumar
Hi, This is a general question. If i do any changes in both multipath tool and dm driver (kernel). How do i push my changes into main stream. Can someone explain me the process so that it will help me a lot. Regards, Muneendra. -- dm-devel mailing list dm-devel@redhat.com

[dm-devel] [PATCH] crypto/mcryptd: Check mcryptd algorithm compatability

2016-12-05 Thread Tim Chen
Algorithms not compatible with mcryptd could be spawned by mcryptd with a direct crypto_alloc_tfm invocation using a "mcryptd(alg)" name construct. This causes mcryptd to crash the kernel if "alg" is incompatible and not intended to be used with mcryptd. A flag CRYPTO_ALG_MCRYPT is being added

Re: [dm-devel] Crash in crypto mcryptd

2016-12-05 Thread Tim Chen
On Thu, 2016-12-01 at 23:06 -0800, Eric Biggers wrote: > On Thu, Dec 01, 2016 at 05:47:02PM -0800, Tim Chen wrote: > > > > On Thu, 2016-12-01 at 19:00 -0500, Mikulas Patocka wrote: > > > > > > Hi > > > > > > There is a bug in mcryptd initialization. > > > > > > This is a test module that tries