Re: [dm-devel] [PATCH] dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-16 Thread Eric Wheeler
On Wed, 14 Dec 2016, Eric Wheeler wrote: > Since dm-crypt queues writes (and sometimes reads) to a different kernel > thread (workqueue), the bios will dispatch from tasks with different > io_context->ioprio settings than the submitting task, thus giving > incorrect ioprio hints to the io scheduler

Re: [dm-devel] [RFC PATCH v2] crypto: Add IV generation algorithms

2016-12-16 Thread Binoy Jayan
Hi Milan, On 13 December 2016 at 15:31, Milan Broz wrote: > I think that IV generators should not modify or read encrypted data directly, > it should only generate IV. I was trying to find more information about what you said and how a iv generator should be written. I saw two examples of IV ge

Re: [dm-devel] [PATCH 5/8] linux: drop __bitwise__ everywhere

2016-12-16 Thread Lee Duncan
On 12/14/2016 09:15 PM, Michael S. Tsirkin wrote: > __bitwise__ used to mean "yes, please enable sparse checks > unconditionally", but now that we dropped __CHECK_ENDIAN__ > __bitwise is exactly the same. > There aren't many users, replace it by __bitwise everywhere. > > Signed-off-by: Michael S.

Re: [dm-devel] [PATCH 5/8] linux: drop __bitwise__ everywhere

2016-12-16 Thread Krzysztof Kozlowski
On Thu, Dec 15, 2016 at 07:15:20AM +0200, Michael S. Tsirkin wrote: > __bitwise__ used to mean "yes, please enable sparse checks > unconditionally", but now that we dropped __CHECK_ENDIAN__ > __bitwise is exactly the same. > There aren't many users, replace it by __bitwise everywhere. > > Signed-o

Re: [dm-devel] trouble with generic/081

2016-12-16 Thread Zdenek Kabelac
Dne 16.12.2016 v 09:15 Christoph Hellwig napsal(a): On Thu, Dec 15, 2016 at 10:16:23AM +0100, Zdenek Kabelac wrote: So let me explain the logic behind this 'amazingly stupid' idea. And that logic doesn't make any sense at all. invibly unmounting a file system behind the users back is actively

Re: [dm-devel] trouble with generic/081

2016-12-16 Thread Christoph Hellwig
On Thu, Dec 15, 2016 at 10:16:23AM +0100, Zdenek Kabelac wrote: > So let me explain the logic behind this 'amazingly stupid' idea. And that logic doesn't make any sense at all. invibly unmounting a file system behind the users back is actively harmful, as it is contradicting the principle of leas