Re: [dm-devel] [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-02 Thread Jack Wang
2016-12-23 12:45 GMT+01:00 Lars Ellenberg : > On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: >> Dear Maintainers >> >> I'd like to ask for the status of this patch since we hit the >> issue too during our testing on md raid1. >> >> Split remainder bio_A

Re: [dm-devel] query on delay_watch_checks and delay_wait_checks

2017-01-02 Thread Muneendra Kumar M
Can anyone help regarding the below query. Regards, Muneendra. From: Muneendra Kumar M Sent: Tuesday, December 27, 2016 2:32 PM To: 'dm-devel@redhat.com' Subject: query on delay_watch_checks and delay_wait_checks If there are two paths on a dm-1 say sda and sdb as below.

[dm-devel] [PATCH v1 12/54] dm: limit the max bio size as BIO_MAX_PAGES * PAGE_SIZE

2017-01-02 Thread Ming Lei
For BIO based DM, some targets aren't ready for dealing with bigger incoming bio than 1Mbyte, such as crypt target. Signed-off-by: Ming Lei --- drivers/md/dm.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm.c

Re: [dm-devel] [RFC PATCH v2] crypto: Add IV generation algorithms

2017-01-02 Thread Binoy Jayan
Hi Herbert, On 22 December 2016 at 14:25, Herbert Xu wrote: > On Tue, Dec 13, 2016 at 11:01:08AM +0100, Milan Broz wrote: >> >> By the move everything to cryptoAPI we are basically introducing some >> strange mix >> of IV and modes there, I wonder how this is going

[dm-devel] [PATCH v1 36/54] dm-crypt: don't clear bvec->bv_page in crypt_free_buffer_pages()

2017-01-02 Thread Ming Lei
The bio is always freed after running crypt_free_buffer_pages(), so it isn't necessary to clear the bv->bv_page. Signed-off-by: Ming Lei --- drivers/md/dm-crypt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index

[dm-devel] Update to kernel 514.2 Breaks RAID0

2017-01-02 Thread Adam Courville
This is using CentOS 7. A previously used striped RAID stalls the boot, because it is not found in /dev/mapper location. When I tried a forced creation of a device using dmsetup using this command: # 'echo "0 $NumSectors striped 2 256 /dev/sdb 0 /dev/sdc 0" | dmsetup create ddf1_4TB' I

Re: [dm-devel] dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2017-01-02 Thread Kent Overstreet
On Sun, Dec 18, 2016 at 06:17:55PM -0500, Mike Snitzer wrote: > Spinning it as a pure bugfix is a reach (as Eric's header documents the > patch, the case is weak for cc'ing stable). Reality is the change is > needed to enable a new bcache feature. I'm not going to rush > feature-enabling change

[dm-devel] dm-crypt optimization

2017-01-02 Thread Binoy Jayan
At a high level the goal is to maximize the size of data blocks that get passed to hardware accelerators, minimizing the overhead from setting up and tearing down operations in the hardware. Currently dm-crypt itself is a big blocker as it manually implements ESSIV and similar algorithms which

[dm-devel] [PATCH] dm bufio: use rb_entry()

2017-01-02 Thread Geliang Tang
To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang --- drivers/md/dm-bufio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c index

Re: [dm-devel] [PATCH v1] dm-crypt: replace custom implementation of hex2bin()

2017-01-02 Thread Andy Shevchenko
On Wed, May 11, 2016 at 2:24 AM, Andy Shevchenko wrote: > There is no need to have a duplication of the generic library, i.e. hex2bin(). > Replace the open coded variant. > Ping? > Signed-off-by: Andy Shevchenko > --- >

Re: [dm-devel] [RFC PATCH v2] crypto: Add IV generation algorithms

2017-01-02 Thread Binoy Jayan
Hi Herbert, On 30 December 2016 at 15:57, Herbert Xu wrote: > This is just a matter of structuring the key for the IV generator. > The IV generator's key in this case should be a combination of the > key to the underlying CBC plus the set of all keys for the IV >

Re: [dm-devel] [PATCH 5/8] linux: drop __bitwise__ everywhere

2017-01-02 Thread Luca Coelho
On Thu, 2016-12-15 at 07:15 +0200, Michael S. Tsirkin wrote: > __bitwise__ used to mean "yes, please enable sparse checks > unconditionally", but now that we dropped __CHECK_ENDIAN__ > __bitwise is exactly the same. > There aren't many users, replace it by __bitwise everywhere. > > Signed-off-by:

Re: [dm-devel] [RFC PATCH v2] crypto: Add IV generation algorithms

2017-01-02 Thread Binoy Jayan
On 2 January 2017 at 12:23, Herbert Xu wrote: > On Mon, Jan 02, 2017 at 12:16:45PM +0530, Binoy Jayan wrote: >> >> Even if ciphers are allocated this way, all the encryption requests >> for cbc should still go through IV generators? So that should mean, >> create one

[dm-devel] dm stats

2017-01-02 Thread A M, Ashalatha
Hi, Just want a clarification about device mapper stats: http://lxr.free-electrons.com/source/Documentation/device-mapper/statistics.txt?v=3.14 In this documentation, would like to know what is the command to be used to create/print/list stats. @stats_create [ []] @stats_print [ ]

Re: [dm-devel] dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2017-01-02 Thread Kent Overstreet
On Sat, Dec 17, 2016 at 10:58:00AM -0500, Mike Snitzer wrote: > The time for 4.10 inclusion has passed. This needs to wait until 4.11. > > It also needs more review, testing and possible re-working. Each DM > target shouldn't have to worry about these details (though I do grant > that

Re: [dm-devel] dm-crypt optimization

2017-01-02 Thread Ofir Drang
-Original Message- From: Herbert Xu [mailto:herb...@gondor.apana.org.au] Sent: Thursday, December 22, 2016 10:59 AM To: Binoy Jayan Cc: Milan Broz; Oded Golombek; Ofir Drang; Arnd Bergmann; Mark Brown; Alasdair Kergon; David S. Miller; private-...@linaro.org; dm-devel@redhat.com;

Re: [dm-devel] dm-crypt optimization

2017-01-02 Thread Binoy Jayan
Hi Milan, On 21 December 2016 at 18:17, Milan Broz wrote: > So the core problem is that your crypto accelerator can operate efficiently > only > with bigger batch sizes. Thank you for the reply. Yes, that would be rather an improvement when having bigger block sizes. >

[dm-devel] [PATCH v1 00/54] block: support multipage bvec

2017-01-02 Thread Ming Lei
Hi, This patchset brings multipage bvec into block layer. Basic xfstests(-a auto) over virtio-blk/virtio-scsi have been run and no regression is found, so it should be good enough to show the approach now, and any comments are welcome! 1) what is multipage bvec? Multipage bvecs means that one

Re: [dm-devel] [RFC PATCH v2] crypto: Add IV generation algorithms

2017-01-02 Thread Binoy Jayan
Hi Herbert, Sorry for the delayed response, I was busy with testing dm-crypt with bonnie++ for regressions. I tried to find some alternative way to keep the IV algorithms' registration in the dm-crypt. Also there were some changes done in dm-crypt keys structure too recently. c538f6e dm crypt:

[dm-devel] [PATCH v1 37/54] dm-crypt: convert to bio_for_each_segment_all_sp()

2017-01-02 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/md/dm-crypt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index 593cdf88bf5f..c6932fb85418 100644 --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -1038,8

Re: [dm-devel] [PATCH v2 1/3] PM suspend/hibernate: Call notifier after freezing processes

2017-01-02 Thread Pali Rohár
On Wednesday 22 July 2015 01:03:23 Rafael J. Wysocki wrote: > On Wed, Jul 22, 2015 at 1:00 AM, Rafael J. Wysocki > wrote: > > Hi Neil, > > > > On Wed, Jul 22, 2015 at 12:08 AM, NeilBrown wrote: > >> On Mon, 20 Jul 2015 23:46:32 +0200 "Rafael J. Wysocki" > >>

Re: [dm-devel] [RFC PATCH v2] crypto: Add IV generation algorithms

2017-01-02 Thread Herbert Xu
On Mon, Jan 02, 2017 at 12:16:45PM +0530, Binoy Jayan wrote: > > Even if ciphers are allocated this way, all the encryption requests > for cbc should still go through IV generators? So that should mean, > create one instance of IV generator using 'crypto_alloc_skcipher' > and create tfms_count