[dm-devel] [PATCH 6/7] multipathd: allow resetting stats

This patch adds two multipathd interactive commands: multipathd reset maps stats and multipathd reset map stats to reset the statistics that are shown with the "show stats" commands. Signed-off-by: Benjamin Marzinski --- multipathd/cli.c | 2 ++

[dm-devel] [PATCH 3/7] libmultipath: cleanup orphan device states

After a path device is orphaned, multipathd stops checking its state. However, multipathd show state still shows its old state. It should display "undef unknown" instead. Signed-off-by: Benjamin Marzinski --- libmultipath/print.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[dm-devel] [PATCH 7/7] fix udev rules for failed multipath devices

11-dm-mpath.rules was only correctly dealing with the case where the multipath device was unusable because the last path had failed. If instead, the last working path was removed from the device on a table reload, it was not correctly marking the device as unusable. One problem with fixing this

[dm-devel] [PATCH 2/7] libmultipath: add detect_checker option

This patch adds a detect_checker option that works just like the detect_prio option. It currently only detects ALUA devices, and if it finds ALUA support, it sets the priortizier to TUR. This is useful for devices like the VNX2, where it should be using the TUR checker when in ALUA mode (or so I

[dm-devel] [PATCH 4/7] multipathd: don't update priority of failed paths

Multipathd shouldn't be updating the priority of failed paths in the checkerloop. The current avoids this in almost all cases, but not all. Close the loophole. Signed-off-by: Benjamin Marzinski --- multipathd/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[dm-devel] [PATCH 0/7] misc patches

Here's a couple of minor features bugfixes and cleanups. The biggest change is that the detect_checker option now sets the checker for devices with detected ALUA to TUR. Also, udev wasn't correctly disabling rules for multipath devices that lost their last usable path through a table reload. This

[dm-devel] [PATCH 1/7] kpartx: don't keep creating recursive partitions

If the dos partition table is corrupted, kpartx can just keep creating the same partitions until it runs out of partition numbers. This check catches the recursion. Signed-off-by: Cedric Buissart Signed-off-by: Benjamin Marzinski --- kpartx/dos.c | 2

Re: [dm-devel] [PATCH] multipath-tools: Remove trailing and leading whitespaces

On 02/10/2017 03:21 PM, Xose Vazquez Perez wrote: > On 02/10/2017 02:49 PM, Christophe Varoqui wrote: > >> Applied. >> Thanks. > > BTW, some patches from Anthony Ryan are missing: > https://marc.info/?l=dm-devel=148362960727218 > https://marc.info/?l=dm-devel=148352341629223 Tang Junhui

Re: [dm-devel] [PATCH] Tolerate modprobe failures in multipathd.service

Applied. Thanks. On Thu, Jan 5, 2017 at 4:30 PM, Benjamin Marzinski wrote: > On Thu, Jan 05, 2017 at 08:33:10AM -0500, Anthony Ryan wrote: > > When these modules are built statically into the kernel, modprobe > > will fail and prevent the service from being started. By

Re: [dm-devel] [PATCH] Include sys/sysmacros.h

Applied. Thanks. On Wed, Jan 4, 2017 at 5:34 AM, Anthony Ryan wrote: > The major, minor & makedev macros are not supposed to be included > with sys/types.h but glibc has done this against POSIX standards. > > Alternative libcs aren't able to be used because of this and

Re: [dm-devel] [PATCH] multipath-tools: Remove trailing and leading whitespaces

On 02/10/2017 02:49 PM, Christophe Varoqui wrote: > Applied. > Thanks. BTW, some patches from Anthony Ryan are missing: https://marc.info/?l=dm-devel=148362960727218 https://marc.info/?l=dm-devel=148352341629223 -- dm-devel mailing list dm-devel@redhat.com

Re: [dm-devel] [PATCH] multipath-tools: Remove trailing and leading whitespaces

Applied. Thanks. On Fri, Feb 10, 2017 at 2:43 PM, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez > --- >

[dm-devel] [PATCH] multipath-tools: Remove trailing and leading whitespaces

Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- kpartx/kpartx_id | 6 +++--- libmultipath/dict.c| 18 libmultipath/propsel.c | 54

Re: [dm-devel] [PATCH 5/5] multipath-tools: Perform socket client uid check on IPC commands.

Applied. On Fri, Jan 20, 2017 at 2:39 PM, Gris Ge wrote: > Problem: > A non-root user could send and execute 'shutdown' IPC command to > multipathd. > > Fix: > Use getsockopt() to find out socket client uid, only query (list or > show) command are allowed for

Re: [dm-devel] [PATCH 4/5] multipath-tools: Set errno mpath_recv_reply() when failure

Applied. On Fri, Jan 20, 2017 at 2:39 PM, Gris Ge wrote: > Enforce what mpath_cmd.h states "-1 on failure (with errno set)" for > mpath_recv_reply() by set errno and return -1 on failure. > > Signed-off-by: Gris Ge > --- > libmpathcmd/mpath_cmd.c | 4 ++-- >

Re: [dm-devel] [PATCH 3/5] multipath-tools: New way to limit the IPC command length.

Applied. On Fri, Jan 20, 2017 at 2:39 PM, Gris Ge wrote: > Problem: > > mpath_recv_reply() from libmpathcmd return -EINVAL on command 'show > maps json' with 2k paths. No error will be triggered for command > `multipathd -k'show maps json` as multipathd is using

Re: [dm-devel] [PATCH 1/5] multipath-tools: libmultipath: fix gcc link failure on rcu_register_thread_mb.

Applied. On Fri, Jan 20, 2017 at 2:38 PM, Gris Ge wrote: > Error: > ../libmultipath/libmultipath.so: undefined reference to > `rcu_register_thread_mb' > ../libmultipath/libmultipath.so: undefined reference to > `rcu_unregister_thread_mb' > > Fix: > Link the

Re: [dm-devel] v4.9, 4.4-final: 28 bioset threads on small notebook, 36 threads on cellphone

On Wed, Feb 08, 2017 at 11:34:07AM -0500, Mike Snitzer wrote: > On Tue, Feb 07 2017 at 11:58pm -0500, > Kent Overstreet wrote: > > > On Tue, Feb 07, 2017 at 09:39:11PM +0100, Pavel Machek wrote: > > > On Mon 2017-02-06 17:49:06, Kent Overstreet wrote: > > > > On Mon,