Re: [dm-devel] [PATCH 01/33] multipathd.service: fixup Wants= and Before= statements

2017-03-13 Thread Benjamin Marzinski
On Tue, Feb 28, 2017 at 05:22:57PM +0100, Martin Wilck wrote: > From: Hannes Reinecke > > With the latest LVM2 update we now have the 'lvm2-lvmetad.service'. > Also we need to specify 'blk-availability.service' in the 'Before=' > statement, as just adding it to 'Wants=' assumes the

[dm-devel] [PATCH v5 1/1] DM: inplace compressed DM target

2017-03-13 Thread Ram Pai
This is a simple DM target supporting inplace compression. Its best suited for SSD. The underlying disk must support 512B sector size, the target only supports 4k sector size. Disk layout: |super|...meta...|..data...| Store unit is 4k (a block). Super is 1 block, which stores meta and data size

[dm-devel] [PATCH v5] DM: dm-inplace-compress: inplace compressed DM target

2017-03-13 Thread Ram Pai
This patch provides a generic device-mapper compression device. Originally written by Shaohua Li. https://www.redhat.com/archives/dm-devel/2013-December/msg00143.html I have optimized and hardened the code. I have not received any negative comments till now. Feel confident with the

Re: [dm-devel] dm-crypt IV generation (summary)

2017-03-13 Thread Mike Snitzer
On Fri, Mar 10 2017 at 8:44am -0500, Ondrej Mosnacek wrote: > Hi all, > > I was tasked to post a summary the whole dm-crypt IV generation > problem and all the suggested solutions along with their drawbacks, so > here it goes... Thanks for the summary. ... > 2. Restrict

[dm-devel] [PATCH] multipath-tools: clean up libdmmp/Makefile

2017-03-13 Thread Xose Vazquez Perez
Replace LDFLAGS with LIBDEPS, build libdmmp shared library without CFLAGS Cc: Gris Ge Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libdmmp/Makefile | 11

Re: [dm-devel] [bug report] dm crypt: add cryptographic data integrity protection (authenticated encryption)

2017-03-13 Thread Mike Snitzer
On Mon, Mar 13 2017 at 12:08pm -0400, Mike Snitzer wrote: > On Mon, Mar 13 2017 at 10:19am -0400, > Dan Carpenter wrote: > > > Hello Milan Broz, > > > > This is a semi-automatic email about new static checker warnings. > > > > The patch

Re: [dm-devel] [bug report] dm crypt: add cryptographic data integrity protection (authenticated encryption)

2017-03-13 Thread Mike Snitzer
On Mon, Mar 13 2017 at 10:19am -0400, Dan Carpenter wrote: > Hello Milan Broz, > > This is a semi-automatic email about new static checker warnings. > > The patch 858516b7881e: "dm crypt: add cryptographic data integrity > protection (authenticated encryption)" from

[dm-devel] [bug report] dm crypt: add cryptographic data integrity protection (authenticated encryption)

2017-03-13 Thread Dan Carpenter
Hello Milan Broz, This is a semi-automatic email about new static checker warnings. The patch 858516b7881e: "dm crypt: add cryptographic data integrity protection (authenticated encryption)" from Jan 4, 2017, leads to the following Smatch complaint: drivers/md/dm-crypt.c:1390

[dm-devel] LVM gives "modprobe" errors on non-modular monolithic Linux kernels

2017-03-13 Thread Ivan Zahariev
Hello, Here is an example of the problem: # lvconvert --yes --type cache --cachepolicy smq --cachepool vg0/lv_cache_s188-vp vg0/s188 modprobe: ERROR: ../libkmod/libkmod.c:557 kmod_search_moddep() could not open moddep file '/lib/modules/4.4.30-grsec/modules.dep.bin'

[dm-devel] [bug report] dm: add integrity target

2017-03-13 Thread Dan Carpenter
Hello Mikulas Patocka, The patch dfab77c854fc: "dm: add integrity target" from Jan 4, 2017, leads to the following static checker warning: drivers/md/dm-integrity.c:2653 dm_integrity_ctr() warn: always true condition '(ic->sb->log2_interleave_sectors != -1) => (0-255 != (-1))'

[dm-devel] dm-crypt IV generation (summary)

2017-03-13 Thread Ondrej Mosnacek
Hi all, I was tasked to post a summary the whole dm-crypt IV generation problem and all the suggested solutions along with their drawbacks, so here it goes... PROBLEM STATEMENT: Currently, dm-crypt uses a fixed 512-byte sector size and handles en-/decrypting of a bio by submitting a separate

Re: [dm-devel] [PATCH v2] blk: improve order of bio handling in generic_make_request()

2017-03-13 Thread Jack Wang
On 10.03.2017 15:55, Mikulas Patocka wrote: > > > On Fri, 10 Mar 2017, Mike Snitzer wrote: > >> On Fri, Mar 10 2017 at 7:34am -0500, >> Lars Ellenberg wrote: >> --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1975,7 +1975,14 @@

[dm-devel] [PATCH] dm cache: handle kmalloc failure allocating background_tracker struct

2017-03-13 Thread Colin King
From: Colin Ian King currently there is no kmalloc failure check on the allocation of the background_tracker struct variable b, and so a null return will lead to a null pointer deference error. Add null check and move the failure debug message and NULL return so that