Re: [dm-devel] [PATCH] multipath-tools: Replace multipath configuration output

On 04/18/2017 02:07 AM, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez This is missing. > --- > libmultipath/propsel.c | 6 +++--- > 1 file

[dm-devel] [PATCH] multipath-tools: add limits.h to kpartx/lopart.c

musl libc complains of lopart.c:76:12: error: ‘PATH_MAX’ undeclared (first use in this function) Cc: Martin Wilck Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez

Re: [dm-devel] [PATCH 0/6] small multipath fixes

This set is merged. Thanks. On Tue, May 9, 2017 at 6:56 PM, Benjamin Marzinski wrote: > Here are a number of small multipath fixes. These patches are based on > top of my and Martin's previous patch sets. > > Benjamin Marzinski (6): > libmultipath: print alias with

Re: [dm-devel] [PATCH] mpathpersist: fix one more crash possiblity

Merged. Thanks. On Sat, May 13, 2017 at 7:44 AM, Benjamin Marzinski wrote: > when mpathpersist goes to rollback reservations, it doesn't do a > rollback (and thus doesn't create a pthread) on paths that didn't > successfully create a reservation in the first place. It also

Re: [dm-devel] [PATCH v2 0/2] Small multipath fixes

v2 of this set is merged. Thanks. On Wed, May 17, 2017 at 5:24 PM, Martin Wilck wrote: > Two minor fixes that I found necessary recently. > > Both touch potentially bigger issues - the first one print.c, which > might need some general overhaul at some time in the future, and

Re: [dm-devel] [PATCH v2 00/12] fixes for kpartx -d

The set is merged, thanks. On Wed, May 17, 2017 at 7:06 PM, Benjamin Marzinski wrote: > On Mon, May 15, 2017 at 05:37:10PM +0200, Martin Wilck wrote: > > ACK for the set > > -Ben > > > Working on a bug report about kpartx not properly removing > > partitions for loop

Re: [dm-devel] [PATCH 6/7] kpartx: Fix a compiler warning

This patch is dropped, due to Martin's 8b9cda51f5c64bc869188ca0b2e1ac0e7eb7c667 patch switching to sys/sysmacros.h Otherwise, the rest of the set is now merged. Thanks. On Wed, May 17, 2017 at 5:43 PM, Bart Van Assche wrote: > Avoid that building against glibc >=

[dm-devel] [git pull] device mapper fixes for 4.12-rc2

Hi Linus, The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6: Linux 4.12-rc1 (2017-05-13 13:19:49 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git tags/for-4.12/dm-fixes-2 for you to fetch

Re: [dm-devel] [PATCH v3 00/10] dm: zoned block device support

On Tue, May 16 2017 at 4:03pm -0400, Mike Snitzer wrote: > I see quite a few issues with this patchset (only gotten through patches > 1 - 6). I'll work through it in more detail and share my > feedback/revisions tomorrow. Mostly just cleanups, renames, etc. But > "the

Re: [dm-devel] [PATCH v2 00/12] fixes for kpartx -d

On Mon, May 15, 2017 at 05:37:10PM +0200, Martin Wilck wrote: ACK for the set -Ben > Working on a bug report about kpartx not properly removing > partitions for loop devices, I realized a number of glitches > and improperly handled corner cases in the kpartx code for > deleting partitions. Some

[dm-devel] [PATCH 7/7] Remove a superfluous "extern" keyword

Since it is not necessary to use the "extern" keyword in front of a function definition, remove that keyword. Signed-off-by: Bart Van Assche --- libmultipath/propsel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libmultipath/propsel.c

[dm-devel] [PATCH 4/7] Remove mpath_reverse_8bytes_order()

Since this function is not used, remove it. Signed-off-by: Bart Van Assche --- libmpathpersist/mpath_pr_ioctl.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/libmpathpersist/mpath_pr_ioctl.c b/libmpathpersist/mpath_pr_ioctl.c index

[dm-devel] [PATCH 2/7] libmultipath/configure.h: Add a forward declaration

This change avoids that the "#include "configure.h"" statements that are added by the next patch trigger a compiler warning. Signed-off-by: Bart Van Assche --- libmultipath/configure.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libmultipath/configure.h

[dm-devel] [PATCH 1/7] Makefile: Remove assignments to unused variables

No multipath-tools source file or Makefile imports anything directly from the kernel source tree. Hence remove the variables that refer to the kernel tree. Since the $(VERSION) Makefile macro is not used, remove it. Note: the version number is defined as a macro in libmultipath/version.h.

Re: [dm-devel] [PATCH 2/2] multipath-tools: fix compilation with gcc < 4.9

On Wed, 2017-05-17 at 15:54 +0200, Martin Wilck wrote: > +# $(call TEST_CC_OPTION,option,fallback) > +# Test if the C compiler supports the option. > +# Evaluates to "option" if yes, and "fallback" otherwise. > +TEST_CC_OPTION = $(shell \ > + if $(CC) -o /dev/null -c "$(1)" -xc - <<<'int

Re: [dm-devel] [PATCH 4/6] libmultipath: fix suspended devs from failed reloads

On Tue, May 16, 2017 at 08:56:40PM +0200, Martin Wilck wrote: > On Tue, 2017-05-16 at 12:33 -0500, Benjamin Marzinski wrote: > > On Thu, May 11, 2017 at 10:26:52PM +0200, Martin Wilck wrote: > > > On Tue, 2017-05-09 at 11:57 -0500, Benjamin Marzinski wrote: > > > > When multipath reloads a device,

Re: [dm-devel] [PATCH 1/2] libmultipath: print.c: make sure lines are 0-terminated

On Wed, 2017-05-17 at 15:54 +0200, Martin Wilck wrote: > #define ENDLINE \ > - if (c > line) \ > - line[c - line - 1] = '\n' > + if (c > line) { \ > + if (c <= line + len - 1) { \ > +

[dm-devel] [PATCH 6/7] kpartx: Fix a compiler warning

Avoid that building against glibc >= 2.25 triggers the following compiler warning: lopart.c: In function 'is_loop_device': lopart.c:93:13: warning: In the GNU C Library, "major" is defined by . For historical compatibility, it is currently defined by as well, but we plan to remove this soon.

[dm-devel] [PATCH 5/7] Move the declaration of mpath_mx_alloc_len to a header file

This allows the compiler to verify consistency of declaration and definition. Signed-off-by: Bart Van Assche --- libmpathpersist/mpath_persist.h | 3 +++ mpathpersist/main.c | 1 - multipathd/main.c | 2 -- 3 files changed, 3 insertions(+),

[dm-devel] [PATCH 0/7] Seven small multipath-tools patches

Hello Christoph, The seven patches in this series are minor changes to a Makefile, header files and source files that do not change any functionality but make the code easier to maintain. Please consider the patches in this series for inclusion in the multipath-tools project. Thanks, Bart.

[dm-devel] [PATCH 3/7] libmpathpersist: Add two missing #include directives

Make sure that including mpathpr.h as the first header file does not fail. Since mpath_updatepr.c defines functions declared in mpathpr.h, include that header file in that .c file such that the compiler can check consistency of the .h and the .c file. Signed-off-by: Bart Van Assche

[dm-devel] [PATCH v2 0/2] Small multipath fixes

Two minor fixes that I found necessary recently. Both touch potentially bigger issues - the first one print.c, which might need some general overhaul at some time in the future, and the second one the build process of multipath tools, which is currently lacking an "autobuild" mechanism. My

[dm-devel] [PATCH v2 1/2] libmultipath: print.c: make sure lines are 0-terminated

Under certain conditions, the output of "multipath -ll" or "multipathd show topology", or the multipathd logs, may contain garbage characters. Fix that by making sure that the strings are always properly zero-terminated. While touching this code, substitute a function for the complex ENDLINE

Re: [dm-devel] [PATCH 1/2] libmultipath: print.c: make sure lines are 0-terminated

Hi Martin, On 05/17/2017 03:54 PM, Martin Wilck wrote: > Under certain conditions, the output of "multipath -ll" or > "multipathd show topology", or the multipathd logs, may > contain garbage characters. Fix that by making sure that > the strings are always properly zero-terminated. > > Note 1:

[dm-devel] [PATCH 2/2] multipath-tools: fix compilation with gcc < 4.9

gcc supports -fstack-protector-strong since v4.9 only. Add a "poor man's autoconf" test to check whether the option is supported on the given build system. Fixes: 596f51f3 "multipath-tools: Replace -fstack-protector with -fstack-protector-strong" Signed-off-by: Martin Wilck ---

[dm-devel] [PATCH 1/2] libmultipath: print.c: make sure lines are 0-terminated

Under certain conditions, the output of "multipath -ll" or "multipathd show topology", or the multipathd logs, may contain garbage characters. Fix that by making sure that the strings are always properly zero-terminated. Note 1: The way this is coded, the previously written character is

[dm-devel] [PATCH 0/2] Small multipath fixes

Two minor fixes that I found necessary recently. Both touch potentially bigger issues - the first one print.c, which might need some general overhaul at some time in the future, and the second one the build process of multipath tools, which is currently lacking an "autobuild" mechanism. My

[dm-devel] cryptsetup test suite is failing on verity

Running rawhide in KVM, kernel: 4.12.0-0.rc1.git1.1.fc27.x86_64 - latest 4.12 build in rawhide cryptsetup commit: d9a528922b5d1a15c72936ea2e5e87ce2d31bc3d - HEAD of wip-luks2 branch as of 2017-05-16 ... [ 1057.722305] buffer_io_error: 146 callbacks suppressed [ 1057.723514] Buffer I/O error