Re: [dm-devel] [PATCH] mpathpersist.8: add missing documentation for -K, -C, -l

On Tue, May 23, 2017 at 12:16:43AM +0200, Martin Wilck wrote: ACK -Ben > Furthermore, add a reference to the sg_persist man page. > --- > mpathpersist/mpathpersist.8 | 21 - > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/mpathpersist/mpathpersist.8

Re: [dm-devel] [PATCH] libmultipath: lazy device-mapper initialization

On Tue, Jun 06, 2017 at 09:33:11PM +0200, Martin Wilck wrote: > The multipath command fails early if libdevmapper and/or the > dm_multipath driver are not found. But some multipath operations > don't require device mapper, notably the path checking operations > called from udev rules during early

Re: [dm-devel] [PATCH] libmpathpersist: use extern struct udev from main program

On Sun, Mar 26, 2017 at 03:49:47PM +0200, Martin Wilck wrote: > Use the global variable "udev" - the internal one is not > initialized, causing current libudev calls to fail. > In the main program "mpathpersist", use a globally visible > variable "udev" rather than a local variable in main(). >

Re: [dm-devel] [PATCH v2 0/8] multipath-tools: no_path_retry/queue_if_no_path logic

On Tue, 2017-06-20 at 13:44 -0500, Benjamin Marzinski wrote: > Review and comments are highly welcome. > > ACK for the set I found another issue with the patch set, will send v3 shortly. Martin -- Dr. Martin Wilck , Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix

Re: [dm-devel] [PATCH v2 0/8] multipath-tools: no_path_retry/queue_if_no_path logic

Hello Ben, On Tue, 2017-06-20 at 13:44 -0500, Benjamin Marzinski wrote: > > > Review and comments are highly welcome. > > ACK for the set Thanks a lot. I'd be grateful if you could also take a look at my previous submissions which have seen no review yet: "libmpathpersist: use extern struct

[dm-devel] [PATCH] Clarify commit message in select_max_sectors_kb()

Do you like it better this way? --- libmultipath/propsel.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c index f11052f2..6d628052 100644 --- a/libmultipath/propsel.c +++ b/libmultipath/propsel.c @@ -798,8 +798,9 @@ int

Re: [dm-devel] [PATCH v2 1/8] libmultipath: load_config: skip setting unnecessary defaults

On Tue, Jun 20, 2017 at 04:36:47PM +0200, Hannes Reinecke wrote: > On 06/20/2017 01:46 PM, Martin Wilck wrote: > > We have the logic for setting defaults for paths and maps > > in propsel.c. By pre-setting conf values with defaults in > > load_config(), we generate irritating log messages like > >

Re: [dm-devel] [PATCH v2 2/8] libmultipath: add/remove_feature: use const char* for feature

On 06/20/2017 01:46 PM, Martin Wilck wrote: > Change the argument type for the feature to add or remove to > const char*, making it possible to pass const strings without > warnings. > > Signed-off-by: Martin Wilck > --- > libmultipath/structs.c | 30

Re: [dm-devel] [RFC PATCH 0/4] Allow file systems to selectively bypass dm-crypt

On Fri, Jun 16 2017 at 2:42pm -0400, Michael Halcrow wrote: > On Thu, Jun 15, 2017 at 08:17:02PM +0200, Milan Broz wrote: > > On 06/15/2017 07:24 PM, Michael Halcrow wrote: > > ... > > >> If this is accepted, we basically allow attacker to trick system to > > >> write

Re: [dm-devel] [PATCH v2 1/8] libmultipath: load_config: skip setting unnecessary defaults

On 06/20/2017 01:46 PM, Martin Wilck wrote: > We have the logic for setting defaults for paths and maps > in propsel.c. By pre-setting conf values with defaults in > load_config(), we generate irritating log messages like > 'features = "0" (setting: multipath.conf defaults/devices section)' > if

[dm-devel] [PATCH v2 7/8] multipath.conf.5: Remove ??? and other minor fixes

Remove the FIXME markers by filling in missing content, and make some other minor fixes. Signed-off-by: Martin Wilck --- multipath/multipath.conf.5 | 48 +- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git

[dm-devel] [PATCH v2 6/8] multipath.conf.5: document no_path_retry vs. queue_if_no_path

Clarify the documentation about option precedence. Signed-off-by: Martin Wilck --- multipath/multipath.conf.5 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 index f04ff194..6959ba5c 100644 ---

[dm-devel] [PATCH v2 4/8] libmultipath: merge_hwe: fix queue_if_no_path logic

The logic applied here should match the logic in select_features(). This is achieved by calling reconcile_features_with_options(). Signed-off-by: Martin Wilck --- libmultipath/config.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git

[dm-devel] [PATCH v2 2/8] libmultipath: add/remove_feature: use const char* for feature

Change the argument type for the feature to add or remove to const char*, making it possible to pass const strings without warnings. Signed-off-by: Martin Wilck --- libmultipath/structs.c | 30 -- libmultipath/structs.h | 4 ++-- 2 files changed, 18

[dm-devel] [PATCH v2 5/8] libmultipath: assemble_map: fix queue_if_no_path logic

It is wrong to remove the queue_if_no_path feature if no_path_retry is unset. Rather, in this case the feature should neither be added nor removed. Signed-off-by: Martin Wilck --- libmultipath/dmparser.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[dm-devel] [PATCH v2 0/8] multipath-tools: no_path_retry/queue_if_no_path logic

This patch set attempts to sanitize the logic used for consistently handling options that can be set both via the "features" string and explicit multipath.conf options. This is most prominently "no_path_retry" vs. "queue_if_no_path", but also "retain_attached_hw_handler" vs. the feature of the

[dm-devel] [PATCH v2 8/8] libmultipath: add deprecated warning for some features settings

The device-mapper features "queue_if_no_path" and "retain_attached_hw_handler" should be set via the configuration keywords "no_path_retry" and "retain_attached_hw_handler", respectively, not via "features". Print a warning if these "features" settings are encountered. So far these "features"