Re: [dm-devel] [PATCH v6 1/1] multipath-tools: Prioritizer based on a latency algorithm

Hi Christophe, OK, thanks a lot. Regards, Yang --- On 2017/6/21 18:22, Christophe Varoqui wrote: > This version is now merged. > Thanks. > > Incremental enhancements can go from there if needed. > > On Wed, Jun 21, 2017 at 11:40 AM, Yang Feng

Re: [dm-devel] [PATCH v3 00/11] multipath-tools: no_path_retry/queue_if_no_path/hwhandler logic

On Wed, 2017-06-21 at 17:06 +0200, Martin Wilck wrote: > > Changes wrt v2: > - Added Acked-by:/Reviewed-by: tags > - 1/11: clarify comment in select_max_sectors_kb (Hannes Reinecke) > - 3/11: call select_retain_hwhandler before select_features > - 8/11: don't suggest using

[dm-devel] [PATCH v3 08/11] libmultipath: add deprecated warning for some features settings

The device-mapper features "queue_if_no_path" and "retain_attached_hw_handler" should be set via the configuration keywords "no_path_retry" and "retain_attached_hw_handler", respectively, not via "features". Print a warning if these "features" settings are encountered. So far these "features"

[dm-devel] [PATCH v3 09/11] libmultipath: retain_attached_hw_handler obsolete with 4.3+

Kernels 4.3 and newer (commit 1bab0de0 "dm-mpath, scsi_dh: don't let dm detach device handlers") imply "retain_attached_hw_handler yes". Clarify this in the propsel code, log messages, and documentation. Signed-off-by: Martin Wilck --- libmultipath/configure.c | 3 ++-

[dm-devel] [PATCH v3 10/11] libmultipath: don't try to set hwhandler if it is retained

Setting a device handler only works if retain_attached_hw_handler is 'no', or if the kernel didn't auto-assign a handler. If this is not the case, don't even attempt to set a different handler. This requires reading the sysfs "dh_state" path attribute. For internal consistency, this attribute

[dm-devel] [PATCH v3 03/11] libmultipath: clarify option conflicts for "features"

The "features" option in multipath.conf can possibly conflict with "no_path_retry" and "retain_attached_hw_handler". Currently, "no_path_retry" takes precedence, unless it is set to "fail", in which case it's overridden by "queue_if_no_path". This is odd, either "features" or "no_path_retry"

[dm-devel] [PATCH v3 05/11] libmultipath: assemble_map: fix queue_if_no_path logic

It is wrong to remove the queue_if_no_path feature if no_path_retry is unset. Rather, in this case the feature should neither be added nor removed. Signed-off-by: Martin Wilck Acked-by: Benjamin Marzinski --- libmultipath/dmparser.c | 5 ++--- 1 file

[dm-devel] [PATCH v3 00/11] multipath-tools: no_path_retry/queue_if_no_path/hwhandler logic

This patch set attempts to sanitize the logic used for consistently handling options that can be set both via the "features" string and explicit multipath.conf options. This is most prominently "no_path_retry" vs. "queue_if_no_path", but also "retain_attached_hw_handler" vs. the feature of the

[dm-devel] [PATCH v3 02/11] libmultipath: add/remove_feature: use const char* for feature

Change the argument type for the feature to add or remove to const char*, making it possible to pass const strings without warnings. Signed-off-by: Martin Wilck Reviewed-by: Hannes Reinecke --- libmultipath/structs.c | 30 --

[dm-devel] [PATCH v3 04/11] libmultipath: merge_hwe: fix queue_if_no_path logic

The logic applied here should match the logic in select_features(). This is achieved by calling reconcile_features_with_options(). Signed-off-by: Martin Wilck Acked-by: Benjamin Marzinski --- libmultipath/config.c | 20 +++- 1 file changed,

[dm-devel] [PATCH v3 07/11] multipath.conf.5: Remove ??? and other minor fixes

Remove the FIXME markers by filling in missing content, and make some other minor fixes. Signed-off-by: Martin Wilck Acked-by: Benjamin Marzinski --- multipath/multipath.conf.5 | 48 +- 1 file changed, 26

[dm-devel] [PATCH v3 01/11] libmultipath: load_config: skip setting unnecessary defaults

We have the logic for setting defaults for paths and maps in propsel.c. By pre-setting conf values with defaults in load_config(), we generate irritating log messages like 'features = "0" (setting: multipath.conf defaults/devices section)' if multipath.conf doesn't contain a features setting at

[dm-devel] [PATCH] multipath-tools: sync third-party headers with 3.13 upstream

Cc: Bart Van Assche Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- third-party/valgrind/drd.h | 2 +- third-party/valgrind/valgrind.h |

Re: [dm-devel] [PATCH] multipath-tools: Replace multipath configuration output

Merged, Thanks. On Thu, May 18, 2017 at 2:06 AM, Xose Vazquez Perez wrote: > On 04/18/2017 02:07 AM, Xose Vazquez Perez wrote: > > > Cc: Christophe Varoqui > > Cc: device-mapper development > > Signed-off-by: Xose

Re: [dm-devel] [PATCH] multipath-tools: enable libdmmp installation in alternative directory

Merged, Thanks. On Thu, May 18, 2017 at 7:05 PM, Benjamin Marzinski wrote: > On Mon, May 15, 2017 at 10:33:25PM +0200, Martin Wilck wrote: > > Fine by me. > > -Ben > > > Introduce a new Makefile variable, usr_prefix, to be used for > > libdmmp and the associated pkgconfig

Re: [dm-devel] [PATCH] multipath-tools: delete vendor name HUASY for Huawei devices

And now merged. Thanks. On Sat, May 20, 2017 at 12:31 PM, Christophe Varoqui < christophe.varo...@opensvc.com> wrote: > Thanks for the clarification. > > On Sat, May 20, 2017 at 11:17 AM, Zouming (IT) > wrote: > >> Hi christophe: >> >> We absolutely sure for product

Re: [dm-devel] [PATCH] multipath-tools: replace hidden tabs by spaces in .vendor

Merged, Thanks. On Sat, May 20, 2017 at 3:29 PM, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez > --- >

Re: [dm-devel] [PATCH] multipath-tools: fix a format warning in multipathd.8

Merged, Thanks. On Fri, May 26, 2017 at 6:19 PM, Xose Vazquez Perez wrote: > warning: macro `list' not defined > > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez

Re: [dm-devel] [PATCH] mpathpersist.8: add missing documentation for -K, -C, -l

Merged, Thanks. On Wed, Jun 21, 2017 at 12:43 AM, Benjamin Marzinski wrote: > On Tue, May 23, 2017 at 12:16:43AM +0200, Martin Wilck wrote: > > ACK > > -Ben > > > Furthermore, add a reference to the sg_persist man page. > > --- > > mpathpersist/mpathpersist.8 | 21

Re: [dm-devel] [PATCH] libmpathpersist: use extern struct udev from main program

Merged. Thanks. On Wed, Jun 21, 2017 at 12:03 AM, Benjamin Marzinski wrote: > On Sun, Mar 26, 2017 at 03:49:47PM +0200, Martin Wilck wrote: > > Use the global variable "udev" - the internal one is not > > initialized, causing current libudev calls to fail. > > In the main

Re: [dm-devel] [PATCH v6 1/1] multipath-tools: Prioritizer based on a latency algorithm

This version is now merged. Thanks. Incremental enhancements can go from there if needed. On Wed, Jun 21, 2017 at 11:40 AM, Yang Feng wrote: > libmultipath/prioritizers: Prioritizer for device mapper multipath, > where the corresponding priority values of specific paths

[dm-devel] [PATCH v6 1/1] multipath-tools: Prioritizer based on a latency algorithm

libmultipath/prioritizers: Prioritizer for device mapper multipath, where the corresponding priority values of specific paths are provided by a latency algorithm on the logarithmic scale. And the latency algorithm is dependent on the following arguments(io_num and base_num). The principle of the

[dm-devel] [PATCH v6 0/1] multipath-tools: Prioritizer based on a latency algorithm

This patch value is in the following: 1. In the Storage-Backup environment of HyperCluster, includes one storage array near to the host and one remote storage array, and the two storage arrays have the same hardware. The same LUN is writed or readed by the two storage arrays. However, usually,