Re: [dm-devel] [PATCH] bio-integrity: revert "stop abusing bi_end_io"

2017-08-05 Thread Martin K. Petersen
Mikulas, > The sector number in the integrity tag must match the physical sector > number. So, it must be verified at the bottom. The ref tag seed matches the submitter block number (typically block layer sector for the top device) and is remapped to and from the LBA by the SCSI disk driver or

Re: [dm-devel] [PATCH] bio-integrity: revert "stop abusing bi_end_io"

2017-08-05 Thread Martin K. Petersen
Christoph, > We can simply add another bio flag to get back to the previous > behavior. That being said thing to do in the end is to verify it > at the top of the stack, and not the bottom eventuall. I can cook > up a patch for that. Yeah, the original code was careful about only adding the

Re: [dm-devel] [PATCH] bio-integrity: revert "stop abusing bi_end_io"

2017-08-05 Thread Mikulas Patocka
On Sat, 5 Aug 2017, Christoph Hellwig wrote: > > On Thu, Aug 03, 2017 at 10:10:55AM -0400, Mikulas Patocka wrote: > > That dm-crypt commit that uses bio integrity payload came 3 months before > > 7c20f11680a441df09de7235206f70115fbf6290 and it was already present in > > 4.12. > > And on

Re: [dm-devel] [PATCH] bio-integrity: revert "stop abusing bi_end_io"

2017-08-05 Thread Christoph Hellwig
On Thu, Aug 03, 2017 at 10:10:55AM -0400, Mikulas Patocka wrote: > That dm-crypt commit that uses bio integrity payload came 3 months before > 7c20f11680a441df09de7235206f70115fbf6290 and it was already present in > 4.12. And on it's own that isn't an argument if your usage is indeed wrong,

Re: [dm-devel] [PATCH] libmultipath: update 3PARdata builtin config

2017-08-05 Thread Christophe Varoqui
And done. On Sat, Aug 5, 2017 at 1:23 PM, Xose Vazquez Perez wrote: > Christophe Varoqui wrote: > > > (And version bumped to 0.7.2) > > untagged: https://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=tags > -- dm-devel mailing list dm-devel@redhat.com

Re: [dm-devel] [PATCH] libmultipath: update 3PARdata builtin config

2017-08-05 Thread Xose Vazquez Perez
Christophe Varoqui wrote: > (And version bumped to 0.7.2) untagged: https://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=tags -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] multipath-tools: beautify path_latency.c code

2017-08-05 Thread Bart Van Assche
Hello Christophe, Thanks for asking. I have one pending patch for which I have not yet had the time to post it on the dm-devel mailing list but it does not affect the libmultipath/prioritizers/path_latency.c source file. So please proceed with merging Xose's patch. Bart. On Fri, 2017-08-04

Re: [dm-devel] [PATCH] libmultipath: update 3PARdata builtin config

2017-08-05 Thread Christophe Varoqui
Merged, Thanks. (And version bumped to 0.7.2) On Mon, Jun 26, 2017 at 9:03 PM, Benjamin Marzinski wrote: > This updated config comes from hp. > > Signed-off-by: Benjamin Marzinski > --- > libmultipath/hwtable.c | 2 ++ > 1 file changed, 2

Re: [dm-devel] [PATCH] multipath-tools: beautify path_latency.c code

2017-08-05 Thread Christophe Varoqui
Ok, done. On Fri, Aug 4, 2017 at 7:24 PM, Bart Van Assche wrote: > Hello Christophe, > > Thanks for asking. I have one pending patch for which I have not yet had > the time to post it on the dm-devel mailing list but it does not affect the >