[dm-devel] [PATCH 3/3] multipathd/cli.h: Add a header file guard

This patch avoids that compilation breaks if the multipathd/cli.h header file is included multiple times from the same compilation unit. Signed-off-by: Bart Van Assche --- multipathd/cli.h | 5 + 1 file changed, 5 insertions(+) diff --git a/multipathd/cli.h

[dm-devel] [PATCH 2/3] Allow the compiler to verify the consistency of the uxsock_timeout definition and declaration

Global variables should be defined after the header file with their declaration has been included. Hence move the declaration of usock_timeout further down. Signed-off-by: Bart Van Assche --- multipathd/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[dm-devel] [PATCH 1/3] Makefile.inc: Allow additional CFLAGS to be specified on the command line

Compiling the multipath-tools source code with e.g. sparse requires to specify additional compiler flags on the command line. Modify the Makefile such that this becomes possible. Signed-off-by: Bart Van Assche --- Makefile.inc | 3 ++- 1 file changed, 2 insertions(+), 1

[dm-devel] [PATCH 0/3] Three multipath-tools source code cleanup patches

Hello Christophe, The three patches in this series make it easier to compile the multipath-tools source code with sparse and address two issues discovered by sparse. Please consider these patches for inclusion in the upstream multipath-tools repository. Thanks, Bart. Bart Van Assche (3):

[dm-devel] [PATCH] dm-mpath: Fix a race condition

Hold multipath.lock around all code that iterates over the priority_groups list. This patch fixes the following crash: general protection fault: [#1] PREEMPT SMP RIP: 0010:multipath_busy+0x77/0xd0 [dm_multipath] Call Trace: dm_mq_queue_rq+0x44/0x110 [dm_mod]

Re: [dm-devel] [PATCH v2 2/2] dm unstripe: Add documentation for unstripe target

On Mon, Dec 11, 2017 at 09:00:19AM -0700, Scott Bauer wrote: > +Example scripts: > + > + > +dmsetup create nvmset1 --table '0 1 dm-unstripe /dev/nvme0n1 1 2 0' > +dmsetup create nvmset0 --table '0 1 dm-unstripe /dev/nvme0n1 0 2 0' > + > +There will now be two mappers: >

Re: [dm-devel] [PATCH v2 1/2] dm-unstripe: unstripe of IO across RAID 0

On Mon, Dec 11, 2017 at 09:00:18AM -0700, Scott Bauer wrote: > + > + dm_set_target_max_io_len(ti, target->max_hw_sectors); The return for this function has "__must_check", so it's currently throwing an a compiler warning. Otherwise, this looks like it's doing what you want, and tests

Re: [dm-devel] dm: fix uninitialized variable reference

On Mon, Dec 11, 2017 at 2:50 PM, Mike Snitzer wrote: > On Mon, Dec 11 2017 at 6:33am -0500, > Arnd Bergmann wrote: >> > > Already resolved this thanks to Stephen Rothwell's earlier > (substantially more discrete) mail. > > I always enjoy a good public shaming

Re: [dm-devel] dm: fix uninitialized variable reference

On Mon, Dec 11 2017 at 6:33am -0500, Arnd Bergmann wrote: > The last bugfix apparently introduced another problem, as shown > by this gcc warning: > > drivers/md/dm.c: In function '__send_changing_extent_only': > drivers/md/dm.c:1365:28: error: 'ti' is used uninitialized in this

Re: [dm-devel] [Consult] multipath-tools: will the community accept a new vendor specific path group prioritizer in libmultipath/prioritizers

On 12/11/2017 01:50 PM, Guan Junxiong wrote: > Hi Christophe, Hannes, Martin, Xose and Benjamin, > > It is beneficial for our customers if we integrate a new path group > prioritizer into the multipath-tools. > But this prioritizer is vendor-specific and it only works for Huawei storage >

[dm-devel] [Consult] multipath-tools: will the community accept a new vendor specific path group prioritizer in libmultipath/prioritizers

Hi Christophe, Hannes, Martin, Xose and Benjamin, It is beneficial for our customers if we integrate a new path group prioritizer into the multipath-tools. But this prioritizer is vendor-specific and it only works for Huawei storage system. Will the community accept such new vendor specific

[dm-devel] [PATCH] dm: fix uninitialized variable reference

The last bugfix apparently introduced another problem, as shown by this gcc warning: drivers/md/dm.c: In function '__send_changing_extent_only': drivers/md/dm.c:1365:28: error: 'ti' is used uninitialized in this function [-Werror=uninitialized] This restores the intialization of the 'ti'