Re: [dm-devel] Revert "dm mpath: remove unnecessary NVMe branching in favor of scsi_dh checks"

On Mon, Mar 12 2018 at 5:32pm -0400, Bart Van Assche wrote: > On Mon, 2018-03-12 at 17:23 -0400, Mike Snitzer wrote: > > Could you provide more details on your setup? > > > > Obviously you're using "queue_mode mq", what are your underlying paths? > > > > Given the

Re: [dm-devel] Revert "dm mpath: remove unnecessary NVMe branching in favor of scsi_dh checks"

On Mon, 2018-03-12 at 17:23 -0400, Mike Snitzer wrote: > Could you provide more details on your setup? > > Obviously you're using "queue_mode mq", what are your underlying paths? > > Given the trace it would seem you're hitting multipath_clone_and_map()'s > blk_queue_dying(q) error path that

Re: [dm-devel] Revert "dm mpath: remove unnecessary NVMe branching in favor of scsi_dh checks"

On Mon, Mar 12 2018 at 4:28pm -0400, Bart Van Assche wrote: > This patch fixes the following kernel crash: > > INFO: trying to register non-static key. > the code is fine but needs lockdep annotation. > turning off the locking correctness validator. > CPU: 1 PID: 155

[dm-devel] [PATCH] multipath-tools: fix errors in auto generated man pages

dmmp_path_blk_name_get.3: :14: warning: macro `nvme0n1'.' not defined dmmp_mpath_kdev_name_get.3: :15: warning: macro `dm-1'.' not defined Cc: Gris Ge Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose

Re: [dm-devel] dm-bufio: move dm-bufio.h to include/linux/

On Mon, Mar 12 2018 at 3:48am -0400, Christoph Hellwig wrote: > On Thu, Mar 08, 2018 at 03:36:21PM -0500, Mike Snitzer wrote: > > While I appreciate your interest in what constitutes a reasonable change > > for DM, why are you so emphatic about disallowing out-of-tree DM

Re: [dm-devel] ERROR: "scsi_device_from_queue" [drivers/md/dm-multipath.ko] undefined!

On Sat, Mar 10 2018 at 2:29pm -0500, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 3266b5bd97eaa72793df0b6e5a106c69ccc166c4 > commit: 8d47e65948ddea4398892946d9e50778a316b397 dm mpath: remove

Re: [dm-devel] device mapper mapping across reboot

Dne 12.3.2018 v 12:09 Jitendra napsal(a): On Mon, Mar 12, 2018 at 10:49:02AM +0100, Zdenek Kabelac wrote: Dne 10.3.2018 v 11:47 Jitendra napsal(a): Once kernel is booted and 'ramdisk' is processed - you have plenty of time and lots of binaries there (typically with lvm2 built-in)  - so

Re: [dm-devel] device mapper mapping across reboot

On Mon, Mar 12, 2018 at 10:49:02AM +0100, Zdenek Kabelac wrote: Dne 10.3.2018 v 11:47 Jitendra napsal(a): lvm2 is exactly solving this problem as it maintains consistent 'metadata' on every device - so upon reboot devices are discovered and from their metadata dm tables are actived/restored.

Re: [dm-devel] [PATCH] dm-writecache

On Mon, 12 Mar 2018, Christoph Hellwig wrote: > On Thu, Mar 08, 2018 at 09:08:32AM -0800, Dan Williams wrote: > > I had the same feedback, and Mikulas sent this useful enhancement to > > the memcpy_flushcache API: > > > > https://patchwork.kernel.org/patch/10217655/ > > > > ...it's in my

Re: [dm-devel] [PATCH] dm-writecache

On Mon, 12 Mar 2018, Christoph Hellwig wrote: > On Thu, Mar 08, 2018 at 10:26:17PM -0500, Mikulas Patocka wrote: > > > no business having this around. > > > > It's the default setting of the flag wc->writeback_fua (it can be changed > > with target parameters). The flag selects whether the

Re: [dm-devel] device mapper mapping across reboot

Dne 10.3.2018 v 11:47 Jitendra napsal(a): lvm2 is exactly solving this problem as it maintains consistent 'metadata' on every device - so upon reboot devices are discovered and from their metadata dm tables are actived/restored. Got it. So  are you looking for recreation of all the lvm2

[dm-devel] Questions around multipath - failover and no_path_retry

Hi Folks, Let us assume, there are 2 paths within the path group which dm-multipath is sending the I/Os in round-robin fashion. Each of these paths are identified as unique block device(s) such as /dev/sdb and /dev/sdc. 1. Let us say some I/Os are sent over to the path /dev/sdb and either

[dm-devel] [PATCH] dm-mpath: use DM_MAPIO_SUBMITTED instead of 0 in process_queued_bios

Use the macro DM_MAPIO_SUBMITTED instead of magic number 0 in dm-mpath.c/process_queued_bios. Signed-off-by: Wang Sheng-Hui --- drivers/md/dm-mpath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index

Re: [dm-devel] device mapper mapping across reboot

lvm2 is exactly solving this problem as it maintains consistent 'metadata' on every device - so upon reboot devices are discovered and from their metadata dm tables are actived/restored. Got it. So are you looking for recreation of all the lvm2 infrastructure for this relatively quite

Re: [dm-devel] [PATCH] Add an option to dm-verity to validate hashes at most once

Hi Milan, Yes, that is correct that the attacks it protects against is when the underlying storage is offline. We have discussed if we should reset the bitmap at certain events but decided against it. Cheers, Patrik On Thu, Mar 8, 2018 at 4:35 AM Milan Broz wrote: >

Re: [dm-devel] [PATCH] Add an option to dm-verity to validate hashes at most once

Hi Milan, Yes, that is correct that the attacks it protects against is when the underlying storage is offline. We have discussed if we should reset the bitmap at certain events but decided against it. Cheers, Patrik On Thu, Mar 08, 2018 at 01:35:05PM +0100, Milan Broz wrote: > On 03/07/2018

Re: [dm-devel] [PATCH] dm-writecache

On Thu, Mar 08, 2018 at 09:08:32AM -0800, Dan Williams wrote: > I had the same feedback, and Mikulas sent this useful enhancement to > the memcpy_flushcache API: > > https://patchwork.kernel.org/patch/10217655/ > > ...it's in my queue to either push through -tip or add it to the next >

Re: [dm-devel] [PATCH] dm-writecache

On Thu, Mar 08, 2018 at 10:26:17PM -0500, Mikulas Patocka wrote: > > no business having this around. > > It's the default setting of the flag wc->writeback_fua (it can be changed > with target parameters). The flag selects whether the target uses FUA > requests when doing writeback or whether

Re: [dm-devel] dm-bufio: move dm-bufio.h to include/linux/

On Thu, Mar 08, 2018 at 03:36:21PM -0500, Mike Snitzer wrote: > While I appreciate your interest in what constitutes a reasonable change > for DM, why are you so emphatic about disallowing out-of-tree DM modules > from using dm-bufio? Because I'd rather get them into the tree than providing

[dm-devel] [RFC PATCH] multipath: flush workqueue only in necessary

When flush works belong a specific multipath, we flush workqueue only in necessary. (That's my first time to send a patch, please remind me if anything wrong) diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index f7810cc..0f14732 100644 --- a/drivers/md/dm-mpath.c +++