Re: [dm-devel] [PATCH v3 9/9] crypto: shash: Remove VLA usage in unaligned hashing

2018-07-01 Thread Eric Biggers
On Sun, Jul 01, 2018 at 10:04:59AM -0700, Kees Cook wrote: > On Sat, Jun 30, 2018 at 12:03 AM, Eric Biggers wrote: > > On Thu, Jun 28, 2018 at 05:28:43PM -0700, Kees Cook wrote: > >> @@ -88,11 +81,13 @@ static int shash_update_unaligned(struct shash_desc > >> *desc, const u8 *data, > >>

Re: [dm-devel] [PATCH v3 9/9] crypto: shash: Remove VLA usage in unaligned hashing

2018-07-01 Thread Kees Cook
On Sat, Jun 30, 2018 at 12:03 AM, Eric Biggers wrote: > On Thu, Jun 28, 2018 at 05:28:43PM -0700, Kees Cook wrote: >> @@ -88,11 +81,13 @@ static int shash_update_unaligned(struct shash_desc >> *desc, const u8 *data, >> unsigned long alignmask = crypto_shash_alignmask(tfm); >>

[dm-devel] [PATCH] multipath-tools: reformat maintainer info

2018-07-01 Thread Xose Vazquez Perez
Cc: Christophe Varoqui Cc: DM-DEV ML Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 39 +-- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index f012dea..478bf16 100644 ---

Re: [dm-devel] [PATCH v3 4/9] dm integrity: Remove VLA usage

2018-07-01 Thread Herbert Xu
On Fri, Jun 29, 2018 at 02:56:37PM -0700, Kees Cook wrote: > > This conversion was following the existing check (PAGE_SIZE / 8), and > not via an analysis of alg.digestsize users. Let me double-check. For > predefined stuff, it looks like the largest is: > > SKEIN1024_DIGEST_BIT_SIZE/8 == 128

Re: [dm-devel] [PATCH v2 11/11] crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK

2018-07-01 Thread Herbert Xu
On Wed, Jun 27, 2018 at 05:10:05PM -0700, Kees Cook wrote: > > In both cases here, what is "cipher"? i.e. what ciphers could lrw be > wrapping, and what ciphers could cts be wrapping, so that I can > examine the blocksizes, etc? A cipher is a simple cipher like aes that operates on a single