Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Alasdair G Kergon
On Fri, Aug 03, 2018 at 01:42:52PM -0700, Linus Torvalds wrote: > So even in case 2, we do try to avoid versioning. More often we add a > new flag, and say "hey, if you want the new behavior, use the new flag > to say so". Not versioning, but explicit "I want the new behavior" There are spare fla

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Alasdair G Kergon
On Fri, Aug 03, 2018 at 08:56:36PM +0100, Alasdair G Kergon wrote: > Anything passing in version 4.37.0 or earlier (which is the version in If taking this approach, it might be better to use the current version i.e. where we add the kernel-side fix. IOW anything compiling against a uapi header t

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Alasdair G Kergon
On Fri, Aug 03, 2018 at 11:20:34AM -0400, Theodore Y. Ts'o wrote: > It *used* to be the case that users running RHEL 2 or RHEL 3 could try > updating to the latest upstream kernel, and everything would break and > fall apart. This was universally considered to be a failure, and a > Bad Thing. So

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Mike Snitzer
On Fri, Aug 03 2018 at 3:11pm -0400, Linus Torvalds wrote: > On Fri, Aug 3, 2018 at 12:06 PM Mike Snitzer wrote: > > > > But you're making Zdenek's response into mine and threathening to no > > longer pull from me. > > No. I'm *very* unhappy about how you seem to think that Zdenek's > response

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Mike Snitzer
On Fri, Aug 03 2018 at 3:09pm -0400, Linus Torvalds wrote: > On Fri, Aug 3, 2018 at 11:54 AM Mike Snitzer wrote: > > > > > > As I explained to Ted in my previous reply to this thread: using an lvm2 > > that is of the same vintage of the kernel is generally going to provide > > a more robust use

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Zdenek Kabelac
Dne 3.8.2018 v 18:37 Linus Torvalds napsal(a): [ Dammit. I haven't had to shout and curse at people for a while, but this is ABSOLUTELY THE MOST IMPORTANT THING IN THE UNIVERSE WHEN IT COMES TO SOFTWARE DEVELOPMENT ] On Fri, Aug 3, 2018 at 6:31 AM Zdenek Kabelac wrote: IMHO (as the author of

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Linus Torvalds
On Fri, Aug 3, 2018 at 12:06 PM Mike Snitzer wrote: > > But you're making Zdenek's response into mine and threathening to no > longer pull from me. No. I'm *very* unhappy about how you seem to think that Zdenek's response was even half-way ok, and you jumped in when Ted said it wasn't.

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Linus Torvalds
On Fri, Aug 3, 2018 at 11:54 AM Mike Snitzer wrote: > > > As I explained to Ted in my previous reply to this thread: using an lvm2 > that is of the same vintage of the kernel is generally going to provide > a more robust user experience You said that yes. And it is completely irrelevant. The fa

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Mike Snitzer
On Fri, Aug 03 2018 at 2:57pm -0400, Linus Torvalds wrote: > On Fri, Aug 3, 2018 at 11:39 AM Mike Snitzer wrote: > > > > Please stop with the overreaction and making this something it isn't. > > It's not an overreaction when people get their scripts broken, and > some developers then argue "th

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Mike Snitzer
On Fri, Aug 03 2018 at 12:37pm -0400, Linus Torvalds wrote: > [ Dammit. I haven't had to shout and curse at people for a while, but > this is ABSOLUTELY THE MOST IMPORTANT THING IN THE UNIVERSE WHEN IT > COMES TO SOFTWARE DEVELOPMENT ] > > On Fri, Aug 3, 2018 at 6:31 AM Zdenek Kabelac wrote: >

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Mike Snitzer
On Fri, Aug 03 2018 at 11:20am -0400, Theodore Y. Ts'o wrote: > On Fri, Aug 03, 2018 at 09:31:03AM -0400, Mike Snitzer wrote: > > > > Debian is notorious for having a stale and/or custom lvm2. > > Generally speaking, it is recommended that lvm2 not be older than the > > kernel (but the opposite

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Linus Torvalds
[ Dammit. I haven't had to shout and curse at people for a while, but this is ABSOLUTELY THE MOST IMPORTANT THING IN THE UNIVERSE WHEN IT COMES TO SOFTWARE DEVELOPMENT ] On Fri, Aug 3, 2018 at 6:31 AM Zdenek Kabelac wrote: > > IMHO (as the author of fixing lvm2 patch) user should not be upgrading

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Theodore Y. Ts'o
On Fri, Aug 03, 2018 at 09:31:03AM -0400, Mike Snitzer wrote: > > Debian is notorious for having a stale and/or custom lvm2. > Generally speaking, it is recommended that lvm2 not be older than the > kernel (but the opposite is fine). On Fri, Aug 03, 2018 at 03:31:18PM +0200, Zdenek Kabelac wrote:

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Zdenek Kabelac
Dne 2.8.2018 v 23:52 Linus Torvalds napsal(a): On Thu, Aug 2, 2018 at 2:39 PM WGH wrote: I've just found one public report of this bug, though: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900442 Yeah, it does sound like we should fix this issue. Hi IMHO (as the author of fixing lv

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Mike Snitzer
On Thu, Aug 02 2018 at 5:52pm -0400, Linus Torvalds wrote: > On Thu, Aug 2, 2018 at 2:39 PM WGH wrote: > > > > I've just found one public report of this bug, though: > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900442 > > Yeah, it does sound like we should fix this issue. Debian is n

[dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread WGH
On 08/02/2018 04:31 PM, Ilya Dryomov wrote: > On Thu, Aug 2, 2018 at 2:26 PM WGH wrote: >> (I originally reported this problem here: >> https://bugzilla.kernel.org/show_bug.cgi?id=200439) >> >> When I updated from 4.14 to 4.16, my LVM snapshotting script broke for >> no apparent reason. >> >> My s

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Ilya Dryomov
On Thu, Aug 2, 2018 at 6:41 PM Linus Torvalds wrote: > > On Thu, Aug 2, 2018 at 8:16 AM WGH wrote: > > > > On 08/02/2018 04:31 PM, Ilya Dryomov wrote: > > > > > > From a quick look, --permission r sets DM_READONLY_FLAG, which makes dm > > > mark the disk read-only with set_disk_ro(dm_disk(md), 1)

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread WGH
On 08/03/2018 12:32 AM, WGH wrote: > On 08/02/2018 09:32 PM, Linus Torvalds wrote: >> WGH (sorry, no idea what your real name is) - what's the source of the >> script that broke? Was it some system script you got from outside and >> likely to affect others too? >> >> Or was it just some local thing

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread WGH
On 08/02/2018 09:32 PM, Linus Torvalds wrote: > WGH (sorry, no idea what your real name is) - what's the source of the > script that broke? Was it some system script you got from outside and > likely to affect others too? > > Or was it just some local thing you wrote yourself and was > unintentiona

Re: [dm-devel] [RFC] [PATCH 0/1] Introduce emergency raid0 stop for mounted arrays

2018-08-03 Thread Guilherme G. Piccoli
On 01/08/2018 22:51, NeilBrown wrote: >> [...] > If you have hard drive and some sectors or track stop working, I think > you would still expect IO to the other sectors or tracks to keep > working. > > For this reason, the behaviour of md/raid0 is to continue to serve IO to > working devices, and

Re: [dm-devel] LVM snapshot broke between 4.14 and 4.16

2018-08-03 Thread Ilya Dryomov
On Thu, Aug 2, 2018 at 2:26 PM WGH wrote: > > (I originally reported this problem here: > https://bugzilla.kernel.org/show_bug.cgi?id=200439) > > When I updated from 4.14 to 4.16, my LVM snapshotting script broke for > no apparent reason. > > My script has the following line, and it fails like thi