Re: [PATCH v2] lib/memweight.c: open codes bitmap_weight()

2019-08-26 Thread Matthew Wilcox
On Sun, Aug 25, 2019 at 02:39:47PM +0300, Denis Efremov wrote: > On 25.08.2019 09:11, Matthew Wilcox wrote: > > On Sat, Aug 24, 2019 at 01:01:02PM +0300, Denis Efremov wrote: > >> This patch open codes the bitmap_weight() call. The direct > >> invocation of hweight_long() allows to remove the

Re: [dm-devel] [PATCH] accessing invalid memory in "dm zoned: properly handle backing device failure"

2019-08-26 Thread Mikulas Patocka
On Mon, 26 Aug 2019, Damien Le Moal wrote: > On 2019/08/26 15:41, Mikulas Patocka wrote: > > The patch 75d66ffb48efb30f2dd42f041ba8b39c5b2bd115 ("dm zoned: properly > > handle backing device failure") triggers a coverity warning: > > > > *** CID 1452808: Memory - illegal accesses

Re: [dm-devel] [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone

2019-08-26 Thread Song Liu
> On Aug 23, 2019, at 10:48 AM, Guilherme G. Piccoli > wrote: > > On 22/08/2019 18:55, Song Liu wrote: >> [...] >>> + if (unlikely(!(tmp_dev->rdev->bdev->bd_disk->flags & GENHD_FL_UP))) { >>> + if (!test_bit(MD_BROKEN, >flags)) >>> + pr_warn("md: %s: linear

Re: [dm-devel] [PATCH v3 1/2] md raid0/linear: Mark array as 'broken' and fail BIOs if a member is gone

2019-08-26 Thread Guilherme G. Piccoli
On 22/08/2019 18:55, Song Liu wrote: > [...] >> +if (unlikely(!(tmp_dev->rdev->bdev->bd_disk->flags & GENHD_FL_UP))) { >> +if (!test_bit(MD_BROKEN, >flags)) >> +pr_warn("md: %s: linear array has a missing/failed >> member\n", >> +

Re: [dm-devel] [PATCH] accessing invalid memory in "dm zoned: properly handle backing device failure"

2019-08-26 Thread Damien Le Moal
On 2019/08/26 15:41, Mikulas Patocka wrote: > The patch 75d66ffb48efb30f2dd42f041ba8b39c5b2bd115 ("dm zoned: properly > handle backing device failure") triggers a coverity warning: > > *** CID 1452808: Memory - illegal accesses (USE_AFTER_FREE) > /drivers/md/dm-zoned-target.c: 137 in

[dm-devel] [PATCH] accessing invalid memory in "dm zoned: properly handle backing device failure"

2019-08-26 Thread Mikulas Patocka
The patch 75d66ffb48efb30f2dd42f041ba8b39c5b2bd115 ("dm zoned: properly handle backing device failure") triggers a coverity warning: *** CID 1452808: Memory - illegal accesses (USE_AFTER_FREE) /drivers/md/dm-zoned-target.c: 137 in dmz_submit_bio() 131 clone->bi_private = bioctx;