On Fri, 2019-09-13 at 17:04 -0500, Benjamin Marzinski wrote:
> These are a couple of disconnected multipath patches.
>
> Changes in v2:
>
> 0003: As Martin suggested, fail immediately on wrong number of prin
> actions.
>
> 0004: mp_init now is an optional symbol for checker DSOs, and is
>
If handle_args() fails while looping through the argument list, it needs
to free batch_fn, if it has been set. Also handle_args() needs to make
sure to free the file descriptor after it has been opened.
Signed-off-by: Benjamin Marzinski
---
mpathpersist/main.c | 33
The test for an empty pp->dev in updatepaths() dates back to when
disassemble_map() didn't fill in pp->dev for newly added paths, and it
was meant to catch paths that got added by disassemble_map(). With the
mpathpersist speedup code, all paths get added by disassemble_map().
However,
If a path is discovered before there is a multipath device for it to
belong to, the checker will not have its mpcontext initialized, even if
that path later belongs to a multipath device. A checker's mpcontext is
only set when the checker is selected, and is set to NULL if there is no
multipath
These are a couple of disconnected multipath patches.
Changes in v2:
0003: As Martin suggested, fail immediately on wrong number of prin
actions.
0004: mp_init now is an optional symbol for checker DSOs, and is ignored
if it's missing, again at Martin's suggestion.
Benjamin
On Fri, 13 Sep 2019, Mike Snitzer wrote:
> On Thu, Sep 12 2019 at 12:07P -0400,
> Mikulas Patocka wrote:
>
> >
> >
> > On Thu, 12 Sep 2019, Heinz Mauelshagen wrote:
> >
> > > Mikulas,
> > >
> > > please use list_move instead of list_del/list_add pairs.
> > >
> > > Heinz
> >
> > OK.
On Fri, Sep 13, 2019 at 07:56:13AM +, Martin Wilck wrote:
> On Tue, 2019-09-10 at 17:39 -0500, Benjamin Marzinski wrote:
> > If handle_args() fails while looping through the argument list, it
> > needs
> > to free batch_fn, if it has been set. Also handle_args() needs to
> > make
> > sure to
On Fri, Sep 13, 2019 at 08:28:59AM +, Martin Wilck wrote:
> On Tue, 2019-09-10 at 17:39 -0500, Benjamin Marzinski wrote:
> > If a path is discovered before there is a multipath device for it to
> > belong to, the checker will not have its mpcontext initialized, even
> > if
> > that path later
On Thu, Sep 12 2019 at 12:07P -0400,
Mikulas Patocka wrote:
>
>
> On Thu, 12 Sep 2019, Heinz Mauelshagen wrote:
>
> > Mikulas,
> >
> > please use list_move instead of list_del/list_add pairs.
> >
> > Heinz
>
> OK. Here I resend it.
>
>
>
> From: Mikulas Patocka
>
> This patch
Sorry, no question, pointer alignment of course.
Denis Efremov писал 2019-09-13 14:48:
Hi,
Sorry for reviving this conversation, but it looks to me like
this function could be reduced to a single bitmap_weight call:
static inline size_t memweight(const void *ptr, size_t bytes)
{
Hi,
Sorry for reviving this conversation, but it looks to me like
this function could be reduced to a single bitmap_weight call:
static inline size_t memweight(const void *ptr, size_t bytes)
{
BUG_ON(bytes >= UINT_MAX / BITS_PER_BYTE);
return bitmap_weight(ptr, bytes *
On Tue, 2019-09-10 at 17:39 -0500, Benjamin Marzinski wrote:
> If a path is discovered before there is a multipath device for it to
> belong to, the checker will not have its mpcontext initialized, even
> if
> that path later belongs to a multipath device. A checker's mpcontext
> is
> only set
On Tue, 2019-09-10 at 17:39 -0500, Benjamin Marzinski wrote:
> If handle_args() fails while looping through the argument list, it
> needs
> to free batch_fn, if it has been set. Also handle_args() needs to
> make
> sure to free the file descriptor after it has been opened.
>
> Signed-off-by:
On Tue, 2019-09-10 at 17:39 -0500, Benjamin Marzinski wrote:
> Got this config from Dell.
>
> Cc: heyi
> Signed-off-by: Benjamin Marzinski
> ---
> libmultipath/hwtable.c | 6 ++
> 1 file changed, 6 insertions(+)
Reviewed-by: Martin Wilck
--
dm-devel mailing list
dm-devel@redhat.com
On Tue, 2019-09-10 at 17:39 -0500, Benjamin Marzinski wrote:
> The test for an empty pp->dev in updatepaths() dates back to when
> disassemble_map() didn't fill in pp->dev for newly added paths, and
> it
> was meant to catch paths that got added by disassemble_map(). With
> the
> mpathpersist
15 matches
Mail list logo
