Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-21 Thread Jeff Moyer
Dan Williams writes: > Oh you misunderstood my comment, the "move badblocks to filesystem" > proposal is long term / down the road thing to consider. In the near > term this unaligned block zeroing facility is an improvement. I'm not sure I agree. I'm going to think about it and get back to

Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-21 Thread Dan Williams
On Fri, Feb 21, 2020 at 1:25 PM Vivek Goyal wrote: > > On Fri, Feb 21, 2020 at 01:00:29PM -0800, Dan Williams wrote: > > On Fri, Feb 21, 2020 at 12:18 PM Vivek Goyal wrote: > > > > > > On Fri, Feb 21, 2020 at 01:32:48PM -0500, Jeff Moyer wrote: > > > > Vivek Goyal writes: > > > > > > > > > On

Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-21 Thread Vivek Goyal
On Fri, Feb 21, 2020 at 01:00:29PM -0800, Dan Williams wrote: > On Fri, Feb 21, 2020 at 12:18 PM Vivek Goyal wrote: > > > > On Fri, Feb 21, 2020 at 01:32:48PM -0500, Jeff Moyer wrote: > > > Vivek Goyal writes: > > > > > > > On Thu, Feb 20, 2020 at 04:35:17PM -0500, Jeff Moyer wrote: > > > >>

Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-21 Thread Vivek Goyal
On Fri, Feb 21, 2020 at 01:32:48PM -0500, Jeff Moyer wrote: > Vivek Goyal writes: > > > On Thu, Feb 20, 2020 at 04:35:17PM -0500, Jeff Moyer wrote: > >> Vivek Goyal writes: > >> > >> > Currently pmem_clear_poison() expects offset and len to be sector > >> > aligned. > >> > Atleast that seems

Re: [dm-devel] [PATCH v3] dm ebs: new block size emulating target

2020-02-21 Thread Bryan Gurney
On Fri, Feb 21, 2020 at 9:26 AM Heinz Mauelshagen wrote: > > Hi Damien, > > thanks for your review, much appreciated. > > Please find my statements inline with yours below, working in > uncontroversial ones now... > > Heinz > > > On 2/21/20 10:44 AM, Damien Le Moal wrote: > > On 2020/02/20 7:12,

Re: [dm-devel] [PATCH v3] dm ebs: new block size emulating target

2020-02-21 Thread Heinz Mauelshagen
Hi Damien, thanks for your review, much appreciated. Please find my statements inline with yours below, working in uncontroversial ones now... Heinz On 2/21/20 10:44 AM, Damien Le Moal wrote: On 2020/02/20 7:12, hei...@redhat.com wrote: From: Heinz Mauelshagen This new target is

[dm-devel] [PATCH] dm-integrity: Prevent RMW for full tag area writes

2020-02-21 Thread Lukas Straub
If a full tag area is being written, don't read it first. This prevents a read-modify-write cycle and increases performance on HDDs considerably. To do this we now calculate the checksums for all sectors in the bio in one go in integrity_metadata and then pass the result to dm_integrity_rw_tag,

Re: [dm-devel] [PATCH v3] dm ebs: new block size emulating target

2020-02-21 Thread Damien Le Moal
On 2020/02/20 7:12, hei...@redhat.com wrote: > From: Heinz Mauelshagen > > This new target is similar to the linear target except that it emulates > a smaller logical block size on devices with larger ones. It's main > purpose is to emulate 512 byte sectors on 4K native disks (i.e. 512e). 512e