From: Martin Wilck
This allows e.g. setting LDFLAGS="-m32 -Wl,-b,elf32-i386" to compile
for a 32bit target on a 64bit system.
Note that, like CFLAGS, the variable needs to be set in the environment,
not on the "make" command line.
Signed-off-by: Martin Wilck
---
Makefile.inc | 2 +-
1 file ch
From: Martin Wilck
OBJDEPS needs to list object files that _call_ functions we want
to wrap, but it should _not_ list the object files where these
functions are defined; otherwise the linker might resolve these
symbols before they can be wrapped.
(Observed on i586 with gcc 9.3.1, ld 2.34.0, wher
From: Martin Wilck
OPTFLAGS is what distribution builds would typically override. That
should not include the warning flags we use.
Moreover, in the definition of CFLAGS, put $(CFLAGS) first to make it
easier for the user to spot her input in the build logs.
Signed-off-by: Martin Wilck
---
Ma
From: Martin Wilck
Make sure the linker finds libmpathcmd.
Signed-off-by: Martin Wilck
---
tests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile b/tests/Makefile
index 77ff3249..028c9ea7 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -10,7 +10,7
From: Martin Wilck
On architectures where sizeof(long) == sizeof(int), the code wouldn't
work as intended. Use strtoul instead. As strtoul happily parses
negative numbers as input, require the number to begin with a digit.
Signed-off-by: Martin Wilck
---
libmultipath/dict.c | 11 +++
1
From: Martin Wilck
We need to ignore -Wclobbered because gcc has trouble dealing with glibc's
implementation of pthread_cleanup_push().
For some variants of gcc, -Wno-clobbered alone isn't enough if -Werror is also
set. Compilation with -Wno-error=clobbered works, though.
Signed-off-by: Martin
From: Martin Wilck
Fix some more compiler warnings about signed/unsigned comparison.
I've observed these only on 32bit builds, therefore they went unnoticed
before.
Signed-off-by: Martin Wilck
---
libmpathpersist/mpath_pr_ioctl.c | 2 +-
libmultipath/print.c | 12 ++-
From: Martin Wilck
Initialize aio_grp to satisfy gcc.
Signed-off-by: Martin Wilck
---
tests/directio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/directio.c b/tests/directio.c
index 3cd7a520..66aaf0eb 100644
--- a/tests/directio.c
+++ b/tests/directio.c
@@ -316,7
From: Martin Wilck
Extend the late fixes from Christian.
Cc: Christian Hesse
Signed-off-by: Martin Wilck
---
Makefile | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index ba1d73ba..fec3b73b 100644
--- a/Makefile
+++ b/Makefile
@@ -28,8 +28,9 @@ al
From: Martin Wilck
Otherwise compilation for 32bit targets spits out warnings.
Signed-off-by: Martin Wilck
---
libmultipath/discovery.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index ee3290cd..ffec5
From: Martin Wilck
is_claimed_by_foreign() is an inline function and can't be wrapped.
Signed-off-by: Martin Wilck
---
tests/test-lib.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/tests/test-lib.c b/tests/test-lib.c
index 59275163..00bae58e 100644
--- a/tests/test-lib.c
+++ b/test
From: Martin Wilck
Hi Christophe, hi Ben,
This series fixes a couple of issues I recently found with the 32bit build
of multipath-tools, and after integrating our CI into the automated builds
on our build server.
Regards
Martin
Martin Wilck (11):
multipath-tools: Makefile: more dependency fi
Mike Snitzer writes:
> OK, that concall's issue had nothing to do with needing higher
> resolution time (was about IOPs realized with requested-based vs
> bio-based).
>
> Reality is, DM won't need anything higher resolution than jiffies until
> block core's interfaces require something other than
On Mon, May 11 2020 at 1:31pm -0400,
Mike Snitzer wrote:
> On Mon, May 11 2020 at 1:11pm -0400,
> Gabriel Krisman Bertazi wrote:
>
> > Mike Snitzer writes:
> >
> > > On Mon, May 11 2020 at 12:39pm -0400,
> > > Gabriel Krisman Bertazi wrote:
> > >
> > >> Hi,
> > >>
> > >> This fourth versi
On 5/10/2020 2:28 AM, Mickaël Salaün wrote:
[...snip]
Additionally, rules are evaluated top-to-bottom. As a result, any
revocation rules, or denies should be placed early in the file to ensure
that these rules are evaluated before a rule with "action=ALLOW" is hit.
IPE policy is designed t
On Mon, May 11 2020 at 1:11pm -0400,
Gabriel Krisman Bertazi wrote:
> Mike Snitzer writes:
>
> > On Mon, May 11 2020 at 12:39pm -0400,
> > Gabriel Krisman Bertazi wrote:
> >
> >> Hi,
> >>
> >> This fourth version of HST applies the suggestion from Mikulas Patocka
> >> to do the ktime_get_ns
Mike Snitzer writes:
> On Mon, May 11 2020 at 12:39pm -0400,
> Gabriel Krisman Bertazi wrote:
>
>> Hi,
>>
>> This fourth version of HST applies the suggestion from Mikulas Patocka
>> to do the ktime_get_ns inside the mpath map_bio instead of generic
>> device-mapper code. This means that struct
On Mon, May 11 2020 at 12:39pm -0400,
Gabriel Krisman Bertazi wrote:
> Hi,
>
> This fourth version of HST applies the suggestion from Mikulas Patocka
> to do the ktime_get_ns inside the mpath map_bio instead of generic
> device-mapper code. This means that struct dm_mpath_io gained another
> 64b
From: Khazhismel Kumykov
This new selector keeps an exponential moving average of the service
time for each path (losely defined as delta between start_io and
end_io), and uses this along with the number of inflight requests to
estimate future service time for a path. Since we don't have a probe
Hi,
This fourth version of HST applies the suggestion from Mikulas Patocka
to do the ktime_get_ns inside the mpath map_bio instead of generic
device-mapper code. This means that struct dm_mpath_io gained another
64bit field. For the request-based case, we continue to use the block
layer start tim
HST is going to need this information to perform path prediction. For
request-based mpath, we use the struct request io_start_time, while for
bio based, use the DM layer start_time.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/dm-mpath.c | 12 +---
drivers/md/dm-path-sel
On 2020/05/11 20:46, Damien Le Moal wrote:
> On 2020/05/11 20:25, Hannes Reinecke wrote:
>> On 5/11/20 12:55 PM, Damien Le Moal wrote:
>>> On 2020/05/11 11:46, Damien Le Moal wrote:
Mike,
I am still seeing the warning:
[ 1827.839756] device-mapper: table: 253:1: adding targ
On 2020/05/11 20:25, Hannes Reinecke wrote:
> On 5/11/20 12:55 PM, Damien Le Moal wrote:
>> On 2020/05/11 11:46, Damien Le Moal wrote:
>>> Mike,
>>>
>>> I am still seeing the warning:
>>>
>>> [ 1827.839756] device-mapper: table: 253:1: adding target device sdj caused
>>> an
>>> alignment inconsist
On 5/11/20 12:55 PM, Damien Le Moal wrote:
On 2020/05/11 11:46, Damien Le Moal wrote:
Mike,
I am still seeing the warning:
[ 1827.839756] device-mapper: table: 253:1: adding target device sdj caused an
alignment inconsistency: physical_block_size=4096, logical_block_size=4096,
alignment_offset
On 2020/05/11 20:19, Hannes Reinecke wrote:
> On 5/11/20 12:55 PM, Damien Le Moal wrote:
>> On 2020/05/11 11:46, Damien Le Moal wrote:
>>> Mike,
>>>
>>> I am still seeing the warning:
>>>
>>> [ 1827.839756] device-mapper: table: 253:1: adding target device sdj caused
>>> an
>>> alignment inconsist
On 5/11/20 12:55 PM, Damien Le Moal wrote:
On 2020/05/11 11:46, Damien Le Moal wrote:
Mike,
I am still seeing the warning:
[ 1827.839756] device-mapper: table: 253:1: adding target device sdj caused an
alignment inconsistency: physical_block_size=4096, logical_block_size=4096,
alignment_offset
On 2020/05/11 11:46, Damien Le Moal wrote:
> Mike,
>
> I am still seeing the warning:
>
> [ 1827.839756] device-mapper: table: 253:1: adding target device sdj caused an
> alignment inconsistency: physical_block_size=4096, logical_block_size=4096,
> alignment_offset=0, start=0
> [ 1827.856738] dev
On 2020/05/11 18:19, Hannes Reinecke wrote:
> On 5/11/20 10:51 AM, Damien Le Moal wrote:
>> On 2020/05/11 17:46, Hannes Reinecke wrote:
>>> On 5/11/20 10:36 AM, Damien Le Moal wrote:
On 2020/05/11 17:24, Hannes Reinecke wrote:
> Implement handling for metadata version 2. The new metadata a
On 5/11/20 10:51 AM, Damien Le Moal wrote:
On 2020/05/11 17:46, Hannes Reinecke wrote:
On 5/11/20 10:36 AM, Damien Le Moal wrote:
On 2020/05/11 17:24, Hannes Reinecke wrote:
Implement handling for metadata version 2. The new metadata adds
a label and UUID for the device mapper device, and addi
On 2020/05/11 17:46, Hannes Reinecke wrote:
> On 5/11/20 10:36 AM, Damien Le Moal wrote:
>> On 2020/05/11 17:24, Hannes Reinecke wrote:
>>> Implement handling for metadata version 2. The new metadata adds
>>> a label and UUID for the device mapper device, and additional UUID
>>> for the underlying
On 5/11/20 10:36 AM, Damien Le Moal wrote:
On 2020/05/11 17:24, Hannes Reinecke wrote:
Implement handling for metadata version 2. The new metadata adds
a label and UUID for the device mapper device, and additional UUID
for the underlying block devices.
It also allows for an additional regular dr
On 2020/05/11 17:24, Hannes Reinecke wrote:
> Implement handling for metadata version 2. The new metadata adds
> a label and UUID for the device mapper device, and additional UUID
> for the underlying block devices.
> It also allows for an additional regular drive to be used for
> emulating random
Use accessors to retrieve the device pointer in preparation
for adding an additional block device.
Signed-off-by: Hannes Reinecke
Reviewed-by: Damien Le Moal
Reviewed-by: Bob Liu
---
drivers/md/dm-zoned-metadata.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a
Add callback for 'dmsetup message' to allow the reclaim process
to be triggered manually.
Eg.
dmsetup message /dev/dm-X 0 message
will start the reclaim process even if the default threshold
of 50 percent of free random zones is not reached.
Signed-off-by: Hannes Reinecke
Reviewed-by: B
Use the metadata label for logging and not the underlying
device.
Signed-off-by: Hannes Reinecke
Reviewed-by: Damien Le Moal
Reviewed-by: Bob Liu
---
drivers/md/dm-zoned-metadata.c | 95 +-
1 file changed, 56 insertions(+), 39 deletions(-)
diff --git a/
Instead of calculating the zone index by the offset within the
zone array store the index within the structure itself. With that
the helper dmz_id() is pointless and can be replaced with accessing
the ->id value directly.
Signed-off-by: Hannes Reinecke
Reviewed-by: Bob Liu
Reviewed-by: Damien Le
Move fields from the device structure into the metadata structure
and provide accessor functions.
Signed-off-by: Hannes Reinecke
Reviewed-by: Damien Le Moal
Reviewed-by: Bob Liu
---
drivers/md/dm-zoned-metadata.c | 88 --
drivers/md/dm-zoned-reclaim.c |
When looking up zones in dmz_alloc_zone() we need to ignore
metadata zones so as not to accidentally overwrite metadata.
Signed-off-by: Hannes Reinecke
Reviewed-by: Damien Le Moal
Reviewed-by: Bob Liu
---
drivers/md/dm-zoned-metadata.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/
Replace the 'target' pointer in the bio context with the
device pointer as this is what's actually used.
Signed-off-by: Hannes Reinecke
Reviewed-by: Bob Liu
Reviewed-by: Damien Le Moal
---
drivers/md/dm-zoned-target.c | 44
1 file changed, 24 insert
Add callback to supply information for 'dmsetup status'
and 'dmsetup table'. The output for 'dmsetup status' is
0 zoned zones / random
/ sequential
where is the number of unmapped (ie free) random zones,
the total number of random zones, the number
of unmapped sequential zones, and the tot
Hi all,
this patchset adds a new metadata version 2 for dm-zoned, which brings the
following improvements:
- UUIDs and labels: Adding three more fields to the metadata containing
the dm-zoned device UUID and label, and the device UUID. This allows
for an unique identification of the devices,
Introduce accessors dmz_dev_is_dying() and dmz_check_dev() to
avoid having to reference the devices directly.
Signed-off-by: Hannes Reinecke
Reviewed-by: Bob Liu
Reviewed-by: Damien Le Moal
---
drivers/md/dm-zoned-metadata.c | 14 --
drivers/md/dm-zoned-reclaim.c | 4 ++--
driver
Use the dmz_zone_to_dev() mapping function to remove the
'dev' argument from reclaim.
Signed-off-by: Hannes Reinecke
Reviewed-by: Bob Liu
Reviewed-by: Damien Le Moal
---
drivers/md/dm-zoned-reclaim.c | 58 +++
drivers/md/dm-zoned-target.c | 2 +-
drive
dm-zoned is becoming quite chatty during startup; reduce the noise
by moving some information to 'debug' level.
Suggested-by: Mike Snitzer
Signed-off-by: Hannes Reinecke
Reviewed-by: Damien Le Moal
---
drivers/md/dm-zoned-metadata.c | 24
1 file changed, 12 insertions(
Implement handling for metadata version 2. The new metadata adds
a label and UUID for the device mapper device, and additional UUID
for the underlying block devices.
It also allows for an additional regular drive to be used for
emulating random access zones. The emulated zones will be placed
logica
Introduce dmz_metadata_label() to format the device-mapper device
name and use it instead of the device name of the underlying device.
Signed-off-by: Hannes Reinecke
Reviewed-by: Damien Le Moal
Reviewed-by: Bob Liu
---
drivers/md/dm-zoned-metadata.c | 11 ++-
drivers/md/dm-zoned-reclaim.c
Store the device together with the superblock so that
we don't have to recur to the metadata to find it.
Signed-off-by: Hannes Reinecke
Reviewed-by: Damien Le Moal
Reviewed-by: Bob Liu
---
drivers/md/dm-zoned-metadata.c | 90 +++---
1 file changed, 59 insert
Instead of storing just the first superblock zone and calculate
the secondary relative to that we should be using an array for
holding the superblock zones.
Signed-off-by: Hannes Reinecke
Reviewed-by: Damien Le Moal
Reviewed-by: Bob Liu
---
drivers/md/dm-zoned-metadata.c | 41 +
On Fri, May 8, 2020, at 17:09, Mike Snitzer wrote:
> On Fri, May 08 2020 at 3:22pm -0400,
> k...@orbekk.com wrote:
>
> > On Thu, May 7, 2020, at 21:12, Chaitanya Kulkarni wrote:
> > > On 05/07/2020 04:06 PM, Kjetil Orbekk wrote:
> > > > + if (tio->error)
> > > > +
Hi Alasdair,
Thank you for your time and comments.
On Thu, May 7, 2020, at 20:18, Alasdair G Kergon wrote:
> On Thu, May 07, 2020 at 07:05:33PM -0400, Kjetil Orbekk wrote:
> > This will track ioerr_cnt on all dm targets and expose it as
> > /dm/ioerr_cnt.
>
> How do you propose to use this?
> Wh
On 05/07/2020 04:06 PM, Kjetil Orbekk wrote:
> + if (tio->error)
> + atomic_inc(&md->ioerr_cnt);
Given that there are so many errors how would user know what
kind of error is generated and how many times?
--
dm-devel mailing list
dm-devel@redhat.com
https://www.
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By ma
From: Khazhismel Kumykov
This will track ioerr_cnt on all dm targets and expose it as
/dm/ioerr_cnt.
Signed-off-by: Khazhismel Kumykov
[k...@orbekk.com: added support for bio based devices in dm.c]
Signed-off-by: Kjetil Orbekk
---
drivers/md/dm-core.h | 2 ++
drivers/md/dm-rq.c| 4
Hi Mike,
You are right.
I did not notice that the macro DMEMIT uses the sz variable.
Thanks.
On 2020/5/7 22:29, Mike Snitzer wrote:
On Thu, May 07 2020 at 8:26am -0400,
Samuel Zou wrote:
This patch fixes below warning reported by coccicheck:
drivers/md/dm-historical-service-time.c:240:14-
On Thu, May 7, 2020, at 21:12, Chaitanya Kulkarni wrote:
> On 05/07/2020 04:06 PM, Kjetil Orbekk wrote:
> > + if (tio->error)
> > + atomic_inc(&md->ioerr_cnt);
>
> Given that there are so many errors how would user know what
> kind of error is generated and how many tim
On 15/04/2020 18:25, deven.de...@linux.microsoft.com wrote:
> From: Deven Bowers
>
> Overview:
>
>
> IPE is a Linux Security Module which allows for a configurable
> policy to enforce integrity requirements on the whole system. It
> attempts to solve the is
56 matches
Mail list logo
