Yes, good call!
Reposted with allocation failure handling.
Thanks,
Ignat
On Wed, Dec 30, 2020 at 6:11 PM Mikulas Patocka wrote:
>
> Hi
>
> This patch doesn't handle allocation failure gracefully.
>
> Mikulas
>
>
>
> On Tue, 29 Dec 2020, Ignat Korchagin wrote:
>
> > Commit
Commit 39d42fa96ba1b7d2544db3f8ed5da8fb0d5cb877 made it possible for some code
paths in dm-crypt to be executed in softirq context, when the underlying driver
processes IO requests in interrupt/softirq context.
When Crypto API backlogs a crypto request, dm-crypt uses wait_for_completion to
avoid
Changes from v1:
0001: Handle memory allocation failure for GFP_ATOMIC
Ignat Korchagin (2):
dm crypt: use GFP_ATOMIC when allocating crypto requests from softirq
dm crypt: do not wait for backlogged crypto request completion in
softirq
drivers/md/dm-crypt.c | 135
Commit 39d42fa96ba1b7d2544db3f8ed5da8fb0d5cb877 made it possible for some code
paths in dm-crypt to be executed in softirq context, when the underlying driver
processes IO requests in interrupt/softirq context.
In this case sometimes when allocating a new crypto request we may get a
stacktrace
On Tue, Dec 29 2020 at 4:18am -0500,
dannyshih wrote:
> From: Danny Shih
>
> We found out that split bios might handle not in order when a big bio
> had split by blk_queue_split() and also split in stacking block device,
> such as md device because chunk size boundary limit.
>
> Stacking
Hi
This patch doesn't handle allocation failure gracefully.
Mikulas
On Tue, 29 Dec 2020, Ignat Korchagin wrote:
> Commit 39d42fa96ba1b7d2544db3f8ed5da8fb0d5cb877 made it possible for some code
> paths in dm-crypt to be executed in softirq context, when the underlying
> driver
> processes IO
On 30/12/2020 17:06, John Stoffel wrote:
Danny> "Provide a way for stacking block device to re-submit
Danny> the bio which should be handled first."
Danny> I will fix it.
Great, though my second question is*why* it needs to be handled
first? What is the difference between stacked and
> "Danny" == Danny Shih writes:
Danny> Hi, John,
Danny> Thank you for taking the time to write a review.
Danny> John Stoffel writes:
>>> "dannyshih" == dannyshih writes:
dannyshih> From: Danny Shih
dannyshih> Porvide a way for stacking block device to re-submit the bio
dannyshih>
> "antlists" == antlists writes:
antlists> On 30/12/2020 00:00, John Stoffel wrote:
dannyshih> From: Danny Shih
dannyshih> Porvide a way for stacking block device to re-submit the bio
dannyshih> which sholud be handled firstly.
>>
>> You're spelling needs to be fixed in these messages.
On Wed, Dec 30, 2020 at 7:36 AM Hillf Danton wrote:
>
> On Tue, 29 Dec 2020 22:57:13 +
> >
> > Fixes: 39d42fa96ba1 ("dm crypt: add flags to optionally bypass kcryptd
> > workqueues")
>
> Looks like a seperate fix to this commit is needed if what can be found
> at (Subject: [patch 00/12] UBS:
Hi, John,
Thank you for taking the time to write a review.
John Stoffel writes:
"dannyshih" == dannyshih writes:
dannyshih> From: Danny Shih
dannyshih> Porvide a way for stacking block device to re-submit the bio
dannyshih> which sholud be handled firstly.
You're spelling needs to be
From: Hyeongseok Kim
[ Upstream commit 252bd1256396cebc6fc3526127fdb0b317601318 ]
If emergency system shutdown is called, like by thermal shutdown,
a dm device could be alive when the block device couldn't process
I/O requests anymore. In this state, the handling of I/O errors
by new dm I/O
From: Hyeongseok Kim
[ Upstream commit 252bd1256396cebc6fc3526127fdb0b317601318 ]
If emergency system shutdown is called, like by thermal shutdown,
a dm device could be alive when the block device couldn't process
I/O requests anymore. In this state, the handling of I/O errors
by new dm I/O
From: Hyeongseok Kim
[ Upstream commit 252bd1256396cebc6fc3526127fdb0b317601318 ]
If emergency system shutdown is called, like by thermal shutdown,
a dm device could be alive when the block device couldn't process
I/O requests anymore. In this state, the handling of I/O errors
by new dm I/O
From: Hyeongseok Kim
[ Upstream commit 252bd1256396cebc6fc3526127fdb0b317601318 ]
If emergency system shutdown is called, like by thermal shutdown,
a dm device could be alive when the block device couldn't process
I/O requests anymore. In this state, the handling of I/O errors
by new dm I/O
On 30/12/2020 00:00, John Stoffel wrote:
dannyshih> From: Danny Shih
dannyshih> Porvide a way for stacking block device to re-submit the bio
dannyshih> which sholud be handled firstly.
You're spelling needs to be fixed in these messages.
^^
It is traditional, when correcting someone
16 matches
Mail list logo
