[dm-devel] [PATCH 0/3] multipath-tools: cleanup uevent generation on startup

2021-01-08 Thread mwilck
From: Martin Wilck This series undoes several changes I did myself in an attempt to fix issues with multipath maps incompletely initialized in udev. They are now all superseded by 0d66e03 ("libmultipath: force map reload if udev incomplete"). Triggering artificial (spurious) uevents for dm

[dm-devel] [PATCH 3/3] Revert "multipathd: uev_trigger(): handle incomplete ADD events"

2021-01-08 Thread mwilck
From: Martin Wilck cb10d38 ("multipathd: uev_trigger(): handle incomplete ADD events") was an attempt to fix issues with incompletely initialized multipath maps observed in various scenarious. However, that patch was wrong. Spurious "change" events as this patch would generate have no effect,

[dm-devel] [PATCH 1/3] libmultipath: select_action(): skip is_mpp_known_to_udev() test

2021-01-08 Thread mwilck
From: Martin Wilck This test is now superseded by the check introduced in 0d66e03 ("libmultipath: force map reload if udev incomplete"). Signed-off-by: Martin Wilck --- libmultipath/configure.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/libmultipath/configure.c

[dm-devel] [PATCH 2/3] libmultipath: coalesce_paths(): stop triggering spurious uevents

2021-01-08 Thread mwilck
From: Martin Wilck Since 0d66e03 ("libmultipath: force map reload if udev incomplete"), we force-reload maps that we find incompletely initialized by udev. If select_action returns ACT_NOTHING nonetheless, the map must be initialized in udev, and thus and "add" uevent must have been seen

Re: [dm-devel] dm-integrity: Fix flush with external metadata device

2021-01-08 Thread Mikulas Patocka
On Fri, 8 Jan 2021, Mike Snitzer wrote: > > > Seems like a pretty bad oversight... but shouldn't you also make sure to > > > flush the data device _before_ the metadata is flushed? > > > > > > Mike > > > > I think, ordering is not a problem. > > > > A disk may flush its cache spontaneously

Re: [dm-devel] dm-integrity: Fix flush with external metadata device

2021-01-08 Thread Mike Snitzer
On Fri, Jan 08 2021 at 11:12am -0500, Mikulas Patocka wrote: > > > On Mon, 4 Jan 2021, Mike Snitzer wrote: > > > On Sun, Dec 20 2020 at 8:02am -0500, > > Lukas Straub wrote: > > > > > With an external metadata device, flush requests aren't passed down > > > to the data device. > > > > > >

Re: [dm-devel] [PATCH RFC 3/7] block: add iopoll method for non-mq device

2021-01-08 Thread Mike Snitzer
On Thu, Jan 07 2021 at 10:24pm -0500, JeffleXu wrote: > > > On 1/8/21 5:47 AM, Mike Snitzer wrote: > > On Wed, Dec 23 2020 at 6:26am -0500, > > Jeffle Xu wrote: > > > >> ->poll_fn is introduced in commit ea435e1b9392 ("block: add a poll_fn > >> callback to struct request_queue") for

Re: [dm-devel] [PATCH RFC 6/7] block: track cookies of split bios for bio-based device

2021-01-08 Thread Mike Snitzer
On Thu, Jan 07 2021 at 10:08pm -0500, JeffleXu wrote: > Thanks for reviewing. > > > On 1/8/21 6:18 AM, Mike Snitzer wrote: > > On Wed, Dec 23 2020 at 6:26am -0500, > > Jeffle Xu wrote: > > > >> This is actuaaly the core when supporting iopoll for bio-based device. > >> > >> A list is

Re: [dm-devel] [PATCH v3] dm-crypt: fix deadlock when swapping to encrypted device

2021-01-08 Thread Mikulas Patocka
Hi On Mon, 30 Nov 2020, John Dorminy wrote: > I am the first to admit I don't understand all the subtleties of the > block layer, but I'm worried about a deadlock in close analogy to that > described in bio_alloc_bioset. > https://elixir.bootlin.com/linux/latest/source/block/bio.c#L463 >

[dm-devel] [PATCH] dm-integrity: Fix flush with external metadata device

2021-01-08 Thread Mikulas Patocka
With external metadata device, flush requests are not passed down to the data device. Fix this by submitting the flush request in dm_integrity_flush_buffers. In order to not degrade performance, we overlap the data device flush with the metadata device flush. Signed-off-by: Mikulas Patocka

Re: [dm-devel] dm-integrity: Fix flush with external metadata device

2021-01-08 Thread Mikulas Patocka
On Mon, 4 Jan 2021, Mike Snitzer wrote: > On Sun, Dec 20 2020 at 8:02am -0500, > Lukas Straub wrote: > > > With an external metadata device, flush requests aren't passed down > > to the data device. > > > > Fix this by issuing flush in the right places: In integrity_commit > > when not in

Re: [dm-devel] [PATCH RFC 7/7] dm: add support for IO polling

2021-01-08 Thread JeffleXu
On 12/23/20 7:26 PM, Jeffle Xu wrote: > Enable iopoll when all underlying target devices supports iopoll. > > Signed-off-by: Jeffle Xu > --- > drivers/md/dm-table.c | 28 > drivers/md/dm.c | 1 + > 2 files changed, 29 insertions(+) > > diff --git

Re: [dm-devel] [PATCH RFC 6/7] block: track cookies of split bios for bio-based device

2021-01-08 Thread JeffleXu
Thanks for reviewing. On 1/8/21 6:18 AM, Mike Snitzer wrote: > On Wed, Dec 23 2020 at 6:26am -0500, > Jeffle Xu wrote: > >> This is actuaaly the core when supporting iopoll for bio-based device. >> >> A list is maintained in the top bio (the original bio submitted to dm >> device), which is

Re: [dm-devel] [PATCH RFC 3/7] block: add iopoll method for non-mq device

2021-01-08 Thread JeffleXu
On 1/8/21 5:47 AM, Mike Snitzer wrote: > On Wed, Dec 23 2020 at 6:26am -0500, > Jeffle Xu wrote: > >> ->poll_fn is introduced in commit ea435e1b9392 ("block: add a poll_fn >> callback to struct request_queue") for supporting non-mq queues such as >> nvme multipath, but removed in commit