Sorry for the delay testing:
On Sat, Jan 23, 2021 at 09:19:56AM -0500, Mikulas Patocka wrote:
> On Fri, 15 Jan 2021, J. Bruce Fields wrote:
>
> > Any recommendations? I spent some time with blktrace/blkparse/btt and
> > can't make head or tails of them, I'm afraid.
> >
> > --b.
>
> Hi
>
>
On Mon, Jan 25 2021 at 7:13am -0500,
Jeffle Xu wrote:
> ->poll_fn was introduced in commit ea435e1b9392 ("block: add a poll_fn
> callback to struct request_queue") to support bio-based queues such as
> nvme multipath, but was later removed in commit 529262d56dbe ("block:
> remove ->poll_fn").
>
On Mon, Jan 25 2021 at 7:13am -0500,
Jeffle Xu wrote:
> Introduce QUEUE_FLAG_POLL_CAP flag representing if the request queue
> capable of polling or not.
>
> Signed-off-by: Jeffle Xu
Why are you adding QUEUE_FLAG_POLL_CAP? Doesn't seem as though DM or
anything else actually needs it.
Mike
On Mon, Jan 25 2021 at 7:13am -0500,
Jeffle Xu wrote:
> Sometimes we need to get the corresponding gendisk from request_queue.
>
> It is preferred that block drivers store private data in
> gendisk->private_data rather than request_queue->queuedata, e.g. see:
> commit c4a59c4e5db3 ("dm: stop
On Mon, Jan 25 2021 at 7:13am -0500,
Jeffle Xu wrote:
> Since currently we have no simple but efficient way to implement the
> bio-based IO polling in the split-bio tracking style, this patch set
> turns to the original implementation mechanism that iterates and
> polls all underlying hw queues
On 1/26/21 7:52 AM, Christoph Hellwig wrote:
> Hi Jens,
>
> this series contains various cleanups for how bios are allocated or
> initialized plus related fallout.
Applied, thanks.
--
Jens Axboe
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
On Tue, 2021-01-26 at 19:16 -0600, Benjamin Marzinski wrote:
>
> Martin, I noticed that this commit didn't make it into your queue
> branch. I assume it's just an oversight. Right?
Yes, I'm sorry. Fixed now.
Cheers,
Martin
--
Dr. Martin Wilck , Tel. +49 (0)911 74053 2107
SUSE Software
On 23/01/2021 21:26, Mikulas Patocka wrote:
> Introduce the "fix_hmac" arguent. It improves security of journal_mac:
> - the section number is mixed to the mac, so that an attacker can't
> copy sectors from one journal section to another journal section
> - the superblock is protected by
Fix below warnings reported by coccicheck:
./drivers/md/dm-writecache.c:2008:2-7: WARNING: NULL check before some
freeing functions is not needed.
./drivers/md/dm-writecache.c:2024:2-7: WARNING: NULL check before some
freeing functions is not needed.
Reported-by: Abaci Robot
Signed-off-by:
On Tue, Jan 26, 2021 at 7:19 AM Christoph Hellwig wrote:
>
> Refactor raid5_read_one_chunk so that all simple checks are done
> before allocating the bio.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Song Liu
Thanks for the clean-up!
> ---
> drivers/md/raid5.c | 108
On Tue, Jan 26, 2021 at 7:14 AM Christoph Hellwig wrote:
>
> Use an on-stack bio and biovec for the single page synchronous I/O.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Song Liu
> ---
> drivers/md/md.c | 26 +-
> 1 file changed, 13 insertions(+), 13
On Tue, Jan 26, 2021 at 7:12 AM Christoph Hellwig wrote:
>
> bio_alloc_mddev is never called with a NULL mddev, and ->bio_set is
> initialized in md_run, so it always must be initialized as well. Just
> open code the remaining call to bio_alloc_bioset.
>
> Signed-off-by: Christoph Hellwig
On Tue, Jan 26, 2021 at 7:17 AM Christoph Hellwig wrote:
>
> md_bio_alloc_sync is never called with a NULL mddev, and ->sync_set is
> initialized in md_run, so it always must be initialized as well. Just
> open code the remaining call to bio_alloc_bioset.
>
> Signed-off-by: Christoph Hellwig
Open code drbd_req_make_private_bio in the two callers to prepare
for further changes. Also don't bother to initialize bi_next as the
bio code already does that that.
Signed-off-by: Christoph Hellwig
---
drivers/block/drbd/drbd_req.c| 5 -
drivers/block/drbd/drbd_req.h| 12
14 matches
Mail list logo
