Re: [dm-devel] dm: fix iterate_device sanity check

2021-02-05 Thread Mike Snitzer
On Mon, Feb 01 2021 at 10:35pm -0500, Jeffle Xu wrote: > According to the definition of dm_iterate_devices_fn: > * This function must iterate through each section of device used by the > * target until it encounters a non-zero return code, which it then returns. > * Returns zero if no callout

Re: [dm-devel] [PATCH] multipathd: avoid crash in uevent_cleanup()

2021-02-05 Thread Martin Wilck
On Fri, 2021-02-05 at 12:08 +0100, Martin Wilck wrote: > On Thu, 2021-02-04 at 16:06 +0100, Martin Wilck wrote: > > > From the LWP numbers, thread 2 and 4 are probably TUR checkers > (temporary threads). thread 1 can't be easily identified. Could you > provide the stack of thread 3? From that,

Re: [dm-devel] [PATCH] multipathd: avoid crash in uevent_cleanup()

2021-02-05 Thread Martin Wilck
On Thu, 2021-02-04 at 16:06 +0100, Martin Wilck wrote: > On Thu, 2021-02-04 at 09:40 +0800, lixiaokeng wrote: > > > > > > On 2021/2/3 21:57, Martin Wilck wrote: > > > > If exit() before all pthread_cancel in child of 0.7.7, there is > > > > no > > > > any crash. > > > What do you mean with

Re: [dm-devel] [QUESTION]: multipath device with wrong path lead to metadata err

2021-02-05 Thread lixiaokeng
Hi Martin, I have removed multipathd_query in my test script. And a flock is added before/after reonfigure() and iscsi login/out. Sequence of events: (1)iscsi log out /dev/sdi(36001405b7679bd96b094bccbf971bc90) is removed. multipath -r: sdi->fd is closed. ref of sdi becomes 0. (2)iscsi log