Re: [dm-devel] [PATCH v4 0/5] add support for inline encryption to device mapper

2021-02-11 Thread Satya Tangirala
On Thu, Feb 11, 2021 at 06:04:59PM -0500, Mike Snitzer wrote: > On Thu, Feb 11 2021 at 6:01pm -0500, > Satya Tangirala wrote: > > > On Wed, Feb 10, 2021 at 12:59:59PM -0700, Jens Axboe wrote: > > > On 2/10/21 12:33 PM, Mike Snitzer wrote: > > > > On Mon, Feb 01 2021 at 12:10am -0500, > > > >

[dm-devel] [PATCH 3/4] multipath-tools: fix compilation errors on 32-bit musl

2021-02-11 Thread mwilck
From: Martin Wilck gcc on alpine Linux/i386 throws errors because the "tv_sec" element of struct timespec is a time_t, which is a "long long" in that environment. In general, time_t is signed. As we only use CLOCK_MONOTONIC, which starts at boot time, a cast to long should be no problem, even in

[dm-devel] [PATCH 4/4] libmultipath: fix compilation error with gcc 10 on i386

2021-02-11 Thread mwilck
From: Martin Wilck gcc complained about a possible negative value of "nr" in the memcpy() call. I consider that a false positive, but it's easily fixed. Signed-off-by: Martin Wilck --- libmultipath/sysfs.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-)

[dm-devel] [PATCH 2/4] multipath-tools: devt test: avoid failure when run in containers

2021-02-11 Thread mwilck
From: Martin Wilck /sys/dev/block is usually unavailable containers, causing libudev calls to fail. Skip the respective tests. Signed-off-by: Martin Wilck --- tests/devt.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/devt.c b/tests/devt.c index

[dm-devel] [PATCH 1/4] multipath-tools tests: allow control of test verbosity

2021-02-11 Thread mwilck
From: Martin Wilck Use common code to control verbosity during unit tests runs. The environment variable MPATHTEST_VERBOSITY is honored by most tests, except those that need to parse the log messages or have other special needs. Also, get rid of the now obsolete global variables logsink and

Re: [dm-devel] [PATCH v4 0/5] add support for inline encryption to device mapper

2021-02-11 Thread Satya Tangirala
On Wed, Feb 10, 2021 at 12:59:59PM -0700, Jens Axboe wrote: > On 2/10/21 12:33 PM, Mike Snitzer wrote: > > On Mon, Feb 01 2021 at 12:10am -0500, > > Satya Tangirala wrote: > > > >> This patch series adds support for inline encryption to the device mapper. > >> > >> Patch 1 introduces the

[dm-devel] [PATCH v5 5/5] dm: set DM_TARGET_PASSES_CRYPTO feature for some targets

2021-02-11 Thread Satya Tangirala
dm-linear and dm-flakey obviously can pass through inline crypto support. Co-developed-by: Eric Biggers Signed-off-by: Eric Biggers Signed-off-by: Satya Tangirala Reviewed-by: Eric Biggers --- drivers/md/dm-flakey.c | 4 +++- drivers/md/dm-linear.c | 5 +++-- 2 files changed, 6

[dm-devel] [PATCH v5 4/5] dm: support key eviction from keyslot managers of underlying devices

2021-02-11 Thread Satya Tangirala
Now that device mapper supports inline encryption, add the ability to evict keys from all underlying devices. When an upper layer requests a key eviction, we simply iterate through all underlying devices and evict that key from each device. Co-developed-by: Eric Biggers Signed-off-by: Eric

[dm-devel] [PATCH v5 2/5] block: keyslot-manager: Introduce functions for device mapper support

2021-02-11 Thread Satya Tangirala
Introduce blk_ksm_update_capabilities() to update the capabilities of a keyslot manager (ksm) in-place. The pointer to a ksm in a device's request queue may not be easily replaced, because upper layers like the filesystem might access it (e.g. for programming keys/checking capabilities) at the

Re: [dm-devel] [PATCH v4 0/5] add support for inline encryption to device mapper

2021-02-11 Thread Mike Snitzer
On Thu, Feb 11 2021 at 6:01pm -0500, Satya Tangirala wrote: > On Wed, Feb 10, 2021 at 12:59:59PM -0700, Jens Axboe wrote: > > On 2/10/21 12:33 PM, Mike Snitzer wrote: > > > On Mon, Feb 01 2021 at 12:10am -0500, > > > Satya Tangirala wrote: > > > > > >> This patch series adds support for

[dm-devel] Cache writethrough mode skips writes to source

2021-02-11 Thread Jens-Wolfhard Schicke-Uffmann
Hi, while debugging an I/O load issue at a client, I came across cases of system reboots (which apparently included an unclear device shutdown), where a dm-cache was marked all-dirty, as described e.g. in admin-guide/device-mapper/cache.rst > The 'dirty' state for a cache block changes far too

Re: [dm-devel] [PATCH v5 5/6] dm: add 'noexcl' option for dm-linear

2021-02-11 Thread Mike Snitzer
On Tue, Feb 09 2021 at 9:30am -0500, Sergei Shtepa wrote: > The 'noexcl' option allow to open underlying block-device > without FMODE_EXCL. > > Signed-off-by: Sergei Shtepa > --- > drivers/md/dm-linear.c| 14 +- > drivers/md/dm-table.c | 14 -- >

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-11 Thread Martin Wilck
On Wed, 2021-02-10 at 22:48 -0600, Benjamin Marzinski wrote: > On Tue, Feb 09, 2021 at 10:19:45PM +, Martin Wilck wrote: > > On Mon, 2021-02-08 at 23:19 -0600, Benjamin Marzinski wrote: > > > There are cases where the wwid of a path changes due to LUN > > > remapping > > > without triggering

Re: [dm-devel] [PATCH v2] dm era: only resize metadata in preresume

2021-02-11 Thread Mike Snitzer
On Thu, Feb 11 2021 at 9:22am -0500, Nikos Tsironis wrote: > Metadata resize shouldn't happen in the ctr. The ctr loads a temporary > (inactive) table that will only become active upon resume. That is why > resize should always be done in terms of resume. Otherwise a load (ctr) > whose inactive

[dm-devel] [PATCH v2] dm era: only resize metadata in preresume

2021-02-11 Thread Nikos Tsironis
Metadata resize shouldn't happen in the ctr. The ctr loads a temporary (inactive) table that will only become active upon resume. That is why resize should always be done in terms of resume. Otherwise a load (ctr) whose inactive table never becomes active will incorrectly resize the metadata.

Re: [dm-devel] [PATCH 4/4] dm era: Remove unreachable resize operation in pre-resume function

2021-02-11 Thread Nikos Tsironis
On 2/10/21 8:48 PM, Mike Snitzer wrote: On Wed, Feb 10 2021 at 1:12P -0500, Mike Snitzer wrote: On Fri, Jan 22 2021 at 10:25am -0500, Nikos Tsironis wrote: The device metadata are resized in era_ctr(), so the metadata resize operation in era_preresume() never runs. Also, note, that if

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-11 Thread Benjamin Block
On Wed, Feb 10, 2021 at 07:09:31PM +0100, Benjamin Block wrote: > On Tue, Feb 09, 2021 at 10:19:45PM +, Martin Wilck wrote: > > On Mon, 2021-02-08 at 23:19 -0600, Benjamin Marzinski wrote: > > > There are cases where the wwid of a path changes due to LUN remapping > > > without triggering