[dm-devel] dm-multipath "shaky SAN detection" is insufficient for intermittent errors.

2021-03-22 Thread Erwin van Londen
Hello All, This topic may have been discussed before although I've not been able to find it in this d-list. The "shaky SAN" detection method seems to be currently based on availability of the remote target ports and how often they disappear/reappear as per HBA state change on that remote target.

Re: [dm-devel] [RFC PATCH V2 09/13] block: use per-task poll context to implement bio based io poll

2021-03-22 Thread Sagi Grimberg
+static void blk_bio_poll_post_submit(struct bio *bio, blk_qc_t cookie) +{ + bio->bi_iter.bi_private_data = cookie; +} + Hey Ming, thinking about nvme-mpath, I'm thinking that this should be an exported function for failover. nvme-mpath updates bio.bi_dev when re-submitting I/Os to an

Re: [dm-devel] [PATCH] Revert "multipath -U: reduce log level of "adding new path" message"

2021-03-22 Thread Benjamin Marzinski
On Fri, Mar 19, 2021 at 05:26:47PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > After "11-dm-mpath.rules: run "multipath -U" with -v1", this patch isn't > necessary any more. It's desirable to see these messages from multipathd, > as they mean that a valid path had been found in a map

Re: [dm-devel] md/dm-mpath: check whether all pgpaths have same uuid in multipath_ctr()

2021-03-22 Thread Mike Snitzer
On Mon, Mar 22 2021 at 4:11am -0400, Christoph Hellwig wrote: > On Sat, Mar 20, 2021 at 03:19:23PM +0800, Zhiqiang Liu wrote: > > From: Zhiqiang Liu > > > > When we make IO stress test on multipath device, there will > > be a metadata err because of wrong path. In the test, we > > concurrent

[dm-devel] [PATCH] dm: don't report "detected capacity change" on device creation.

2021-03-22 Thread Mikulas Patocka
This patch shuts up a message "detected capacity change" when creating a dm devce. Signed-off-by: Mikulas Patocka Index: linux-2.6/drivers/md/dm.c === --- linux-2.6.orig/drivers/md/dm.c +++ linux-2.6/drivers/md/dm.c @@ -2036,7

Re: [dm-devel] [PATCH] multipath-tools: use same format for default values in multipath.conf.5

2021-03-22 Thread Martin Wilck
On Sat, 2021-03-20 at 03:13 +0100, Xose Vazquez Perez wrote: > For max_sectors_kb, replace "device dependent" with its sysfs path. > And use as wildcard for device in paths. > > Cc: Martin Wilck > Cc: Benjamin Marzinski > Cc: Christophe Varoqui > Cc: DM-DEVEL ML Reviewed-by: Martin Wilck

Re: [dm-devel] [PATCH] md/dm-mpath: check whether all pgpaths have same uuid in multipath_ctr()

2021-03-22 Thread Christoph Hellwig
On Sat, Mar 20, 2021 at 03:19:23PM +0800, Zhiqiang Liu wrote: > From: Zhiqiang Liu > > When we make IO stress test on multipath device, there will > be a metadata err because of wrong path. In the test, we > concurrent execute 'iscsi device login|logout' and > 'multipath -r' command with IO

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-03-22 Thread Song Liu
On Wed, Feb 24, 2021 at 1:26 AM Guoqing Jiang wrote: > > > > On 2/24/21 10:09, Song Liu wrote: > > On Mon, Feb 15, 2021 at 3:08 AM Paul Menzel wrote: > >> > >> [+cc Donald] > >> > >> Am 13.02.21 um 01:49 schrieb Guoqing Jiang: > >>> Unregister sync_thread doesn't need to hold reconfig_mutex

Re: [dm-devel] [RFC PATCH V2 09/13] block: use per-task poll context to implement bio based io poll

2021-03-22 Thread JeffleXu
I'm thinking how this mechanism could work with *original* bio-based devices that don't ne built upon mq devices, such as nvdimm. This mechanism (also including my original design) mainly focuses on virtual devices that built upon mq devices, i.e., md/dm. As the original bio-based devices wants

Re: [dm-devel] [PATCH] dm: ebs: Several typo fixes

2021-03-22 Thread Randy Dunlap
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: s/retrievd/retrieved/ s/misalignement/misalignment/ s/funtion/function/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- drivers/md/dm-ebs-target.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [dm-devel] [RFC PATCH V2 09/13] block: use per-task poll context to implement bio based io poll

2021-03-22 Thread JeffleXu
On 3/19/21 9:46 PM, Ming Lei wrote: > On Fri, Mar 19, 2021 at 05:38:38PM +0800, JeffleXu wrote: >> I'm thinking how this mechanism could work with *original* bio-based >> devices that don't ne built upon mq devices, such as nvdimm. This > > non-mq device needs driver to implement io polling by

Re: [dm-devel] [RFC PATCH V2 05/13] block: add req flag of REQ_TAG

2021-03-22 Thread JeffleXu
On 3/19/21 4:48 PM, Ming Lei wrote: > On Fri, Mar 19, 2021 at 03:59:06PM +0800, JeffleXu wrote: >> >> >> On 3/19/21 12:48 AM, Ming Lei wrote: >>> Add one req flag REQ_TAG which will be used in the following patch for >>> supporting bio based IO polling. >>> >>> Exactly this flag can help us to