[dm-devel] [PATCH] multipath-tools: convert back HUAWEI/XSG1 to multibus

2021-03-25 Thread Xose Vazquez Perez
This reverts commit ad206af1716437e84bbd81de6c4da7961d9a41d2 Recommended configs are, info from: - RHEL https://download.huawei.com/edownload/e/download.do?actionFlag=download=EDOC1100113070=6001=SUPE_DOC&_t=1612885511000 - SLES

[dm-devel] [PATCH v2] multipath-tools: add NVME/Huawei-XSG1 to hwtable

2021-03-25 Thread Xose Vazquez Perez
Info from: https://download.huawei.com/edownload/e/download.do?actionFlag=download=EDOC1100154490=6001=SUPE_DOC&_t=1612885603000 Cc: Zhouweigang (Jack) Cc: Zou Ming Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- v2: add

[dm-devel] [PATCH 4/4] multipathd: don't trigger uevent for partitions on wwid change

2021-03-25 Thread Benjamin Marzinski
If the wwid changed, the device is no longer the same, so sending add events to the devices partitions doesn't make any sense. Signed-off-by: Benjamin Marzinski --- multipathd/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/multipathd/main.c b/multipathd/main.c index

[dm-devel] [PATCH 1/4] libmultipath: avoid infinite loop with bad vpd page 83 identifier

2021-03-25 Thread Benjamin Marzinski
If a device with a scsi name identifier has an unknown prefix, parse_vpd_pg83() needs to advance to the next identifier, instead of simply trying the same one again in an infinite loop. Signed-off-by: Benjamin Marzinski --- libmultipath/discovery.c | 2 +- 1 file changed, 1 insertion(+), 1

[dm-devel] [PATCH 0/4] Fixups to my wwid recheck patch

2021-03-25 Thread Benjamin Marzinski
This patchset has minor fixups that were either suggested by Martin, or came up through the disussions about my "Handle remapped LUNs better" patchset. Benjamin Marzinski (4): libmultipath: avoid infinite loop with bad vpd page 83 identifier libmultipath: fix priorities in parse_vpd_pg83

[dm-devel] [PATCH 3/4] multipathd: improve getting parent udevice in rescan_path

2021-03-25 Thread Benjamin Marzinski
Instead of looping through parents and checking, just call udev_device_get_parent_with_subsystem_devtype() to get the right one. Signed-off-by: Benjamin Marzinski --- multipathd/main.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/multipathd/main.c

[dm-devel] [PATCH 2/4] libmultipath: fix priorities in parse_vpd_pg83

2021-03-25 Thread Benjamin Marzinski
The priorities for the EUI-64 (0x02) and NAME (0x08) scsi identifiers in parse_vpd_pg83() don't match their priorities in 55-scsi-sg3_id.rules. Switch them so that they match. Signed-off-by: Benjamin Marzinski --- libmultipath/discovery.c | 16 1 file changed, 8 insertions(+),

[dm-devel] [PATCH] multipath-tools: add NVME/Huawei-XSG1 to hwtable

2021-03-25 Thread Xose Vazquez Perez
Info from: https://download.huawei.com/edownload/e/download.do?actionFlag=download=EDOC1100154490=6001=SUPE_DOC&_t=1612885603000 Cc: Zou Ming Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML --- libmultipath/hwtable.c | 9 + 1 file changed, 9

[dm-devel] [PATCH 2/2] multipath-tools: add more info about ALUA for CLARiiON arrays

2021-03-25 Thread Xose Vazquez Perez
EMC tool "Drop-down list" differs across product generations. Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- README.alua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.alua b/README.alua index

[dm-devel] [PATCH 0/2] multipath-tools: add more ALUA info to docs

2021-03-25 Thread Xose Vazquez Perez
Xose Vazquez Perez (2): multipath-tools: add info about how to enable ALUA in Huawei OceanStor arrays multipath-tools: add more info about ALUA for CLARiiON arrays README.alua | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe

[dm-devel] [PATCH 1/2] multipath-tools: add info about how to enable ALUA in Huawei OceanStor arrays

2021-03-25 Thread Xose Vazquez Perez
Cc: Zou Ming Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- README.alua | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.alua b/README.alua index 340ccba2..f9967595 100644 --- a/README.alua +++ b/README.alua

Re: [dm-devel] [PATCH V3 13/13] dm: support IO polling for bio-based dm device

2021-03-25 Thread Mike Snitzer
On Wed, Mar 24 2021 at 8:19am -0400, Ming Lei wrote: > From: Jeffle Xu > > IO polling is enabled when all underlying target devices are capable > of IO polling. The sanity check supports the stacked device model, in > which one dm device may be build upon another dm device. In this case, >

Re: [dm-devel] md/dm-mpath: check whether all pgpaths have same uuid in multipath_ctr()

2021-03-25 Thread Mike Snitzer
On Wed, Mar 24 2021 at 9:21pm -0400, Zhiqiang Liu wrote: > > > On 2021/3/22 22:22, Mike Snitzer wrote: > > On Mon, Mar 22 2021 at 4:11am -0400, > > Christoph Hellwig wrote: > > > >> On Sat, Mar 20, 2021 at 03:19:23PM +0800, Zhiqiang Liu wrote: > >>> From: Zhiqiang Liu > >>> > >>> When we

Re: [dm-devel] [PATCH V3 09/13] block: use per-task poll context to implement bio based io polling

2021-03-25 Thread Ming Lei
On Thu, Mar 25, 2021 at 05:18:41PM +0800, JeffleXu wrote: > > > On 3/25/21 4:05 PM, Ming Lei wrote: > > On Thu, Mar 25, 2021 at 02:34:18PM +0800, JeffleXu wrote: > >> > >> > >> On 3/24/21 8:19 PM, Ming Lei wrote: > >>> Currently bio based IO polling needs to poll all hw queue blindly, this > >>>

Re: [dm-devel] [PATCH V3 05/13] block: add req flag of REQ_POLL_CTX

2021-03-25 Thread JeffleXu
On 3/24/21 8:19 PM, Ming Lei wrote: > Add one req flag REQ_POLL_CTX which will be used in the following patch for > supporting bio based IO polling. > > Exactly this flag can help us to do: > > 1) request flag is cloned in bio_fast_clone(), so if we mark one FS bio > as REQ_POLL_CTX, all bios

Re: [dm-devel] [PATCH V3 04/13] block: create io poll context for submission and poll task

2021-03-25 Thread JeffleXu
On 3/24/21 8:19 PM, Ming Lei wrote: > Create per-task io poll context for both IO submission and poll task > if the queue is bio based and supports polling. > > This io polling context includes two queues: > > 1) submission queue(sq) for storing HIPRI bio, written by submission task >and

Re: [dm-devel] [PATCH V3 09/13] block: use per-task poll context to implement bio based io polling

2021-03-25 Thread JeffleXu
On 3/24/21 8:19 PM, Ming Lei wrote: > Currently bio based IO polling needs to poll all hw queue blindly, this > way is very inefficient, and one big reason is that we can't pass any > bio submission result to blk_poll(). > > In IO submission context, track associated underlying bios by

Re: [dm-devel] [PATCH V3 03/13] block: add helper of blk_create_io_context

2021-03-25 Thread Keith Busch
On Wed, Mar 24, 2021 at 08:19:17PM +0800, Ming Lei wrote: > +static inline void blk_create_io_context(struct request_queue *q) > +{ > + /* > + * Various block parts want %current->io_context, so allocate it up > + * front rather than dealing with lots of pain to allocate it only > +

Re: [dm-devel] [PATCH V3 04/13] block: create io poll context for submission and poll task

2021-03-25 Thread JeffleXu
On 3/25/21 10:51 AM, Ming Lei wrote: > On Thu, Mar 25, 2021 at 10:34:02AM +0800, JeffleXu wrote: >> >> >> On 3/24/21 8:19 PM, Ming Lei wrote: >>> Create per-task io poll context for both IO submission and poll task >>> if the queue is bio based and supports polling. >>> >>> This io polling

Re: [dm-devel] [PATCH V3 01/13] block: add helper of blk_queue_poll

2021-03-25 Thread JeffleXu
On 3/24/21 8:19 PM, Ming Lei wrote: > There has been 3 users, and will be more, so add one such helper. > > Reviewed-by: Chaitanya Kulkarni > Signed-off-by: Ming Lei Better to also convert blk-sysfs.c:queue_poll_show(). With that fixed, Reviewed-by: Jeffle Xu > --- > block/blk-core.c

Re: [dm-devel] [PATCH V3 09/13] block: use per-task poll context to implement bio based io polling

2021-03-25 Thread Ming Lei
On Thu, Mar 25, 2021 at 02:34:18PM +0800, JeffleXu wrote: > > > On 3/24/21 8:19 PM, Ming Lei wrote: > > Currently bio based IO polling needs to poll all hw queue blindly, this > > way is very inefficient, and one big reason is that we can't pass any > > bio submission result to blk_poll(). > >

Re: [dm-devel] [PATCH V3 07/13] block/mq: extract one helper function polling hw queue

2021-03-25 Thread Hannes Reinecke
On 3/24/21 1:19 PM, Ming Lei wrote: From: Jeffle Xu Extract the logic of polling one hw queue and related statistics handling out as the helper function. Signed-off-by: Jeffle Xu Signed-off-by: Ming Lei --- block/blk-mq.c | 18 ++ 1 file changed, 14 insertions(+), 4