Re: [dm-devel] [PATCH v2 10/14] block: add bio_start_io_acct_remapped for the benefit of DM

2022-02-14 Thread Mike Snitzer
On Mon, Feb 14 2022 at 9:02P -0500, Christoph Hellwig wrote: > On Fri, Feb 11, 2022 at 04:40:53PM -0500, Mike Snitzer wrote: > > DM needs the ability to account a clone bio's IO to the original > > block_device. So add @orig_bdev argument to bio_start_io_acct_time. > > > > Rename

Re: [dm-devel] [PATCH v3 00/10] Add Copy offload support

2022-02-14 Thread Dave Chinner
On Mon, Feb 14, 2022 at 01:29:50PM +0530, Nitesh Shetty wrote: > The patch series covers the points discussed in November 2021 virtual call > [LSF/MM/BFP TOPIC] Storage: Copy Offload[0]. > We have covered the Initial agreed requirements in this patchset. > Patchset borrows Mikulas's token based

[dm-devel] [PATCH v2 2/2] libmultipath: add %L path wildcard for 64-bit hex LUN

2022-02-14 Thread Steffen Maier
Complements v0.6.0 commit 01ab2a468ea2 ("libmultipath: Add additional path wildcards") as well as ("libmultipath: support host adapter name lookup for s390x ccw bus"). With that we can easily get the full FCP addressing triplet (HBA, WWPN, FCPLUN) from multipath tools without additional tools and

[dm-devel] [PATCH v2 1/2] libmultipath: support host adapter name lookup for s390x ccw bus

2022-02-14 Thread Steffen Maier
There are also (FCP) HBAs that appear on a bus different from PCI. Complements v0.6.0 commit 01ab2a468ea2 ("libmultipath: Add additional path wildcards"). With that we can easily get the full FCP addressing triplet (HBA, WWPN, LUN) from multipath tools without additional tools and correlation:

[dm-devel] [PATCH v2 0/2] multipath-tools: FCP addressing display support (for s390x)

2022-02-14 Thread Steffen Maier
It is quicker and easier than writing some script to correlate multipath output with other query tooling for FCP addressing. For patch set version ChangeLog, see indidivual patches. Steffen Maier (2): libmultipath: support host adapter name lookup for s390x ccw bus libmultipath: add %L path

[dm-devel] [PATCH] multipathd: disallow changing to/from fpin marginal paths on reconfig

2022-02-14 Thread Benjamin Marzinski
Setting marginal_pathgroups to fpin causes two new threads to be created when multipathd starts. Turning it on after multipathd starts up won't cause the theads to start, and turing it off won't keep the threads from working. So disallow changing marginal_pathgroups to/from "fpin" on reconfigure.

Re: [dm-devel] [PATCH v2 10/14] block: add bio_start_io_acct_remapped for the benefit of DM

2022-02-14 Thread Christoph Hellwig
On Fri, Feb 11, 2022 at 04:40:53PM -0500, Mike Snitzer wrote: > DM needs the ability to account a clone bio's IO to the original > block_device. So add @orig_bdev argument to bio_start_io_acct_time. > > Rename bio_start_io_acct_time to bio_start_io_acct_remapped. > > Also, follow bio_end_io_acct

Re: [dm-devel] [PATCH v2 14/14] dm: move duplicate code in callers of alloc_tio into alloc_tio

2022-02-14 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH v3 05/10] block: add emulation for copy

2022-02-14 Thread Nitesh Shetty
For the devices which does not support copy, copy emulation is added. Copy-emulation is implemented by reading from source ranges into memory and writing to the corresponding destination synchronously. Signed-off-by: Nitesh Shetty Signed-off-by: Vincent Fu --- block/blk-lib.c | 119

Re: [dm-devel] [PATCH V2 00/13] use time_is_xxx() instead of jiffies judgment

2022-02-14 Thread 王擎
  >>On Thu, Feb 10, 2022 at 06:30:23PM -0800, Qing Wang wrote: >> From: Wang Qing >> >> It is better to use time_is_xxx() directly instead of jiffies judgment >> for understanding. > >Hi Wang, > >"judgement" doesn't really make sense as a description to an English >speaker.  The following a

[dm-devel] [PATCH v3 01/10] block: make bio_map_kern() non static

2022-02-14 Thread Nitesh Shetty
From: SelvaKumar S Make bio_map_kern() non static Signed-off-by: SelvaKumar S Signed-off-by: Nitesh Shetty --- block/blk-map.c| 2 +- include/linux/blkdev.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/block/blk-map.c b/block/blk-map.c index

[dm-devel] [PATCH v3 09/10] dm: Enable copy offload for dm-linear target

2022-02-14 Thread Nitesh Shetty
Setting copy_supported flag to enable offload. Signed-off-by: Nitesh Shetty --- drivers/md/dm-linear.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c index 1b97a11d7151..8910728bc8df 100644 --- a/drivers/md/dm-linear.c +++

[dm-devel] [PATCH v3 04/10] block: Introduce a new ioctl for copy

2022-02-14 Thread Nitesh Shetty
Add new BLKCOPY ioctl that offloads copying of one or more sources ranges to one or more destination in a device. COPY ioctl accepts a 'copy_range' structure that contains no of range, a reserved field , followed by an array of ranges. Each source range is represented by 'range_entry' that

[dm-devel] [PATCH v3 06/10] nvme: add copy offload support

2022-02-14 Thread Nitesh Shetty
From: SelvaKumar S For device supporting native copy, nvme driver receives read and write request with BLK_COPY op flags. For read request the nvme driver populates the payload with source information. For write request the driver converts it to nvme copy command using the source information in

[dm-devel] [PATCH v3 07/10] nvmet: add copy command support for bdev and file ns

2022-02-14 Thread Nitesh Shetty
From: Arnav Dawn Add support for handling target command on target. For bdev-ns we call into blkdev_issue_copy, which the block layer completes by a offloaded copy request to backend bdev or by emulating the request. For file-ns we call vfs_copy_file_range to service our request. Currently

[dm-devel] [PATCH v3 10/10] dm kcopyd: use copy offload support

2022-02-14 Thread Nitesh Shetty
From: SelvaKumar S Introduce copy_jobs to use copy-offload, if supported by underlying devices otherwise fall back to existing method. run_copy_jobs() calls block layer copy offload API, if both source and destination request queue are same and support copy offload. On successful completion,

[dm-devel] [PATCH v3 02/10] block: Introduce queue limits for copy-offload support

2022-02-14 Thread Nitesh Shetty
Add device limits as sysfs entries, - copy_offload (RW) - copy_max_bytes (RW) - copy_max_hw_bytes (RO) - copy_max_range_bytes (RW) - copy_max_range_hw_bytes (RO) - copy_max_nr_ranges (RW) - copy_max_nr_ranges_hw (RO) Above limits help to

[dm-devel] [PATCH v3 00/10] Add Copy offload support

2022-02-14 Thread Nitesh Shetty
The patch series covers the points discussed in November 2021 virtual call [LSF/MM/BFP TOPIC] Storage: Copy Offload[0]. We have covered the Initial agreed requirements in this patchset. Patchset borrows Mikulas's token based approach for 2 bdev implementation. Overall series supports – 1. Driver

[dm-devel] [PATCH v3 08/10] dm: Add support for copy offload.

2022-02-14 Thread Nitesh Shetty
Before enabling copy for dm target, check if underlying devices and dm target support copy. Avoid split happening inside dm target. Fail early if the request needs split, currently splitting copy request is not supported. Signed-off-by: Nitesh Shetty --- drivers/md/dm-table.c | 45

Re: [dm-devel] [PATCH V2 5/13] hid: use time_is_after_jiffies() instead of jiffies judgment

2022-02-14 Thread srinivas pandruvada
On Thu, 2022-02-10 at 18:30 -0800, Qing Wang wrote: > From: Wang Qing > > It is better to use time_xxx() directly instead of jiffies judgment > for understanding. > > Signed-off-by: Wang Qing Acked-by: Srinivas Pandruvada > --- >  drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- >  1 file changed,