Re: [dm-devel] [PATCH] udev-md-raid-assembly.rules: skip if DM_UDEV_DISABLE_OTHER_RULES_FLAG

2022-02-28 Thread Peter Rajnoha
Hi! On Mon 28 Feb 2022 23:28, Xiao Ni wrote: > Hi Peter > > In rhel, we have a rhel only udev rule that checks > DM_UDEV_DISABLE_OTHER_RULES_FLAG. Maybe it's the reason why you don't > notice this. Besides DM_UDEV_DISABLE_OTHER_RULES_FLAG, it still checks > other flags. > Ah yes, that's it!

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-02-28 Thread Giovanni Cabiddu
On Mon, Feb 28, 2022 at 11:25:49AM -0800, Linus Torvalds wrote: > On Mon, Feb 28, 2022 at 12:18 AM Kyle Sanderson wrote: > > > > Makes sense - this kernel driver has been destroying users for many > > years. I'm disappointed that this critical bricking failure isn't > > searchable for others. >

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-02-28 Thread Kyle Sanderson
> The issue is that the implementations of aead and skcipher in the QAT driver > are not properly supporting requests with the CRYPTO_TFM_REQ_MAY_BACKLOG flag > set. Thanks Giovanni. Joel (from Intel) reached out to me out of band to try and sell me further on QAT but wasn't able to follow-up

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-02-28 Thread Herbert Xu
On Mon, Feb 28, 2022 at 05:12:20PM -0800, Linus Torvalds wrote: > > It sounds like it was incidental and almost accidental that it fixed > that thing, and nobody realized it should perhaps be also moved to > stable. Yes this was incidental. The patch in question fixes an issue in OOM situations

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 3:26 PM Herbert Xu wrote: > > Indeed, qat has been disabled for dm-crypt since > > commit b8aa7dc5c7535f9abfca4bceb0ade9ee10cf5f54 > Author: Mikulas Patocka > Date: Thu Jul 9 23:20:41 2020 -0700 > > crypto: drivers - set the flag CRYPTO_ALG_ALLOCATES_MEMORY > > So

Re: [dm-devel] [PATCH V3 0/3] block/dm: support bio polling

2022-02-28 Thread Ming Lei
On Mon, Feb 28, 2022 at 11:27:44AM -0500, Mike Snitzer wrote: > On Wed, Jun 23 2021 at 3:40P -0400, > Ming Lei wrote: > > > Hello Guys, > > > > Based on Christoph's bio based polling model[1], implement DM bio polling > > with one very simple approach. > > > > Patch 1 adds helper of

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-02-28 Thread Herbert Xu
On Mon, Feb 28, 2022 at 08:39:11PM +, Giovanni Cabiddu wrote: > > The dm-crypt + QAT use-case is already disabled since kernel 5.10 due to > a different issue. Indeed, qat has been disabled for dm-crypt since commit b8aa7dc5c7535f9abfca4bceb0ade9ee10cf5f54 Author: Mikulas Patocka Date:

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-28 Thread Benjamin Marzinski
On Tue, Feb 22, 2022 at 10:16:35PM +, Ritika Srivastava wrote: > Ben, > > Thank you for reviewing this. > > On 2/22/22, 11:32 AM, "Benjamin Marzinski" wrote: > >> And I'm trying to figure out why you want to create /dev/loop0p1 if you >> already have /dev/mapper/loop0p1? The

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-02-28 Thread Milan Broz
On 28/02/2022 20:25, Linus Torvalds wrote: On Mon, Feb 28, 2022 at 12:18 AM Kyle Sanderson wrote: Makes sense - this kernel driver has been destroying users for many years. I'm disappointed that this critical bricking failure isn't searchable for others. It does sound like we should just

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-02-28 Thread Greg KH
On Mon, Feb 28, 2022 at 08:39:11PM +, Giovanni Cabiddu wrote: > On Mon, Feb 28, 2022 at 11:25:49AM -0800, Linus Torvalds wrote: > > On Mon, Feb 28, 2022 at 12:18 AM Kyle Sanderson wrote: > > > > > > Makes sense - this kernel driver has been destroying users for many > > > years. I'm

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-02-28 Thread Linus Torvalds
On Mon, Feb 28, 2022 at 12:18 AM Kyle Sanderson wrote: > > Makes sense - this kernel driver has been destroying users for many > years. I'm disappointed that this critical bricking failure isn't > searchable for others. It does sound like we should just disable that driver entirely until it is

Re: [dm-devel] [PATCH V3 0/3] block/dm: support bio polling

2022-02-28 Thread Mike Snitzer
On Wed, Jun 23 2021 at 3:40P -0400, Ming Lei wrote: > Hello Guys, > > Based on Christoph's bio based polling model[1], implement DM bio polling > with one very simple approach. > > Patch 1 adds helper of blk_queue_poll(). > > Patch 2 adds .bio_poll() callback to block_device_operations, so

Re: [dm-devel] Revert "dm space maps: don't reset space map allocation cursor when committing"

2022-02-28 Thread Mike Snitzer
On Mon, Feb 28 2022 at 9:13P -0500, Luo Meng wrote: > This reverts commit 5faafc77f7de69147d1e818026b9a0cbf036a7b2. > > This commit 5faafc77f7de ("dm space maps: don't reset space map allocation > cursor when committing") change the way to find free block. > > But when use ramdisk(not support

Re: [dm-devel] [PATCH] udev-md-raid-assembly.rules: skip if DM_UDEV_DISABLE_OTHER_RULES_FLAG

2022-02-28 Thread Xiao Ni
On Thu, Feb 17, 2022 at 9:10 PM Peter Rajnoha wrote: > > On Thu 17 Feb 2022 11:58, Martin Wilck wrote: > > On Thu, 2022-02-17 at 09:09 +1100, NeilBrown wrote: > > > On Thu, 17 Feb 2022, mwi...@suse.com wrote: > > > > From: Martin Wilck > > > > > > > > device-mapper sets the flag