Re: [dm-devel] [PATCH v5 11/18] nvme: Add pr_ops read_keys support

2023-03-28 Thread Mike Christie
On 3/28/23 2:11 AM, kernel test robot wrote: > Hi Mike, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on mkp-scsi/for-next] > [also build test WARNING on jejb-scsi/for-next axboe-block/for-next > linus/master v6.3-rc4 next-20230328

Re: [dm-devel] [PATCH v5 01/18] block: Add PR callouts for read keys and reservation

2023-03-28 Thread Mike Christie
On 3/28/23 11:36 AM, Mike Snitzer wrote: > On Fri, Mar 24 2023 at 2:17P -0400, > Mike Christie wrote: > >> Add callouts for reading keys and reservations. This allows LIO to support >> the READ_KEYS and READ_RESERVATION commands and will allow dm-multipath >> to optimize it's error handling so i

Re: [dm-devel] [PATCH v5 01/18] block: Add PR callouts for read keys and reservation

2023-03-28 Thread Mike Snitzer
On Fri, Mar 24 2023 at 2:17P -0400, Mike Christie wrote: > Add callouts for reading keys and reservations. This allows LIO to support > the READ_KEYS and READ_RESERVATION commands and will allow dm-multipath > to optimize it's error handling so it can check if it's getting an error > because the

Re: [dm-devel] dm-clone: Request option to send discard to source device during hydration

2023-03-28 Thread Mike Snitzer
On Mon, Mar 27 2023 at 4:24P -0400, Gwendal Grignou wrote: > On ChromeOS, we are working on migrating file backed loopback devices > to thinpool logical volumes using dm-clone on the Chromebook local > SSD. > Dm-clone hydration workflow is a great fit but the design of dm-clone > assumes a read-

Re: [dm-devel] [PATCH] libmultipath: use directio checker for LIO targets

2023-03-28 Thread Benjamin Marzinski
On Thu, Mar 23, 2023 at 09:53:58PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > LIO always responds with GOOD status to TUR. Thus TUR is > not useful as path checker for LIO targets. > > Fixes https://github.com/opensvc/multipath-tools/issues/54 > > Signed-off-by: Martin Wilck Review

Re: [dm-devel] [RFC PATCH 0/3] sg3_utils: udev rules: restrict use of ambiguous device IDs

2023-03-28 Thread Martin Wilck
On Mon, 2023-03-27 at 19:58 -0400, Douglas Gilbert wrote: > > Lets see if anything happens. Applied as sg3_utils revision 1019 and > pushed to https://github.com/doug-gilbert/sg3_utilsĀ . > > Didn't see any effect on an Ubuntu 22.10 when sg3_utils deb package > built and installed. No sign of 00-s

Re: [dm-devel] [PATCH v5 11/18] nvme: Add pr_ops read_keys support

2023-03-28 Thread kernel test robot
Hi Mike, I love your patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on jejb-scsi/for-next axboe-block/for-next linus/master v6.3-rc4 next-20230328] [If your patch is applied to the wrong git tree, kindly drop us a note. And when