Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-06-02 Thread Dave Chinner
On Fri, Jun 02, 2023 at 11:44:27AM -0700, Sarthak Kukreti wrote: > On Tue, May 30, 2023 at 8:28 AM Mike Snitzer wrote: > > > > On Tue, May 30 2023 at 10:55P -0400, > > Joe Thornber wrote: > > > > > On Tue, May 30, 2023 at 3:02 PM Mike Snitzer wrote: > > > > > > > > > > > Also Joe, for you

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-06-02 Thread Mike Snitzer
On Fri, Jun 02 2023 at 2:44P -0400, Sarthak Kukreti wrote: > On Tue, May 30, 2023 at 8:28 AM Mike Snitzer wrote: > > > > On Tue, May 30 2023 at 10:55P -0400, > > Joe Thornber wrote: > > > > > On Tue, May 30, 2023 at 3:02 PM Mike Snitzer wrote: > > > > > > > > > > > Also Joe, for you proposed

Re: [dm-devel] [PATCH 0/5] Support kdump with LUKS encryption by reusing LUKS volume key

2023-06-02 Thread Eric Biggers
On Thu, Jun 01, 2023 at 03:24:39PM +0800, Coiby Xu wrote: > [PATCH 0/5] Support kdump with LUKS encryption by reusing LUKS volume key The kernel has no concept of LUKS at all. It provides dm-crypt, which LUKS happens to use. But LUKS is a userspace concept. This is a kernel patchset, so why

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-06-02 Thread Sarthak Kukreti
On Tue, May 30, 2023 at 8:28 AM Mike Snitzer wrote: > > On Tue, May 30 2023 at 10:55P -0400, > Joe Thornber wrote: > > > On Tue, May 30, 2023 at 3:02 PM Mike Snitzer wrote: > > > > > > > > Also Joe, for you proposed dm-thinp design where you distinquish > > > between "provision" and "reserve":

Re: [dm-devel] [PATCH 5/5] libmultipath: add "detect_pgpolicy" config option

2023-06-02 Thread Martin Wilck
On Thu, 2023-06-01 at 13:17 -0500, Benjamin Marzinski wrote: > On Wed, May 31, 2023 at 03:44:58PM +, Martin Wilck wrote: > > On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote: > > > This allows configuations to use "group_by_tpg" if alua is > > > autodetected > > > and another policy

Re: [dm-devel] [PATCH 3/3] block: fail writes to read-only devices

2023-06-02 Thread Linus Torvalds
On Fri, Jun 2, 2023 at 11:41 AM Christoph Hellwig wrote: > > Except the whole make a thing readonly just for fun is the corner case. > DM does it, and we have a sysfs file to allow it. But the usual > case is that a block device has been read-only all the time, or has > been force to be

Re: [dm-devel] [PATCH 3/3] block: fail writes to read-only devices

2023-06-02 Thread Christoph Hellwig
[quoting your reply out of order, because I think it makes sense that way] On Thu, Jun 01, 2023 at 09:02:25PM -0400, Linus Torvalds wrote: > So honestly, that whole test for > > + if (op_is_write(bio_op(bio)) && bio_sectors(bio) && > + bdev_read_only(bdev)) { > > may look

Re: [dm-devel] [PATCH 4/5] multipath-tools tests: add tests for group_by_tpg policy

2023-06-02 Thread Martin Wilck
On Thu, 2023-06-01 at 12:51 -0500, Benjamin Marzinski wrote: > On Wed, May 31, 2023 at 03:30:02PM +, Martin Wilck wrote: > > On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote: > > > Signed-off-by: Benjamin Marzinski > > > > I wonder if it might make sense for group_by_tpg to mock