Re: [dm-devel] [PATCH -next v2 3/6] md: add a mutex to synchronize idle and frozen in action_store()

2023-06-15 Thread Song Liu
On Tue, Jun 13, 2023 at 6:15 PM Yu Kuai wrote: > > Hi, > > 在 2023/06/13 22:43, Xiao Ni 写道: > > > > 在 2023/5/29 下午9:20, Yu Kuai 写道: > >> From: Yu Kuai > >> > >> Currently, for idle and frozen, action_store will hold 'reconfig_mutex' > >> and call md_reap_sync_thread() to stop sync thread, however,

Re: [dm-devel] [git pull] device mapper fixes for 6.4-rc7

2023-06-15 Thread pr-tracker-bot
The pull request you sent on Thu, 15 Jun 2023 13:56:30 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-6.4/dm-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0e306952d7151afdaa16e9acf280a739d1fe7b29 Thank you! -- De

[dm-devel] [PATCH] multipath-tools: fix syntax and spelling errors

2023-06-15 Thread Xose Vazquez Perez
Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 8 multipathd/main.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/multipath/multipath.conf.5 b/multipat

[dm-devel] [git pull] device mapper fixes for 6.4-rc7

2023-06-15 Thread Mike Snitzer
Hi Linus, The following changes since commit f1fcbaa18b28dec10281551dfe6ed3a3ed80e3d6: Linux 6.4-rc2 (2023-05-14 12:51:40 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git tags/for-6.4/dm-fixes for you to fetch changes

Re: [dm-devel] multipath-tools: Debian patches

2023-06-15 Thread Martin Wilck
On Wed, 2023-06-07 at 17:12 +0200, Chris Hofstaedtler wrote: > > > On rpm-based distributions,package management will be able to > > figure > > out this kind of (in)compatibility, albeit in a more coarse-grained > > way > > (e.g. the multipathd package requires > > libmpathpersist.so.0(LIBMPATHPER

Re: [dm-devel] [PATCH V3 10/11] multipathd: reload map if the path groups are out of order

2023-06-15 Thread Martin Wilck
On Wed, 2023-06-07 at 15:47 -0500, Benjamin Marzinski wrote: > need_switch_pathgroup() only checks if the currently used pathgroup > is > not the highest priority pathgroup. If it isn't, all multipathd does > is > instruct the kernel to switch to the correct pathgroup.  However, the > kernel treats

Re: [dm-devel] [PATCH V3 06/11] libmultipath: add "detect_pgpolicy_use_tpg" config option

2023-06-15 Thread Martin Wilck
On Wed, 2023-06-07 at 15:47 -0500, Benjamin Marzinski wrote: > If this and "detect_pgpolicy" are both selected and ALUA is > autodetected, the multipath device will use the "group_by_tpg" policy > instead of the "group_by_prio" policy. > > Signed-off-by: Benjamin Marzinski Reviewed-by: Martin Wi

Re: [dm-devel] [PATCH V3 01/11] libmultipath: add group_by_tpg path_grouping_policy

2023-06-15 Thread Martin Wilck
On Wed, 2023-06-07 at 15:47 -0500, Benjamin Marzinski wrote: > When we group paths by prio and the priority changes, paths can end > up > temporarily in the wrong path groups.  This usually happens when some > paths are down, so their priority can't be updated. To avoid this for > ALUA paths, group

Re: [dm-devel] [PATCH] multipath-tools: fix spelling

2023-06-15 Thread Martin Wilck
On Thu, 2023-06-15 at 17:36 +0200, Xose Vazquez Perez wrote: > libmultipath/structs_vec.c:270: mulitpath ==> multipath > libmultipath/libmultipath.version:36: overriden ==> overridden > libmpathutil/libmpathutil.version:36: overriden ==> overridden > > SUMMARY: > mulitpath 1 > overriden 2

[dm-devel] [PATCH] multipath-tools: fix spelling

2023-06-15 Thread Xose Vazquez Perez
libmultipath/structs_vec.c:270: mulitpath ==> multipath libmultipath/libmultipath.version:36: overriden ==> overridden libmpathutil/libmpathutil.version:36: overriden ==> overridden SUMMARY: mulitpath 1 overriden 2 Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-D

Re: [dm-devel] [PATCH -next v2 4/6] md: refactor idle/frozen_sync_thread() to fix deadlock

2023-06-15 Thread Xiao Ni
On Thu, Jun 15, 2023 at 5:05 PM Yu Kuai wrote: > > Hi, > > 在 2023/06/15 16:17, Xiao Ni 写道: > >> Thanks for the example. I can understand the usage of it. It's the > >> side effect that removes the mutex protection for idle_sync_thread. > >> > >> There is a problem. New sync thread is started in md

Re: [dm-devel] [PATCH -next v2 4/6] md: refactor idle/frozen_sync_thread() to fix deadlock

2023-06-15 Thread Yu Kuai
Hi, 在 2023/06/15 16:17, Xiao Ni 写道: Thanks for the example. I can understand the usage of it. It's the side effect that removes the mutex protection for idle_sync_thread. There is a problem. New sync thread is started in md_check_recovery. After your patch, md_reap_sync_thread is called in md_c

Re: [dm-devel] [PATCH -next v2 4/6] md: refactor idle/frozen_sync_thread() to fix deadlock

2023-06-15 Thread Xiao Ni
On Thu, Jun 15, 2023 at 4:01 PM Xiao Ni wrote: > > On Thu, Jun 15, 2023 at 9:29 AM Yu Kuai wrote: > > > > Hi, > > > > 在 2023/06/14 17:08, Xiao Ni 写道: > > > On Wed, Jun 14, 2023 at 4:29 PM Yu Kuai wrote: > > >> > > >> Hi, > > >> > > >> 在 2023/06/14 15:57, Xiao Ni 写道: > > >>> On Wed, Jun 14, 2023

Re: [dm-devel] [PATCH -next v2 4/6] md: refactor idle/frozen_sync_thread() to fix deadlock

2023-06-15 Thread Xiao Ni
On Thu, Jun 15, 2023 at 9:29 AM Yu Kuai wrote: > > Hi, > > 在 2023/06/14 17:08, Xiao Ni 写道: > > On Wed, Jun 14, 2023 at 4:29 PM Yu Kuai wrote: > >> > >> Hi, > >> > >> 在 2023/06/14 15:57, Xiao Ni 写道: > >>> On Wed, Jun 14, 2023 at 3:38 PM Yu Kuai wrote: > > Hi, > > 在 2023/06/14

[dm-devel] [PATCH] dm log: remove unneeded variable

2023-06-15 Thread baomingtong001
fix the following coccicheck warning: drivers/md/dm-snap-transient.c:94:14-16: Unneeded variable: "sz". Return "0". drivers/md/dm-ps-historical-service-time.c:240:14-16: Unneeded variable: "sz". Return "0". Signed-off-by: Mingtong Bao --- drivers/md/dm-log.c | 6 ++ 1 file changed, 2 in

[dm-devel] [bug report] dm flakey: clone pages on write bio before corrupting them

2023-06-15 Thread Dan Carpenter
Hello Mikulas Patocka, The patch 90ed93c305a0: "dm flakey: clone pages on write bio before corrupting them" from May 1, 2023, leads to the following Smatch static checker warning: drivers/md/dm.c:1157 clone_endio() warn: passing freed memory 'ti' drivers/md/dm.c 1105 static v

[dm-devel] [PATCH] dm: remove unneeded variable from ql_status()

2023-06-15 Thread baomingtong001
fix the following coccicheck warning: drivers/md/dm-ps-queue-length.c:90:14-16: Unneeded variable: "sz". Return "0". Signed-off-by: Mingtong Bao --- drivers/md/dm-ps-queue-length.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/dm-ps-queue-length.c b/driver