Re: [dm-devel] [PATCH] block: flush the disk cache on BLKFLSBUF

2023-06-26 Thread Christoph Hellwig
On Mon, Jun 26, 2023 at 10:25:28PM +0200, Mikulas Patocka wrote: > The BLKFLSBUF ioctl doesn't send the flush bio to the block device, thus > flushed data may be lurking in the disk cache and they may not be really > flushed to the stable storage. > > This patch adds the call to

Re: [dm-devel] [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-26 Thread Guenter Roeck
On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- $ git grep cdrom_release Documentation/cdrom/cdrom-standard.rst: cdrom_release, /* release */ Documentation/cdrom/cdrom-standard.rst:the door, should be left over to the

[dm-devel] [PATCH] block: flush the disk cache on BLKFLSBUF

2023-06-26 Thread Mikulas Patocka
The BLKFLSBUF ioctl doesn't send the flush bio to the block device, thus flushed data may be lurking in the disk cache and they may not be really flushed to the stable storage. This patch adds the call to blkdev_issue_flush to blkdev_flushbuf. Signed-off-by: Mikulas Patocka --- block/ioctl.c

Re: [dm-devel] Fwd: dm-writecache - Unexpected Data After Host Crash

2023-06-26 Thread Mikulas Patocka
On Thu, 15 Jun 2023, Marc Smith wrote: > Hi Mikulas, > > Apologies for the direct message, but I noticed it seems you're the > original author of dm-writecache and wanted to get your thoughts on > the issue described below... I've been going through the code in > dm-writecache.c and trying to

Re: [dm-devel] [PATCH 08/24] init: pass root_device_name explicitly

2023-06-26 Thread Guenter Roeck
On 6/26/23 00:53, Christoph Hellwig wrote: On Fri, Jun 23, 2023 at 05:08:59PM -0700, Guenter Roeck wrote: Hi, On Wed, May 31, 2023 at 02:55:19PM +0200, Christoph Hellwig wrote: Instead of declaring root_device_name as a global variable pass it as an argument to the functions using it.

[dm-devel] [PATCH] dm: get rid of workarounds for __vmalloc and kvmalloc

2023-06-26 Thread Mikulas Patocka
In the past, the function __vmalloc didn't respect the GFP flags - it allocated memory with the provided gfp flags, but it allocated page tables with GFP_KERNEL. This was fixed in the commit 451769ebb7e792c3404db53b3c2a422990de654e, so the memalloc_noio_save / memalloc_noio_restore workaround is

[dm-devel] [PATCH 3/3] dm-integrity: scale down the recalculate buffer if memory allocation fails

2023-06-26 Thread Mikulas Patocka
If memory allocation fails, try to reduce the size of the recalculate buffer and continue with the smaller buffer. Signed-off-by: Mikulas Patocka --- drivers/md/dm-integrity.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) Index: linux-2.6/drivers/md/dm-integrity.c

[dm-devel] [PATCH 2/3] dm-integrity: allocate recalculate buffer only when needed

2023-06-26 Thread Mikulas Patocka
dm-integrity preallocated 8MiB buffer for recalculating in the constructor and freed it in the destructor. This wastes memory when the user has many dm-integrity devices. This patch changes dm-integrity so that it allocates the buffer in the begining of the function integrity_recalc and free it

[dm-devel] [PATCH 1/3] dm-integrity: reduce vmalloc space footprint on 32-bit architectures

2023-06-26 Thread Mikulas Patocka
It was reported that dm-integrity runs out of vmalloc space on 32-bit architectures. On x86, there is only 128MiB vmalloc space and dm-integrity consumes it quickly because it has 64MiB journal and 8MiB recalculate buffer. This patch reduces the size of the journal to 4MiB and the size of the

Re: [dm-devel] [PATCH] multipath-tools Consider making 'smart' the default

2023-06-26 Thread Martin Wilck
On Tue, 2023-03-21 at 09:57 +0100, Martin Wilck wrote: > On Mon, 2023-03-20 at 14:41 -0500, Benjamin Marzinski wrote: > > On Mon, Mar 20, 2023 at 03:18:37PM +0100, Martin Wilck wrote: > > > On Thu, 2023-03-16 at 14:47 -0700, Brian Bunker wrote: > > > > > > > > > Subsequent volumes after the

Re: [dm-devel] [PATCH] multipath-tools build: accept KBUILD_BUILD_TIMESTAMP from env

2023-06-26 Thread Martin Wilck
On Tue, 2023-06-06 at 19:12 +0200, Chris Hofstaedtler wrote: > From: Chris Lamb > > It would appear KBUILD_BUILD_TIMESTAMP is meant to be used the same > way as in > the linux kernel build. For linux, builders are supposed to set > KBUILD_BUILD_TIMESTAMP in the environment if they want a stable

Re: [dm-devel] [Question] Can DATA_DEV_BLOCK_SIZE_MIN_SECTORS be set to a smaller value

2023-06-26 Thread Zdenek Kabelac
Dne 26. 06. 23 v 14:19 Li Lingfeng napsal(a): Hello: Recently, I found that the used space of the thin-pool will keep rising if I use dm-thin as follow: // create dm-thin dmsetup create linear_1 --table "0 2097152 linear /dev/sdc 0" dmsetup create linear_2 --table "0 16777216  linear

[dm-devel] [Question] Can DATA_DEV_BLOCK_SIZE_MIN_SECTORS be set to a smaller value

2023-06-26 Thread Li Lingfeng
Hello: Recently, I found that the used space of the thin-pool will keep rising if I use dm-thin as follow: // create dm-thin dmsetup create linear_1 --table "0 2097152 linear /dev/sdc 0" dmsetup create linear_2 --table "0 16777216  linear /dev/sdc 2097153" dd if=/dev/zero

Re: [dm-devel] [PATCH v2] dm-crypt: reexport sysfs of kcryptd workqueue

2023-06-26 Thread yangerkun
Hi, Mike, Sorry for the noise. This patch has been proposed for a long time. I wonder does there any suggestion for the patch. Looking forward to your reply! Thanks, Yang Erkun. 在 2023/3/25 9:01, yangerkun 写道: Ping... 在 2023/3/1 11:29, yangerkun 写道: From: yangerkun Once there is a

Re: [dm-devel] [PATCH 08/24] init: pass root_device_name explicitly

2023-06-26 Thread Christoph Hellwig
On Fri, Jun 23, 2023 at 05:08:59PM -0700, Guenter Roeck wrote: > Hi, > > On Wed, May 31, 2023 at 02:55:19PM +0200, Christoph Hellwig wrote: > > Instead of declaring root_device_name as a global variable pass it as an > > argument to the functions using it. > > > > Signed-off-by: Christoph