On 7/19/2023 1:21 PM, Mikulas Patocka wrote:
> This patch implements REQ_OP_WRITE_ZEROES on brd. Write zeroes will free
> the pages just like discard, but the difference is that it writes zeroes
> to the preceding and following page if the range is not aligned on page
> boundary.
>
>
On 5/12/23 06:00, Christoph Hellwig wrote:
> Hell no. This is just obsfucation. We can look into actually exposing
> REQ_OP_FLUSH at the bio level, but not something like this.
>
and that's why I made it RFC, thanks for the can you please elaborate
on "exposing REQ_OP_FLUSH at the bio level" ?
-by: Chaitanya Kulkarni
---
block/blk-flush.c | 2 +-
drivers/md/bcache/request.c | 3 +--
drivers/md/dm-bufio.c | 2 +-
drivers/md/dm-integrity.c | 2 +-
drivers/md/dm-log.c | 2 +-
drivers/md/dm-raid1.c | 2 +-
drivers/md/dm
On 4/25/23 10:24, Mike Snitzer wrote:
> On Tue, Apr 25 2023 at 8:15P -0400,
> Shin'ichiro Kawasaki wrote:
>
>> On Apr 25, 2023 / 16:22, Yu Kuai wrote:
>>> Hi,
>>>
>>> 在 2023/01/12 9:05, Shinichiro Kawasaki 写道:
Hello Yu, thanks for the patch. I think it is good to have this test case
On 4/11/23 01:10, Anuj Gupta wrote:
> From: Nitesh Shetty
>
> Add support for handling target command on target.
what is target command ?
command that you have added is :nvme_cmd_copy
> For bdev-ns we call into blkdev_issue_copy, which the block layer
> completes by a offloaded copy request to
On 4/11/23 01:10, Anuj Gupta wrote:
> From: Nitesh Shetty
>
> Implementaion is based on existing read and write infrastructure.
> copy_max_bytes: A new configfs and module parameter is introduced, which
> can be used to set hardware/driver supported maximum copy limit.
>
> Suggested-by: Damien Le
like LIO, do not know about controller/host IDs,
> the callout just returns the registered keys which is required by the SCSI
> PR in READ KEYS command.
>
> Signed-off-by: Mike Christie
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
--
dm-devel mailing
g
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
This patch renames BLK_STS_NEXUS so it better reflects this type of
> use.
>
> Signed-off-by: Mike Christie
> Acked-by: Stefan Haberland
> Reviewed-by: Bart Van Assche
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
--
dm-devel mailing list
dm-devel@redhat.com
https:/
: Mike Christie
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
T_RESERVE_IN commands.
>
> Signed-off-by: Mike Christie
> Reviewed-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
need, but for a
> userspace interface we may want something like SCSI's READ_FULL_STATUS and
> NVMe's report reservation commands. Those are overkill for dm/LIO and
> READ_FULL_STATUS is sometimes broken for SCSI devices.
>
> Signed-off-by: Mike Christie
> ---
Looks good.
Review
to a pr_ops pr_held_reservation struct.
>
> Signed-off-by: Mike Christie
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
t have a strong preference. Bart had the suggestion to keep the
> switch and drop the default so the compiler can warn us if new types
> are added. This seemed like a nice benefit so I went that way.
>
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
--
dm-devel mailing list
dm-devel@redhat.co
On 2/24/2023 9:44 AM, Mike Christie wrote:
> Move the code that checks for multipath support and sends the pr command
> to a new helper so it can be used by the reservation report support added
> in the next patches.
>
> Signed-off-by: Mike Christie
> ---
> drivers/nvme/host/pr.c | 23
atchset which adds
> support for the reservation report command.
>
> Signed-off-by: Mike Christie
> Reviewed-by: Keith Busch
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 1/18/23 18:20, Shinichiro Kawasaki wrote:
> CC+: Mike, dm-devel,
>
> Hi Chaitanya, thanks for bringing this up! I definitely want to join and learn
> from the discussions. Here I note my comments about them.
>
> On Jan 18, 2023 / 23:52, Chaitanya Kulkarni wrote:
> [...]
On 1/17/23 14:30, Enrico Granata wrote:
> Hi,
> I am going to add +Jahdiel Alvarez who is also looking into a similar
> issue, and also I would like to hear thoughts of people who may have
> worked with (embedded or otherwise) storage more recently than I have
>
> One thought that Jahdiel and
let's us
> make modifications to the math if needed in one place.
>
> Signed-off-by: Pankaj Raghav
with Bart's comments fixed...
looks good
Reviewed-by: Chaitanya Kulkarni
-ck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 1/6/23 00:33, Pankaj Raghav wrote:
> Remove the superfluous request queue check in bdev_is_zoned() as the
> bdev_get_queue can never return NULL.
>
> Signed-off-by: Pankaj Raghav
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
--
dm-devel mailing list
dm-devel@r
ks good.
Reviewed-by: Chaitanya Kulkarni
-ck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 12/11/22 01:49, Alvaro Karsz wrote:
>> Alvaro could you pls explain the use-case? Christoph has doubts that
>> it's useful. Do you have a device implementing this?
>
> Our HW exposes virtio devices, virtio block included.
> The block device backend can be a eMMC/uSD card.
>
> The HW can
Michael,
On 12/7/22 12:28, Michael S. Tsirkin wrote:
> On Wed, Dec 07, 2022 at 08:31:28AM -0800, Christoph Hellwig wrote:
>> On Wed, Dec 07, 2022 at 05:21:48AM -0500, Michael S. Tsirkin wrote:
>>> Christoph you acked the spec patch adding this to virtio blk:
>>>
>>> Still not a fan of the
On 12/7/22 15:08, Jens Axboe wrote:
> On 12/7/22 3:32?PM, Gulam Mohamed wrote:
>> As per the review comment from Jens Axboe, I am re-sending this patch
>> against "for-6.2/block".
>>
>>
>> Use ktime to change the granularity of IO accounting in block layer from
>> milli-seconds to nano-seconds to
error on i386 and microblaze
>
> Signed-off-by: Gulam Mohamed
> ---
I believe it has no effect on the overall performance, if so I'd
document that.
Based on the quantitative data present in the commit log this
looks good to me, I believe you did audit all drivers and places
in the block layer.
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
Bart,
On 12/6/22 10:43, Bart Van Assche wrote:
> On 12/5/22 08:20, Alvaro Karsz wrote:
>> +/* Get lifetime information struct for each request */
>> +struct virtio_blk_lifetime {
>> + /*
>> + * specifies the percentage of reserved blocks that are consumed.
>> + * optional values
On 12/5/22 12:35, Enrico Granata wrote:
> The original definitions for these fields come from JESD84-B50, which
> is what eMMC storage uses. It has been a while, but I recall UFS doing
> something pretty similar.
> Systems that don't have a well defined notion of durability would just
> not expose
On 12/5/22 10:24, Jens Axboe wrote:
> On 12/5/22 9:20 AM, Alvaro Karsz wrote:
>> Implement the VIRTIO_BLK_F_LIFETIME feature for VirtIO block devices.
>>
>> This commit introduces a new ioctl command, VBLK_LIFETIME.
>>
>> VBLK_LIFETIME ioctl asks for the block device to provide lifetime
>>
On 11/29/22 04:16, Nitesh Shetty wrote:
> On Wed, Nov 23, 2022 at 10:56:23PM +0000, Chaitanya Kulkarni wrote:
>> (+ Shinichiro)
>>
>> On 11/22/22 21:58, Nitesh Shetty wrote:
>>> The patch series covers the points discussed in November 2021 virtual
>>> call [
(+ Shinichiro)
On 11/22/22 21:58, Nitesh Shetty wrote:
> The patch series covers the points discussed in November 2021 virtual
> call [LSF/MM/BFP TOPIC] Storage: Copy Offload [0].
> We have covered the initial agreed requirements in this patchset and
> further additional features suggested by
> +static inline enum pr_type scsi_pr_type_to_block(enum scsi_pr_type type)
> +{
> + switch (type) {
> + case SCSI_PR_WRITE_EXCLUSIVE:
> + return PR_WRITE_EXCLUSIVE;
> + case SCSI_PR_EXCLUSIVE_ACCESS:
> + return PR_EXCLUSIVE_ACCESS;
> + case
On 10/26/22 16:19, Mike Christie wrote:
> LIO is going to want to do the same block to/from SCSI pr types as sd.c
> so this moves the sd_pr_type helper to a new file. The next patch will
> then also add a helper to go from the SCSI value to the block one for use
> with PERSISTENT_RESERVE_IN
On 10/26/22 16:19, Mike Christie wrote:
> Rename sd_pr_command to sd_pr_out_command to match a
> sd_pr_in_command helper added in the next patches.
>
> Signed-off-by: Mike Christie
> Reviewed-by: Christoph Hellwig
> ---
> drivers/scsi/sd.c | 12 ++--
>
Reviewe
On 10/26/22 16:19, Mike Christie wrote:
> Reservation Report support needs to pass in a variable sized buffer, so
> this patch has the pr command helpers take a data length argument.
>
> Signed-off-by: Mike Christie
> Reviewed-by: Christoph Hellwig
> ---
Reviewed-by: Chaita
On 10/26/22 16:19, Mike Christie wrote:
> This patch moves the pr code to it's own file because I'm going to be
> adding more functions and core.c is getting bigger.
>
> Signed-off-by: Mike Christie
> ---
>
Thanks a lot for doing this ...
Reviewed-by: Chaitanya Kulkarni
> /*
> @@ -300,23 +303,34 @@ out:
>
> void brd_do_discard(struct brd_device *brd, struct bio *bio)
> {
> - sector_t sector, len, front_pad;
> + bool zero_padding;
> + sector_t sector, len, front_pad, end_pad;
>
> if (unlikely(!discard)) {
>
Christoph Hellwig
>
> ---
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
plan on tacking one of the conversions so we can mark it
> off the list.
>
> [1]
> https://docs.google.com/spreadsheets/d/1i_ckZ10p90bH_CkxD2bYNi05S2Qz84E2OFPv8zq__0w/edit#gid=1679714357
>
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 10/15/21 06:26, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Kees Cook
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat
On 10/15/21 06:26, Christoph Hellwig wrote:
> Use the equivalent block layer helper instead.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Kees Cook
> Acked-by: Coly Li
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-deve
On 10/15/21 06:26, Christoph Hellwig wrote:
> Add a helper to return the size of sb->s_bdev in sb->s_blocksize_bits
> based unites. Note that SECTOR_SHIFT has to be open coded due to
> include dependency issues for now, but I have a plan to sort that out
> eventually.
>
> Signed-off-by:
On 10/15/21 06:26, Christoph Hellwig wrote:
> Use the proper helper to read the block device size and remove two
> cargo culted checks that can't be false.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Jan Kara
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel
On 10/15/21 06:26, Christoph Hellwig wrote:
> Use the sb_bdev_nr_blocks helper instead of open coding it.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Kees Cook
> Reviewed-by: Jan Kara
> Acked-by: Theodore Ts'o
>
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 10/15/21 06:26, Christoph Hellwig wrote:
> Ensure these are always available for inlines in the various block layer
> headers.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat
On 10/12/2021 10:10 PM, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 10/12/2021 10:10 PM, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
>
> Signed-off-by: Christoph Hellwig
> ---
Bodo's comment is good for the code reliability.
Either way, looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing l
On 10/12/2021 10:10 PM, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 10/12/2021 10:10 PM, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 10/12/2021 10:10 PM, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 10/12/2021 10:10 PM, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
Javier,
>
> Hi all,
>
> Since we are not going to be able to talk about this at LSF/MM, a few of
> us thought about holding a dedicated virtual discussion about Copy
> Offload. I believe we can use Chaitanya's thread as a start. Given the
> current state of the current patches, I would propose
t;struct blk_crypto_fallback_keyslot".
>
> Reviewed-by: Christoph Hellwig
> Signed-off-by: Eric Biggers
Looks good, it might be useful to mention this patch doesn't change
any functionality, not a hard requirement though.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 8/4/2021 2:56 AM, Christoph Hellwig wrote:
Add a helper to get the virtual address for a bvec. This avoids that
all callers need to know about the page + offset representation.
Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
-ck
--
dm-devel mailing
On 8/4/2021 2:56 AM, Christoph Hellwig wrote:
Use the bvec_virt helper to clean up the bio integrity processing a
little bit.
Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
-ck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com
On 5/10/21 17:15, Chaitanya Kulkarni wrote:
> Hi,
>
> * Background :-
> ---
>
> Copy offload is a feature that allows file-systems or storage devices
> to be instructed to copy files/logical blocks without re
On 6/8/21 09:09, Christoph Hellwig wrote:
> Use memcpy_from_bvec instead of open coding the logic.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 6/8/21 09:08, Christoph Hellwig wrote:
> Use memcpy_to_bvec instead of opencoding the logic.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 6/8/21 09:07, Christoph Hellwig wrote:
> Add helpers to perform common memory operation on a bvec.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 6/8/21 09:07, Christoph Hellwig wrote:
> Use memzero_bvec to zero each segment in the bio instead of manually
> mapping and zeroing the data.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redh
On 6/8/21 09:06, Christoph Hellwig wrote:
> Add a helper to call kmap_local_page on a bvec. There is no need for
> an unmap helper given that kunmap_local accept any address in the mapped
> page.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 6/8/21 09:06, Christoph Hellwig wrote:
> Fix the include guards to match the file naming.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 6/8/21 09:06, Christoph Hellwig wrote:
> No need for kmap_atomic here.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 6/1/21 23:56, Christoph Hellwig wrote:
> Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and
> request_queue allocation.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/block/null_blk/main.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff
On 6/1/21 23:56, Christoph Hellwig wrote:
> Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and
> request_queue allocation.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redh
itialization
calls and respective error handling in each blk-mq based drivers.
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 6/1/21 23:55, Christoph Hellwig wrote:
> All users are gone now.
>
> Signed-off-by: Christoph Hellwig
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
is introduced for block devices
> natively supporting reset all operations. blkdev_zone_mgmt() is modified
> to call either function to execute an all zone reset request.
>
> Signed-off-by: Damien Le Moal
> [hch: split into multiple functions]
> Signed-off-by: Christoph Hellwig
Apart f
On 5/24/21 7:25 PM, Damien Le Moal wrote:
> + sector_t sector = 0;
nit:- I think there is an extra space here after = .
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
y: Hannes Reinecke
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
e if the BIO target zone is sequential.
>
> Signed-off-by: Damien Le Moal
> Reviewed-by: Hannes Reinecke
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On 5/20/21 20:01, Damien Le Moal wrote:
> +static int blkdev_zone_reset_all_emulated(struct block_device *bdev,
> + gfp_t gfp_mask)
> +{
> + struct request_queue *q = bdev_get_queue(bdev);
> + sector_t capacity = get_capacity(bdev->bd_disk);
> +
Sent from my iPhone
> On May 19, 2021, at 12:17 AM, Johannes Thumshirn
> wrote:
>
> On 19/05/2021 04:56, Damien Le Moal wrote:
>> +static inline unsigned int bio_zone_no(struct request_queue *q,
>> + struct bio *bio)
>> +{
>> +return blk_queue_zone_no(q,
Hi,
* Background :-
---
Copy offload is a feature that allows file-systems or storage devices
to be instructed to copy files/logical blocks without requiring
involvement of the local CPU.
With reference to the RISC-V summit
to _not_ retry if it
> is set.
>
> This change runs with the suggestion made here:
> https://lore.kernel.org/linux-nvme/20190813170144.ga10...@lst.de/
>
> Suggested-by: Christoph Hellwig
> Signed-off-by: Mike Snitzer
Looks good.
Reviewed-by: Chaitanya Kulkarni
--
dm-de
On 4/13/21 11:26, Javier González wrote:
>>> I believe there is space for extensions to simple copy. But given the
>>> experience with XCOPY, I can imagine that changes will be incremental,
>>> based on very specific use cases.
>>>
>>> I think getting support upstream and bringing deployed cases
On 4/9/21 17:22, Max Gurtovoy wrote:
> On 2/19/2021 2:45 PM, SelvaKumar S wrote:
>> This patchset tries to add support for TP4065a ("Simple Copy Command"),
>> v2020.05.04 ("Ratified")
>>
>> The Specification can be found in following link.
>>
On 3/15/21 20:18, Ming Lei wrote:
> There has been 3 users, and will be more, so add one such helper.
>
> Signed-off-by: Ming Lei
This looks good to me irrespective of RFC.
Reviewed-by: Chaitanya Kulkarni
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.co
On 2/24/21 10:56, Christoph Hellwig wrote:
> On Wed, Feb 24, 2021 at 09:48:21AM -0700, Jens Axboe wrote:
>> Would make sense to rename blk_get_request() to blk_mq_alloc_request()
>> and then we have API symmetry. The get/put don't make sense when there
>> are no references involved.
>>
>> But it's
The function blk_put_request() is just a wrapper to
blk_mq_free_request(), remove the unnecessary wrapper.
Any feedback is welcome on this RFC.
Signed-off-by: Chaitanya Kulkarni
---
block/blk-core.c | 6 --
block/blk-merge.c | 2 +-
block/bsg-lib.c
Signed-off-by: Chaitanya Kulkarni
---
fs/jfs/jfs_metapage.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c
index 3fa09d9a0b94..c7be3a2773bf 100644
--- a/fs/jfs/jfs_metapage.c
+++ b/fs/jfs/jfs_metapage.c
@@ -495,13 +495,11
Signed-off-by: Chaitanya Kulkarni
---
fs/xfs/xfs_bio_io.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/xfs/xfs_bio_io.c b/fs/xfs/xfs_bio_io.c
index e2148f2d5d6b..e4644f22ebe6 100644
--- a/fs/xfs/xfs_bio_io.c
+++ b/fs/xfs/xfs_bio_io.c
@@ -26,11 +26,8
Signed-off-by: Chaitanya Kulkarni
---
fs/iomap/direct-io.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index ea1e8f696076..f6c557a1bd25 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -189,15 +189,13
Signed-off-by: Chaitanya Kulkarni
---
fs/block_dev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 9d4b1a884d76..f3e3247894d7 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -367,6 +367,8 @@ __blkdev_direct_IO(struct kiocb
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/dm-zoned-metadata.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
index e6252f48a49c..fa0ee732c6e9 100644
--- a/drivers/md/dm-zoned-metadata.c
+++ b
Signed-off-by: Chaitanya Kulkarni
---
mm/page_io.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/mm/page_io.c b/mm/page_io.c
index 25b321489703..7579485ccb5e 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -342,7 +342,7 @@ int __swap_writepage(struct page *page
Signed-off-by: Chaitanya Kulkarni
---
fs/jfs/jfs_logmgr.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 4481f3e33a3f..bb25737d52f6 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -2121,16 +2121,14 @@ static
Signed-off-by: Chaitanya Kulkarni
---
fs/buffer.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index 32647d2011df..fcbea667fa04 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -3023,12 +3023,16 @@ static int submit_bh_wbc(int op
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/dm-zoned-metadata.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
index fa0ee732c6e9..5b5ed5fce2ed 100644
--- a/drivers/md/dm-zoned-metadata.c
+++ b
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/drbd/drbd_receiver.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/block/drbd/drbd_receiver.c
b/drivers/block/drbd/drbd_receiver.c
index 09c86ef3f0fd..e1cd3427b28b 100644
--- a/drivers/block/drbd
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/drbd/drbd_receiver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block/drbd/drbd_receiver.c
b/drivers/block/drbd/drbd_receiver.c
index e1cd3427b28b..b86bbf725cbd 100644
--- a/drivers/block/drbd
to
the blk_next_bio() to reduce the duplication.
In the next patch we introduce bio_new(), this prepration patch allows
us to call it inside blk_next_bio().
Signed-off-by: Chaitanya Kulkarni
---
block/blk-lib.c | 36 +++-
block/blk-zoned.c | 4 +---
block/blk.h | 5
Signed-off-by: Chaitanya Kulkarni
---
drivers/target/target_core_iblock.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/target/target_core_iblock.c
b/drivers/target/target_core_iblock.c
index 8ed93fd205c7..f1264918aee1 100644
--- a/drivers/target
Signed-off-by: Chaitanya Kulkarni
---
fs/iomap/direct-io.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index f6c557a1bd25..0737192f7e5c 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -267,9 +267,8
Signed-off-by: Chaitanya Kulkarni
---
kernel/power/swap.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/kernel/power/swap.c b/kernel/power/swap.c
index c73f2e295167..e92e36c053a6 100644
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -271,13 +271,12 @@ static
On 1/27/21 11:21 PM, Damien Le Moal wrote:
On 2021/01/28 16:12, Chaitanya Kulkarni wrote:
Introduce bio_new() helper and use it in blk-lib.c to allocate and
initialize various non-optional or semi-optional members of the bio
along with bio allocation done with bio_alloc(). Here we also calmp
Signed-off-by: Chaitanya Kulkarni
---
fs/iomap/buffered-io.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 16a1e82e3aeb..08d119b62cf5 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
Signed-off-by: Chaitanya Kulkarni
---
fs/hfsplus/wrapper.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
index 0350dc7821bf..8341ee6c9b31 100644
--- a/fs/hfsplus/wrapper.c
+++ b/fs/hfsplus/wrapper.c
@@ -64,10 +64,7 @@ int
Signed-off-by: Chaitanya Kulkarni
---
fs/zonefs/super.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index ab68e27bb322..620d67965a22 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c
@@ -661,6 +661,7 @@ static const struct
Signed-off-by: Chaitanya Kulkarni
---
fs/xfs/xfs_buf.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index f8400bbd6473..3ff6235e4f94 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -1507,12 +1507,10 @@ xfs_buf_ioapply_map
Signed-off-by: Chaitanya Kulkarni
---
fs/mpage.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/fs/mpage.c b/fs/mpage.c
index 830e6cc2a9e7..01725126e81f 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -68,25 +68,21 @@ static struct bio *mpage_bio_submit(int
1 - 100 of 201 matches
Mail list logo
