ementation details. Please see:
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.19=c06dfd124d46df9c482fbd1319b5fe19bcb1a110
looks good to me. thanks for the fixups.
--
Gabriel Krisman Bertazi
--
dm-devel mailing list
dm-devel@redhat.com
https
/HST-BIO-MPATH/
[1] https://lore.kernel.org/lkml/85tv0am9de@collabora.com/T/
Signed-off-by: Gabriel Krisman Bertazi
Acked-by: Gabriel Krisman Bertazi
---
drivers/md/dm-mpath.c | 16 ++--
drivers/md/dm-path-selector.h | 13 +
drivers
Khazhismel Kumykov writes:
> mixing sched_clock() and ktime_get_ns() will give bad results, don't do
> it
>
> Fixes: 2613eab11996 ("dm mpath: add Historical Service Time Path Selector")
> Signed-off-by: Khazhismel Kumykov
Looks good.
Reviewed-by: Gabriel Krisman Berta
Xose Vazquez Perez writes:
> Just minimal info.
>
> Cc: Khazhismel Kumykov
> Cc: Gabriel Krisman Bertazi
> Cc: Martin Wilck
> Cc: Benjamin Marzinski
> Cc: Christophe Varoqui
> Cc: DM-DEVEL ML
> Signed-off-by: Xose Vazquez Perez
Reviewed-by: Gabriel Krisman Be
Mike Snitzer writes:
> On Wed, Jul 08 2020 at 2:26pm -0400,
> Gabriel Krisman Bertazi wrote:
>
>> If I understand it correctly, considering the deadlock you shared, this
>> doesn't solve the entire issue. For instance, kobject_uevent_env on the
>> GFP_NOIO thread
I think this patch is an improvement as we shouldn't be using
GFP_IO in this path to begin with, so please add:
Reviewed-by: Gabriel Krisman Bertazi
> This is the observed deadlock:
>
> iSCSI-write
> holding: rx_queue_mutex
> waiting: uevent_sock_mutex
>
Xose Vazquez Perez writes:
> Cc: Khazhismel Kumykov
> Cc: Gabriel Krisman Bertazi
> Cc: Martin Wilck
> Cc: Benjamin Marzinski
> Cc: Christophe Varoqui
> Cc: DM-DEVEL ML
> Signed-off-by: Xose Vazquez Perez
> ---
> multipath/multipath.conf.5 | 4
>
Xose Vazquez Perez writes:
> On 5/11/20 6:39 PM, Gabriel Krisman Bertazi wrote:
>
>> This fourth version of HST applies the suggestion from Mikulas Patocka
>> to do the ktime_get_ns inside the mpath map_bio instead of generic
>> device-mapper code. This means that s
thanks for the information. I get started on it.
--
Gabriel Krisman Bertazi
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Mike Snitzer writes:
> On Mon, May 11 2020 at 12:39pm -0400,
> Gabriel Krisman Bertazi wrote:
>
>> Hi,
>>
>> This fourth version of HST applies the suggestion from Mikulas Patocka
>> to do the ktime_get_ns inside the mpath map_bio instead of generic
g
requests. To account for low volume situations where number of
inflights would be zero, the last finish time of each path is factored
in.
Signed-off-by: Khazhismel Kumykov
Co-developed-by: Gabriel Krisman Bertazi
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/Kconfig
: https://www.redhat.com/archives/dm-devel/2020-April/msg00176.html
Gabriel Krisman Bertazi (1):
md: mpath: Pass IO start time to path selector
Khazhismel Kumykov (1):
md: mpath: Add Historical Service Time Path Selector
drivers/md/Kconfig | 11 +
drivers/md/Makefile
HST is going to need this information to perform path prediction. For
request-based mpath, we use the struct request io_start_time, while for
bio based, use the DM layer start_time.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/dm-mpath.c | 12 +---
drivers/md/dm-path
HST is going to need this information to perform path prediction. For
request-based mpath, we use the struct request io_start_time, while for
bio based, use the DM layer start_time.
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/dm-mpath.c | 9 ++---
drivers/md/dm-path
Gabriel Krisman Bertazi writes:
> Hi Mike,
>
> Please find an updated version of HST integrating the change you
> requested to also support BIO based multipath. I hope you don't mind me
> folding the function you implemented into patch 2. If you prefer, I can
> integrate a
and usage
patterns and with artificial benchmarks using fio.
Gabriel Krisman Bertazi (1):
md: mpath: Pass IO start time to path selector
Khazhismel Kumykov (1):
md: mpath: Add Historical Service Time Path Selector
drivers/md/Kconfig | 11 +
drivers/md/Makefile
g
requests. To account for low volume situations where number of
inflights would be zero, the last finish time of each path is factored
in.
Signed-off-by: Khazhismel Kumykov
Co-developed-by: Gabriel Krisman Bertazi
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/Kconfig
: Khazhismel Kumykov
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/dm-mpath.c | 25 +++--
drivers/md/dm-path-selector.h | 1 +
drivers/md/dm.c | 10 ++
include/linux/device-mapper.h | 2 ++
4 files changed, 28 insertions(+), 10 deletions(-)
diff
5/0xe0
[ 82.454466] do_syscall_64+0x4e/0x210
[ 82.454828] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[...]
[ 82.462501] ---[ end trace bb39975e9cf45daa ]---
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/dm-mpath.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/md/dm-mpa
g
requests. To account for low volume situations where number of
inflights would be zero, the last finish time of each path is factored
in.
Signed-off-by: Khazhismel Kumykov
Co-developed-by: Gabriel Krisman Bertazi
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/Kconfig
I sent today, so
it was worth it.
Gabriel Krisman Bertazi (2):
md: multipath: Encapsulate parameters passed to selectors
md: multipath: Pass io_start_time to the path selector
Khazhismel Kumykov (1):
md: Add Historical Service Time Path Selector
drivers/md/Kconfig
will require start_time already.
Cc: Khazhismel Kumykov
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/dm-mpath.c | 25 -
drivers/md/dm-path-selector.h | 8 ++--
drivers/md/dm-queue-length.c | 4 ++--
drivers/md/dm-service-time.c | 8
4 files
bio level DM.
I will update the patches, do a quick round of tests with BIO based and
send a v2.
Thanks a lot,
--
Gabriel Krisman Bertazi
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
g
requests. To account for low volume situations where number of
inflights would be zero, the last finish time of each path is factored
in.
Signed-off-by: Khazhismel Kumykov
Co-developed-by: Gabriel Krisman Bertazi
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/Kconfig
Hello,
This small series implements a new path selector that leverages
historical path IO time in order to estimate future path performance.
Implementation details can be found on Patch 2.
This selector yields better path distribution, considering the mean
deviation from the calculated optimal
-by: Gabriel Krisman Bertazi
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/dm-mpath.c | 12 ++--
drivers/md/dm-path-selector.h | 6 ++
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 2bc18c9c3abc
ll_fastpath at bdbc34a2
Co-developed-by: Khazhismel Kumykov
Signed-off-by: Khazhismel Kumykov
Signed-off-by: Tahsin Erdogan
Co-developed-by: Gabriel Krisman Bertazi
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/dm-bufio.c | 31 +--
1 file changed, 13
Mike Snitzer writes:
> On Mon, Jan 13 2020 at 5:41P -0500,
> Gabriel Krisman Bertazi wrote:
>
>> From: Anatol Pomazau
>>
>> Add a configurable timeout mechanism to disable queue_if_no_path without
>> assistance from multipathd. In reality, this reimplemen
of configuring per table
- Simplify code
Co-developed-by: Frank Mayhar
Signed-off-by: Frank Mayhar
Co-developed-by: Bharath Ravi
Signed-off-by: Bharath Ravi
Co-developed-by: Khazhismel Kumykov
Signed-off-by: Khazhismel Kumykov
Signed-off-by: Anatol Pomazau
Co-developed-by: Gabriel Krisman Bertazi
-by: Frank Mayhar
Co-developed-by: Bharath Ravi
Signed-off-by: Bharath Ravi
Co-developed-by: Khazhismel Kumykov
Signed-off-by: Khazhismel Kumykov
Signed-off-by: Anatol Pomazau
Co-developed-by: Gabriel Krisman Bertazi
Signed-off-by: Gabriel Krisman Bertazi
---
drivers/md/dm-mpath.c | 96
30 matches
Mail list logo
