Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-07 Thread Guoqing Jiang
On 11/4/22 9:40 PM, Mikulas Patocka wrote: On Fri, 4 Nov 2022, Guoqing Jiang wrote: On 11/3/22 11:20 PM, Mikulas Patocka wrote: On Thu, 3 Nov 2022, Mikulas Patocka wrote: BTW, is the mempool_free from endio -> dec_count -> complete_io? And io which caused the crash is from

Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-06 Thread Guoqing Jiang
On 11/4/22 7:10 PM, Zdenek Kabelac wrote: Dne 04. 11. 22 v 2:23 Guoqing Jiang napsal(a): On 11/3/22 10:46 PM, Heming Zhao wrote: On 11/3/22 11:47 AM, Guoqing Jiang wrote: Hi, On 11/3/22 12:27 AM, Mikulas Patocka wrote: Hi There's a crash in the test shell/lvchange-rebuild-raid.sh when

Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-03 Thread Guoqing Jiang
On 11/3/22 11:20 PM, Mikulas Patocka wrote: On Thu, 3 Nov 2022, Mikulas Patocka wrote: BTW, is the mempool_free from endio -> dec_count -> complete_io? And io which caused the crash is from dm_io -> async_io / sync_io  -> dispatch_io, seems dm-raid1 can call it instead of dm-raid, so I

Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-03 Thread Guoqing Jiang
On 11/3/22 10:46 PM, Heming Zhao wrote: On 11/3/22 11:47 AM, Guoqing Jiang wrote: Hi, On 11/3/22 12:27 AM, Mikulas Patocka wrote: Hi There's a crash in the test shell/lvchange-rebuild-raid.sh when running the lvm testsuite. It can be reproduced by running "make check_local T=shell/lvc

Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-03 Thread Guoqing Jiang
On 11/3/22 11:47 AM, Guoqing Jiang wrote: [   78.491429] [   78.491640]  clone_endio+0xf4/0x1c0 [dm_mod] [   78.492072]  clone_endio+0xf4/0x1c0 [dm_mod] The clone_endio belongs to "clone" target_type. Hmm, could be the "clone_endio" from dm.c instead

Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-02 Thread Guoqing Jiang
Hi, On 11/3/22 12:27 AM, Mikulas Patocka wrote: Hi There's a crash in the test shell/lvchange-rebuild-raid.sh when running the lvm testsuite. It can be reproduced by running "make check_local T=shell/lvchange-rebuild-raid.sh" in a loop. I have problem to run the cmd (not sure what I missed),

Re: [dm-devel] [PATCH AUTOSEL 5.18 35/68] md: don't unregister sync_thread with reconfig_mutex held

2022-06-08 Thread Guoqing Jiang
Hi, Pls drop this one from all stable kernel versions since it caused regression. Thanks, Guoqing -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 3/7] rnbd: drop WRITE_SAME support

2022-02-09 Thread Guoqing Jiang
On 2/9/22 5:13 PM, Jinpu Wang wrote: --- a/drivers/block/rnbd/rnbd-srv.c +++ b/drivers/block/rnbd/rnbd-srv.c @@ -548,8 +548,7 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp, cpu_to_le16(rnbd_dev_get_max_segs(rnbd_dev)); rsp->max_hw_sectors =

Re: [dm-devel] [PATCH 3/7] rnbd: drop WRITE_SAME support

2022-02-09 Thread Guoqing Jiang
On 2/9/22 4:28 PM, Christoph Hellwig wrote: REQ_OP_WRITE_SAME was only ever submitted by the legacy Linux zeroing code, which has switched to use REQ_OP_WRITE_ZEROES long before rnbd was even merged. Signed-off-by: Christoph Hellwig --- drivers/block/rnbd/rnbd-clt.c | 7 ++-

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-12-14 Thread Guoqing Jiang
On 12/14/21 5:31 PM, Donald Buczek wrote:   -void md_reap_sync_thread(struct mddev *mddev) +void md_reap_sync_thread(struct mddev *mddev, bool reconfig_mutex_held)   {   struct md_rdev *rdev;   sector_t old_dev_sectors = mddev->dev_sectors;   bool is_reshaped = false;     /*

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-12-13 Thread Guoqing Jiang
On 12/10/21 10:16 PM, Donald Buczek wrote: Dear Guoqing, On 13.02.21 01:49, Guoqing Jiang wrote: Unregister sync_thread doesn't need to hold reconfig_mutex since it doesn't reconfigure array. And it could cause deadlock problem for raid5 as follows: 1. process A tried to reap sync thread

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-12-09 Thread Guoqing Jiang
On 12/9/21 8:57 PM, Donald Buczek wrote: [Update Guoqing’s email address] On 15.02.21 12:07, Paul Menzel wrote: [+cc Donald] Am 13.02.21 um 01:49 schrieb Guoqing Jiang: Unregister sync_thread doesn't need to hold reconfig_mutex since it doesn't reconfigure array. And it could cause

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-12-08 Thread Guoqing Jiang
On 12/9/21 12:35 AM, Heinz Mauelshagen wrote: NACK, see details below. On Wed, Dec 8, 2021 at 3:24 PM Guoqing Jiang <mailto:guoqing.ji...@linux.dev>> wrote: On 12/1/21 1:27 AM, Paul Menzel wrote: > >>>>>>> diff --git a/drivers/md

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-12-08 Thread Guoqing Jiang
On 12/1/21 1:27 AM, Paul Menzel wrote: diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index cab12b2..0c4cbba 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -3668,7 +3668,7 @@ static int raid_message(struct dm_target *ti, unsigned int argc, char **argv,     if

Re: [dm-devel] [PATCH] block: move some macros to blkdev.h

2021-08-11 Thread Guoqing Jiang
Gentle ping ... On 7/21/21 10:53 AM, Guoqing Jiang wrote: From: Guoqing Jiang Move them (PAGE_SECTORS_SHIFT, PAGE_SECTORS and SECTOR_MASK) to the generic header file to remove redundancy. Signed-off-by: Guoqing Jiang --- drivers/block/brd.c | 3 --- drivers/block/null_blk

[dm-devel] [PATCH] block: move some macros to blkdev.h

2021-07-20 Thread Guoqing Jiang
From: Guoqing Jiang Move them (PAGE_SECTORS_SHIFT, PAGE_SECTORS and SECTOR_MASK) to the generic header file to remove redundancy. Signed-off-by: Guoqing Jiang --- drivers/block/brd.c | 3 --- drivers/block/null_blk/main.c | 4 drivers/md/bcache/util.h | 2 -- include/linux

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-02-25 Thread Guoqing Jiang
On 2/24/21 10:09, Song Liu wrote: On Mon, Feb 15, 2021 at 3:08 AM Paul Menzel wrote: [+cc Donald] Am 13.02.21 um 01:49 schrieb Guoqing Jiang: Unregister sync_thread doesn't need to hold reconfig_mutex since it doesn't reconfigure array. And it could cause deadlock problem for raid5

[dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-02-17 Thread Guoqing Jiang
: https://lore.kernel.org/linux-raid/5ed54ffc-ce82-bf66-4eff-390cb23bc...@molgen.mpg.de/T/#t And add one parameter to md_reap_sync_thread since it could be called by dm-raid which doesn't hold reconfig_mutex. Reported-and-tested-by: Donald Buczek Signed-off-by: Guoqing Jiang --- V2: 1. add one

Re: [dm-devel] misc bio allocation cleanups

2021-02-01 Thread Guoqing Jiang
Hi Christoph, I tried with latest for-5.12/block branch, and got below issue when trying to create raid1 array. [ 80.605832] BUG: kernel NULL pointer dereference, address: 0018 [ 80.606159] #PF: supervisor read access in kernel mode [ 80.606159] #PF: error_code(0x) -

Re: [dm-devel] [PATCH v2 1/2] md raid0/linear: Introduce new array state 'broken'

2019-08-22 Thread Guoqing Jiang
Hi, On 8/16/19 3:40 PM, Guilherme G. Piccoli wrote: +static bool linear_is_missing_dev(struct mddev *mddev) +{ + struct md_rdev *rdev; + static int already_missing; + int def_disks, work_disks = 0; + + def_disks = mddev->raid_disks; + rdev_for_each(rdev, mddev) +