[PATCH] checkpatch: Add kmap and kmap_atomic to the deprecated list

2022-08-13 Thread ira . weiny
From: Ira Weiny kmap() and kmap_atomic() are being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation

Re: [PATCH v2 1/2] dax: Introduce normal and recovery dax operation modes

2021-11-08 Thread Ira Weiny
On Mon, Nov 08, 2021 at 09:02:29PM +, Jane Chu wrote: > On 11/6/2021 9:48 AM, Dan Williams wrote: > > On Fri, Nov 5, 2021 at 6:17 PM Jane Chu wrote: > >> > >> Introduce DAX_OP_NORMAL and DAX_OP_RECOVERY operation modes to > >> {dax_direct_access, dax_copy_from_iter, dax_copy_to_iter}. > >>

Re: [PATCH 03/11] dax: simplify the dax_device <-> gendisk association

2021-10-28 Thread Ira Weiny
On Mon, Oct 18, 2021 at 06:40:46AM +0200, Christoph Hellwig wrote: > Replace the dax_host_hash with an xarray indexed by the pointer value > of the gendisk, and require explicitl calls from the block drivers that > want to associate their gendisk with a dax_device. > > Signed-off-by: Christoph

Re: [dm-devel] [PATCH 01/18] mm: add a kunmap_local_dirty helper

2021-06-28 Thread Ira Weiny
On Fri, Jun 18, 2021 at 11:37:28AM +0800, Herbert Xu wrote: > On Thu, Jun 17, 2021 at 08:01:57PM -0700, Ira Weiny wrote: > > > > > + flush_kernel_dcache_page(__page); \ > > > > Is this required on 32bit systems? Why is kunmap_flush_on_unmap

Re: [dm-devel] [PATCH 01/18] mm: add a kunmap_local_dirty helper

2021-06-18 Thread Ira Weiny
On Tue, Jun 15, 2021 at 03:24:39PM +0200, Christoph Hellwig wrote: > Add a helper that calls flush_kernel_dcache_page before unmapping the > local mapping. flush_kernel_dcache_page is required for all pages > potentially mapped into userspace that were written to using kmap*, > so having a helper

Re: [dm-devel] [PATCH 09/16] ps3disk: use memcpy_{from,to}_bvec

2021-06-14 Thread Ira Weiny
On Fri, Jun 11, 2021 at 08:53:38AM +0200, Christoph Hellwig wrote: > On Tue, Jun 08, 2021 at 06:48:22PM -0700, Ira Weiny wrote: > > I'm still not 100% sure that these flushes are needed but the are not > > no-ops on > > every arch. Would it be best to preserve them aft

Re: [dm-devel] switch the block layer to use kmap_local_page

2021-06-09 Thread Ira Weiny
ted in a follow > on series. Other than the missing flush_dcache's. For the series. Reviewed-by: Ira Weiny > > Diffstat: > arch/mips/include/asm/mach-rc32434/rb.h |2 - > block/bio-integrity.c | 14 -- > block/bio.c

Re: [dm-devel] [PATCH 14/16] block: use memcpy_from_bvec in __blk_queue_bounce

2021-06-09 Thread Ira Weiny
On Tue, Jun 08, 2021 at 06:06:01PM +0200, Christoph Hellwig wrote: > Rewrite the actual bounce buffering loop in __blk_queue_bounce to that > the memcpy_to_bvec helper can be used to perform the data copies. > > Signed-off-by: Christoph Hellwig > --- > block/bounce.c | 21 +++--

Re: [dm-devel] [PATCH 09/16] ps3disk: use memcpy_{from,to}_bvec

2021-06-09 Thread Ira Weiny
On Tue, Jun 08, 2021 at 06:05:56PM +0200, Christoph Hellwig wrote: > > rq_for_each_segment(bvec, req, iter) { > - unsigned long flags; > - dev_dbg(>sbd.core, "%s:%u: bio %u: %u sectors from %llu\n", > - __func__, __LINE__, i,

Re: [dm-devel] [PATCH] dm/dax: Fix table reference counts

2020-09-21 Thread Ira Weiny
> - bool ret; > > map = dm_get_live_table(md, _idx); > if (!map) > - return false; > + goto out; > > ret = dm_table_supports_dax(map, device_supports_dax, ); > > +out: > dm_put_live_table(md, srcu_idx); Wow that is an o

Re: [dm-devel] [PATCH] dax: fix for do not print error message for non-persistent memory block device

2020-09-04 Thread Ira Weiny
_dev || !bdev_dax_supported()) as the _first_ check in __generic_fsdax_supported()? It seems like the other pr_info's could also be called when DAX is not supported and we probably don't want them to be? Perhaps that should be a follow on patch though. So... As a direct fix to c2affe920b0e Rev