On Thu, 2023-09-21 at 16:09 +0200, Martin Wilck wrote:
> On Wed, 2023-09-20 at 20:41 -0700, Muneendra Kumar wrote:
> > From: Muneendra
> >
> > This patch adds the support to handle FPIN-Li for FC-NVMe.
> > On receiving the FPIN-Li events this patch
rginal path groups.
> The paths which are set to marginal path group will be unset
> on receiving the RSCN events
>
> Signed-off-by: Muneendra
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On Fri, 2023-09-15 at 22:22 +0200, Xose Vazquez Perez wrote:
> Cc: Martin Wilck
> Cc: Benjamin Marzinski
> Cc: Christophe Varoqui
> Cc: DM-DEVEL ML
> Signed-off-by: Xose Vazquez Perez
Reviewed-by: Martin Wilck
(and sorry for being lazy with the speling...)
--
dm-devel
Hello Muneendra,
On Thu, 2023-09-14 at 14:55 -0700, Muneendra Kumar wrote:
> From: Muneendra
>
> This patch adds the support to handle FPIN-Li for FC-NVMe.
> On receiving the FPIN-Li events this patch moves the devices paths
> which are affected due to link integrity to marginal path groups.
>
On Thu, 2023-09-14 at 15:25 +0200, Martin Wilck wrote:
> On Wed, 2023-09-13 at 17:07 -0500, Benjamin Marzinski wrote:
> >
> > I'm not sure if we should assert that the file has changed if we
> > can't stat() it.
>
> I think it's better to (try to) reread the file t
On Wed, 2023-09-13 at 17:07 -0500, Benjamin Marzinski wrote:
> On Mon, Sep 11, 2023 at 06:38:36PM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > Since "libmultipath: keep bindings in memory", we don't re-read the
> > bindings file after e
On Wed, 2023-09-13 at 09:38 -0500, Benjamin Marzinski wrote:
> On Wed, Sep 13, 2023 at 03:53:25PM +0200, Martin Wilck wrote:
> > On Tue, 2023-09-12 at 18:00 -0500, Benjamin Marzinski wrote:
> > > On Mon, Sep 11, 2023 at 06:38:31PM +0200, mwi...@suse.com wrote:
> > >
On Tue, 2023-09-12 at 18:20 -0500, Benjamin Marzinski wrote:
> On Mon, Sep 11, 2023 at 06:38:35PM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > As the assignment of free aliases now relies on the bindings being
> > properly sorted, add some unit tes
On Tue, 2023-09-12 at 18:00 -0500, Benjamin Marzinski wrote:
> On Mon, Sep 11, 2023 at 06:38:31PM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > The current sort order of aliases is alphabetical, which is does
> > not match
> > the actual order of a
On Fri, 2023-09-08 at 12:22 -0500, Benjamin Marzinski wrote:
> On Thu, Sep 07, 2023 at 10:43:27PM +0200, Martin Wilck wrote:
> > Our bindings list is now partially sorted, which is an improvement
> > wrt
> > the previous situation. "missing the gap" is not really an
On Thu, 2023-09-07 at 15:02 -0500, Benjamin Marzinski wrote:
> On Thu, Sep 07, 2023 at 02:14:04PM -0500, Benjamin Marzinski wrote:
> > On Thu, Sep 07, 2023 at 12:30:53PM +0200, Martin Wilck wrote:
> > > On Wed, 2023-09-06 at 17:47 -0500, Benjamin Marzinski wrote:
> > > &
On Thu, 2023-09-07 at 15:33 +0200, Martin Wilck wrote:
> On Thu, 2023-09-07 at 09:24 +0200, Martin Wilck wrote:
> > On Wed, 2023-09-06 at 17:42 -0500, Benjamin Marzinski wrote:
> > > On Fri, Sep 01, 2023 at 08:02:17PM +0200, mwi...@suse.com wrote:
> > >
> > >
On Thu, 2023-09-07 at 09:24 +0200, Martin Wilck wrote:
> On Wed, 2023-09-06 at 17:42 -0500, Benjamin Marzinski wrote:
> > On Fri, Sep 01, 2023 at 08:02:17PM +0200, mwi...@suse.com wrote:
> >
> >
> > Again, unless I'm overlooking something, I don't think we nee
On Wed, 2023-09-06 at 17:47 -0500, Benjamin Marzinski wrote:
> On Fri, Sep 01, 2023 at 08:02:31PM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > Rather than opening the bindings file every time we must retrieve
> > a binding, keep the contents in mem
On Wed, 2023-09-06 at 17:43 -0500, Benjamin Marzinski wrote:
> On Fri, Sep 01, 2023 at 08:02:18PM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > When I read this code, I always get confused. Adding comments to
> > explain the algorithm.
> >
On Wed, 2023-09-06 at 17:43 -0500, Benjamin Marzinski wrote:
> On Fri, Sep 01, 2023 at 08:02:20PM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > Signed-off-by: Martin Wilck
> > ---
> > tests/alias.c | 531
> > +++
On Wed, 2023-09-06 at 17:42 -0500, Benjamin Marzinski wrote:
> On Fri, Sep 01, 2023 at 08:02:17PM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > If the bindings file is changed in a way that multipathd can't
> > handle
> > (e.g. by swapping the alia
Hello Li Xiao Keng,
On Tue, 2023-09-05 at 16:06 +0800, Li Xiao Keng wrote:
> Hello:
> Wmware has PDL test(https://kb.vmware.com/s/article/2004684).
> Is there has same function in multipath-tools? If not, can the
> same function be achieved?
AFAICT, PDL is not a term from the SCSI
On Fri, 2023-09-01 at 18:16 +0200, Martin Wilck wrote:
> On Thu, 2023-08-31 at 16:57 -0500, Benjamin Marzinski wrote:
> > This patchset changes how prioritizers set their timeouts, to make
> > them
> > match how the checker functions work, and also cleans up some min
n suggestions from
> Martin Wilck: Patch [1/4] no longer rechecks the timeout values at
> all
> in the checker loop. Patch [2/4] makes the checker_timeout a path
> variable, following Martin's suggestion. Patch [3/4] roughly
> corresponds
> to patches 2, 3 & 4 of the previous pa
On Fri, 2023-07-28 at 14:05 -0500, Benjamin Marzinski wrote:
> This patchset changes how prioritizers set their timeouts, to make
> them
> match how the checker functions work, and also cleans up some minor
> timeout issues. I did this to make out timeouts consistent, but if
> someone has a good
the
> sysfs value doesn't exist (which likely means that the device is not
> a
> scsi device), then there's no reason to reset the default value,
> since
> that can't have changed.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
Thinking about it, I am not sure i
the multipath device. In that case the IOs could be mis-
> sized.
>
> On reload, this patch re-apply max_sectors_kb value of the multipath
> device on its path devices.
>
> Signed-off-by: Etienne AUJAMES
Looks good to me.
Reviewed-by: Martin Wilck
> ---
> libmultipath
On Wed, 2023-07-05 at 19:18 +0200, Xose Vazquez Perez wrote:
> Mainly; add multipathc info, and info to check man pages
>
> Cc: Martin Wilck
> Cc: Benjamin Marzinski
> Cc: Christophe Varoqui
> Cc: DM-DEVEL ML
> Signed-off-by: Xose Vazquez Perez
Reviewed-by: Marti
On Fri, 2023-06-30 at 17:16 -0500, Benjamin Marzinski wrote:
> On Fri, Jun 30, 2023 at 08:14:07PM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > If the nvme native multipath driver is enabled, blacklist nvme
> > devices
> > for dm-multipath by def
On Tue, 2023-03-21 at 09:57 +0100, Martin Wilck wrote:
> On Mon, 2023-03-20 at 14:41 -0500, Benjamin Marzinski wrote:
> > On Mon, Mar 20, 2023 at 03:18:37PM +0100, Martin Wilck wrote:
> > > On Thu, 2023-03-16 at 14:47 -0700, Brian Bunker wrote:
> > > >
>
On Tue, 2023-06-06 at 19:12 +0200, Chris Hofstaedtler wrote:
> From: Chris Lamb
>
> It would appear KBUILD_BUILD_TIMESTAMP is meant to be used the same
> way as in
> the linux kernel build. For linux, builders are supposed to set
> KBUILD_BUILD_TIMESTAMP in the environment if they want a stable
On Thu, 2023-06-15 at 22:14 +0200, Xose Vazquez Perez wrote:
> Cc: Martin Wilck
> Cc: Benjamin Marzinski
> Cc: Christophe Varoqui
> Cc: DM-DEVEL ML
> Signed-off-by: Xose Vazquez Perez
Reviewed-by: Martin Wilck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.red
On Wed, 2023-06-07 at 17:12 +0200, Chris Hofstaedtler wrote:
>
> > On rpm-based distributions,package management will be able to
> > figure
> > out this kind of (in)compatibility, albeit in a more coarse-grained
> > way
> > (e.g. the multipathd package requires
> >
roup() should also check if the pathgroups are out
> of
> order, and if so, multipathd should reload the map to reorder them
> correctly.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On Wed, 2023-06-07 at 15:47 -0500, Benjamin Marzinski wrote:
> If this and "detect_pgpolicy" are both selected and ALUA is
> autodetected, the multipath device will use the "group_by_tpg" policy
> instead of the "group_by_prio" policy.
>
> Signed-off
> ALUA paths, group them by their target port group instead. The path
> groups chosen by this policy won't always match with those chosen by
> group_by_prio, since it is possible for multiple ALUA target port
> groups to have the same priority.
>
> Signed-off-by: Benjamin Marzins
ath 1
> overriden 2
>
> Cc: Martin Wilck
> Cc: Benjamin Marzinski
> Cc: Christophe Varoqui
> Cc: DM-DEVEL ML
> Signed-off-by: Xose Vazquez Perez
Reviewed-by: Martin Wilck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
eout expires. The checker loop will continue to update them
> correctly while the timeout is going on.
>
> Signed-off-by: Benjamin Marzinski
Nice, thanks for doing this.
Reviewed-by: Martin Wilck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On Tue, 2023-06-06 at 15:13 -0500, Benjamin Marzinski wrote:
> need_switch_pathgroup() only checks if the currently used pathgroup
> is
> not the highest priority pathgroup. If it isn't, all multipathd does
> is
> instruct the kernel to switch to the correct pathgroup. However, the
> kernel
On Tue, 2023-06-06 at 15:13 -0500, Benjamin Marzinski wrote:
> If this and "detect_pgpolicy" are both selected and ALUA is
> autodetected, the multipath device will use the "group_by_tpg" policy
> instead of the "group_by_prio" policy.
>
> Signed-off-by: Benjamin Marzinski
One minor remark
On Tue, 2023-06-06 at 15:13 -0500, Benjamin Marzinski wrote:
> This patchset is a combination of my previous two patchsets
>
> [PATCH 0/5] multipath: Add a group_by_tgp path grouping policy
> [PATCH 0/5] priority and pathgroup switching changes
>
> The first part adds a new path grouping policy
On Tue, 2023-06-06 at 15:13 -0500, Benjamin Marzinski wrote:
> This allows configuations to use "group_by_prio" if alua is
> autodetected
> and another policy if it isn't, so they can work with detect_prio.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wi
On Tue, 2023-06-06 at 15:13 -0500, Benjamin Marzinski wrote:
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On Tue, 2023-06-06 at 15:13 -0500, Benjamin Marzinski wrote:
> Make sure that pathgroups that include paths with a prio_UNDEF
> priority
> are properly sorted.
>
> Reviewed-by: Martin Wilck
> Signed-off-by: Benjamin Marzinski
Nit: typo in subject. I'll fix this when the
On Tue, 2023-06-06 at 15:13 -0500, Benjamin Marzinski wrote:
> When we group paths by prio and the priority changes, paths can end
> up
> temporarily in the wrong path groups. This usually happens when some
> paths are down, so their priority can't be updated. To avoid this for
> ALUA paths,
On Tue, 2023-06-06 at 18:48 +0200, Chris Hofstaedtler wrote:
> Hi,
>
> * Martin Wilck [230606 17:18]:
> > On Mon, 2023-06-05 at 21:59 +0200, Xose Vazquez Perez wrote:
> > > Hi,
>
> > I have no Debian salsa account, so I reply here, trying to reach
> > Ch
On Tue, 2023-06-06 at 12:38 -0500, Benjamin Marzinski wrote:
> On Tue, Jun 06, 2023 at 04:32:13PM +0000, Martin Wilck wrote:
> > On Tue, 2023-06-06 at 10:54 -0500, Benjamin Marzinski wrote:
> > > On Tue, Jun 06, 2023 at 02:55:27PM +, Martin Wilck wrote:
> > > &g
On Wed, 2023-05-24 at 18:21 -0500, Benjamin Marzinski wrote:
> need_switch_pathgroup() only checks if the currently used pathgroup
> is
> not the highest priority pathgroup. If it isn't, all multipathd does
> is
> instruct the kernel to switch to the correct pathgroup. However, the
> kernel
On Tue, 2023-06-06 at 10:54 -0500, Benjamin Marzinski wrote:
> On Tue, Jun 06, 2023 at 02:55:27PM +0000, Martin Wilck wrote:
> > On Mon, 2023-06-05 at 23:42 -0500, Benjamin Marzinski wrote:
> > > On Mon, Jun 05, 2023 at 02:08:07PM -0500, Benjamin Marzinski
> > >
&g
On Mon, 2023-06-05 at 21:59 +0200, Xose Vazquez Perez wrote:
> Hi,
>
I have no Debian salsa account, so I reply here, trying to reach Chris
via email.
>
> A complaint about upstream, "Remove library development files and all
> of libdmmp":
>
On Mon, 2023-06-05 at 23:42 -0500, Benjamin Marzinski wrote:
> On Mon, Jun 05, 2023 at 02:08:07PM -0500, Benjamin Marzinski wrote:
> > On Wed, May 31, 2023 at 04:27:30PM +0000, Martin Wilck wrote:
> > > On Wed, 2023-05-24 at 18:21 -0500, Benjamin Marzinski wrote:
> > &
On Mon, 2023-06-05 at 13:22 -0500, Benjamin Marzinski wrote:
> On Wed, May 31, 2023 at 04:27:25PM +0000, Martin Wilck wrote:
> > On Wed, 2023-05-24 at 18:21 -0500, Benjamin Marzinski wrote:
> > > For multipath devices with path group policies other than
> > > group_by_pr
On Sat, 2023-06-03 at 13:12 +0200, Xose Vazquez Perez wrote:
> On 5/31/23 17:49, Martin Wilck wrote:
>
> > On Wed, 2023-05-31 at 15:57 +0200, Xose Vazquez Perez wrote:
> > > ALUA is needed by Hitachi Global-Active Device (GAD):
> > > https://knowledg
On Wed, 2023-05-31 at 15:57 +0200, Xose Vazquez Perez wrote:
> ALUA is needed by Hitachi Global-Active Device (GAD):
> https://knowledge.hitachivantara.com/Documents/Management_Software/SVOS/8.1/Global-Active_Device/Overview_of_global-active_device
>
> Cc: Matthias Rudolph
> C
On Thu, 2023-06-01 at 13:17 -0500, Benjamin Marzinski wrote:
> On Wed, May 31, 2023 at 03:44:58PM +0000, Martin Wilck wrote:
> > On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote:
> > > This allows configuations to use "group_by_tpg" if alua is
> > >
On Thu, 2023-06-01 at 12:51 -0500, Benjamin Marzinski wrote:
> On Wed, May 31, 2023 at 03:30:02PM +0000, Martin Wilck wrote:
> > On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote:
> > > Signed-off-by: Benjamin Marzinski
> >
> > I wonder if it might make
On Wed, 2023-05-24 at 18:21 -0500, Benjamin Marzinski wrote:
> need_switch_pathgroup() only checks if the currently used pathgroup
> is
> not the highest priority pathgroup. If it isn't, all multipathd does
> is
> instruct the kernel to switch to the correct pathgroup. However, the
> kernel
ultiple pathgroups, since multipath can't be using the wrong
> pathgroup
> if there is one or none.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On Wed, 2023-05-24 at 18:21 -0500, Benjamin Marzinski wrote:
> For multipath devices with path group policies other than
> group_by_prio,
> multipathd wasn't updating all the paths' priorities when calling
> need_switch_pathgroup(), even in cases where it likely was necessary.
> When a path just
On Wed, 2023-05-24 at 18:21 -0500, Benjamin Marzinski wrote:
> Make sure that pathgroups that include paths with a prio_UNDEF
> priority
> are properly sorted.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
> ---
>
ect the
> priority
> of multipath devices with group_by_prio, since all paths in a
> pathgroup
> will have the same priority.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
latest series would add.
>
> Cc: Matthias Rudolph
> Cc: Martin Wilck
> Cc: Benjamin Marzinski
> Cc: Christophe Varoqui
> Cc: DM-DEVEL ML
> Signed-off-by: Xose Vazquez Perez
> ---
> libmultipath/hwtable.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deleti
On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote:
> This patchset is adds a new path grouping policy that can be used
> with
> ALUA devices. The goal is to avoid the temporary incorrect path
> groupings that can happen when paths change priorities.
>
Thanks a lot for doing this. It
On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote:
> This allows configuations to use "group_by_tpg" if alua is
> autodetected
> and another policy if it isn't, so they can work with detect_prio.
This is a bit confusing. We might have introduced this kind of
autodetection without
On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote:
> Signed-off-by: Benjamin Marzinski
I wonder if it might make sense for group_by_tpg to mock calls to
getprio (assigning the prio from the path's TPG ID) rather than calling
set_priority() directly.
> ---
> tests/pgpolicy.c | 201
>
On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote:
> copying the value into a passed in buffer doesn't help any of the
> callers of this function. It's just wasted work.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
> ---
> libmultipath
On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote:
> When we group paths by prio and the priority changes, paths can end
> up
> temporarily in the wrong path groups. This usually happens when some
> paths are down, so their priority can't be updated. To avoid this for
> ALUA paths,
On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote:
> Make it possible to easily check a path's target port group.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
> ---
> libmultipath/print.c | 9 +
> 1 file changed, 9 insertions(
On Mon, 2023-05-22 at 13:49 +0300, Dmitry V. Levin wrote:
> On Mon, May 22, 2023 at 12:19:04PM +0200, Martin Wilck wrote:
> > On Sat, 2023-05-20 at 01:33 +0300, Dmitry V. Levin wrote:
> > > Fix the following warnings reported by udevadm verify:
> > >
> >
On Sat, 2023-05-20 at 01:33 +0300, Dmitry V. Levin wrote:
> Fix the following warnings reported by udevadm verify:
>
> multipath/11-dm-mpath.rules:18 Whitespace after comma is expected.
> multipath/11-dm-mpath.rules:73 Whitespace after comma is expected.
> multipath/11-dm-mpath.rules:73
On Fri, 2023-03-31 at 08:47 -0500, Benjamin Marzinski wrote:
> On Fri, Mar 31, 2023 at 10:28:35AM +0200, mwi...@suse.com wrote:
> > From: Martin Wilck
> >
> > When we set the check to something other than TUR, we need
> > to disable checker detection, too.
> >
On Mon, 2023-03-27 at 19:58 -0400, Douglas Gilbert wrote:
>
> Lets see if anything happens. Applied as sg3_utils revision 1019 and
> pushed to https://github.com/doug-gilbert/sg3_utils .
>
> Didn't see any effect on an Ubuntu 22.10 when sg3_utils deb package
> built and installed. No sign of
escriptor type 7 (MD5) for completeness.
Signed-off-by: Brian Bunker
Signed-off-by: Martin Wilck
---
libmultipath/discovery.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index 3a5ba17..6865cd9 100644
--- a/libmultipath/dis
ts'
> /bin/sh: line 1: -pipe: command not found
> make[1]: *** [Makefile:115: libmultipath.so.0] Error 127
> make[1]: *** Waiting for unfinished jobs
> ```
>
> Signed-off-by: Sam James
Reviewed-by: Martin Wilck
Thanks!
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
Xose, Ben,
when this gets a Reviewed-by, I'd prepare a new submission to
Christophe (unless someone objects).
Martin
On Mon, 2023-03-20 at 16:55 +0100, mwi...@suse.com wrote:
> From: Martin Wilck
>
> Some generated .d files were not correctly included, and not
> removed with &qu
ble set to the WWID of the maybe device that this
> uevent
> is for. This means that all devices with no WWID will end up
> appearing
> to have the same WWID as the maybe device, causing multipath to
> incorrectly claim it.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
On Mon, 2023-03-20 at 15:37 -0500, Benjamin Marzinski wrote:
> >
> > I have to say I don't quite understand why we read from the
> > environment
> > at all if the libudev call fails. This was coded before I joined
> > the
> > project, so perhaps you can clarify it. Why do we expect the
> >
On Mon, 2023-03-20 at 14:41 -0500, Benjamin Marzinski wrote:
> On Mon, Mar 20, 2023 at 03:18:37PM +0100, Martin Wilck wrote:
> > On Thu, 2023-03-16 at 14:47 -0700, Brian Bunker wrote:
> > >
> > > Subsequent volumes after the first one are discovered via unit
> >
On Wed, 2023-03-15 at 17:01 -0500, Benjamin Marzinski wrote:
> On Wed, Mar 15, 2023 at 06:02:09PM +0100, Xose Vazquez Perez wrote:
> > Cc: Martin Wilck
> > Cc: Benjamin Marzinski
> > Cc: Christophe Varoqui
> > Cc: DM-DEVEL ML
> > Signed-off-by: Xose Vazquez P
On Thu, 2023-02-09 at 11:28 -0600, Benjamin Marzinski wrote:
> Currently, whenever getting the uid_attribute from the udev database
> fails, multipath will try to get it from the environment variables.
> This
> normally isn't a problem, since either multipath -u is getting called
> from a uevent
On Thu, 2023-03-16 at 14:47 -0700, Brian Bunker wrote:
> As a target vendor, it is nice to be able control initiator
> behavior from the target without relying on user intervention
> on the initiator. There could be a very large number of initiators
> at a site.
>
> When ACLs are first added for
On Thu, 2023-03-09 at 14:11 -0800, Brian Bunker wrote:
>
> > On Mar 9, 2023, at 1:50 PM, Martin Wilck wrote:
> >
> > Brian,
> >
> > On Thu, 2023-03-09 at 13:40 -0800, Brian Bunker wrote:
> > >
> > > Martin,
> > >
&
Brian,
On Thu, 2023-03-09 at 13:40 -0800, Brian Bunker wrote:
>
> Martin,
>
> Sorry I bounce between kernel versions a lot since most of the
> problems which find their way to us are released Linux versions
> whose kernels are quite a bit older than upstream.I got a chance
> to try the proposed
On Tue, 2023-03-07 at 16:49 -0600, Benjamin Marzinski wrote:
> If a the tur checker creates a new context because an old thread is
> still running, but the old thread finishes before the checker drops
> the old context, the checker should reset nr_timeouts to 0, since
> the old thread did complete
Brian,
On Tue, 2023-03-07 at 11:41 -0800, Brian Bunker wrote:
>
> > On Mar 7, 2023, at 2:31 AM, Martin Wilck wrote:
> >
> > On Mon, 2023-03-06 at 13:04 -0600, Benjamin Marzinski wrote:
> > > On Mon, Mar 06, 2023 at 12:46:50PM +0100, Martin Wilck wrote:
> > &
On Mon, 2023-03-06 at 13:04 -0600, Benjamin Marzinski wrote:
> On Mon, Mar 06, 2023 at 12:46:50PM +0100, Martin Wilck wrote:
> > Hi Brian,
> >
> > On Sat, 2023-03-04 at 12:49 -0800, Brian Bunker wrote:
> > > >
> > > The checking for standby is 14
On Sat, 2023-03-04 at 12:49 -0800, Brian Bunker wrote:
> On Mar 3, 2023, at 12:41 PM, Martin Wilck wrote:
> >
> > On Fri, 2023-03-03 at 09:18 -0800, Brian Bunker wrote:
> > > >
> > > Hello Martin,
> > >
> > > Doesn’t "someth
Hi Brian,
On Sat, 2023-03-04 at 12:49 -0800, Brian Bunker wrote:
> >
> The checking for standby is 14 years old, and says that TUR returns
> a unit attention when the path is in standby. I am not sure why that
> wouldn’t be handled by this code above: I would think there should be
> just one
On Fri, 2023-03-03 at 09:18 -0800, Brian Bunker wrote:
> >
> Hello Martin,
>
> Doesn’t "something in between failed and up” semantics describe ALUA
> state transitioning pretty well?
transitioning - yes. standby - ??
Martin
--
dm-devel mailing list
dm-devel@redhat.com
icit ALUA. Is that what we want to
see for TRANSITIONING state?
But yes, this change is in the spirit of 5da642f ("Return 'ghost' state
when port is in standby").
CC'ing Ben for confirmation.
Reviewed-by: Martin Wilck
> ---
> libmultipath/checkers/tur.c | 5 +++--
> 1 file changed, 3 ins
toassembled by something else,
> before
> multipathd can autoassemble it. If we assume that it is a multipath
> device, or we assume that this wasn't actually the timeout uevent, we
> can keep a necessary device from getting released to the reset of the
> system.
>
> Signed-
Hello Ben,
On Tue, 2023-02-07 at 18:32 -0600, Benjamin Marzinski wrote:
> If "multipath -u" fails, udev doesn't import any values from the
> program. This means that multipath.rules will continue to use the
> values
> for DM_MULTIPATH_DEVICE_PATH and FIND_MULTIPATHS_WAIT_UNTIL that it
> has
>
On Thu, 2023-02-02 at 09:14 -0600, Benjamin Marzinski wrote:
>
> It looks like you pulled the first version of my patches, without the
> fix you suggested for impossible renames, into your queue branch.
Oops, thanks for noticing and notifying me. Fixed.
Martin
--
dm-devel mailing list
tem.
> The only thing that can happen along with a rename is a force reload.
>
> This patchset makes libmultipath also do all the other actions that
> are
> compatible with a rename.
>
> changes in v2 (as suggested by Martin Wilck)
> 0004: If the rename is impossible, multipa
On Wed, 2023-02-01 at 08:39 -0600, Benjamin Marzinski wrote:
> On Wed, Feb 01, 2023 at 08:00:25AM +0000, Martin Wilck wrote:
>
> >
> > This code makes we wonder if we should transform the ACT_... enum
> > into
> > a bitmap of required actions that would be ORed tog
On Tue, 2023-01-31 at 13:34 -0600, Benjamin Marzinski wrote:
> If select_action() is called and a multipath device needs to be
> renamed,
> the code currently checks if force_reload is set, and if so, does the
> reload after the rename. But if force_reload isn't set, only the
> rename
> happens,
On Tue, 2023-01-31 at 13:34 -0600, Benjamin Marzinski wrote:
> Combine the two separate blocks that set ACT_CREATE into one.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
> ---
> libmultipath/configure.c | 38 +-
>
e've
> detected a size change, and a forced reload is requested, we still
> need
> to flush the IO because the reload will change the device size.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
> ---
> libmultipath/configure.c | 11 ++-
> 1 fil
On Tue, 2023-01-31 at 13:34 -0600, Benjamin Marzinski wrote:
> Since we have a function to set the action to reload, use it.
>
> Signed-off-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
> ---
> libmultipath/configure.c | 8 ++--
> 1 file changed, 2 insertio
Hi Ben,
On Tue, 2022-12-20 at 17:41 -0600, Benjamin Marzinski wrote:
> In preparation for a future patch, make prflag an enum, and change
> the
> reply of cli_getprstatus() to a string.
>
> Signed-off-by: Benjamin Marzinski
this patch changes ABI. Thus I pushed 730629d [1] to the "queue"
f-by: Benjamin Marzinski
Reviewed-by: Martin Wilck
> ---
> libmultipath/print.c | 7 ---
> 1 file changed, 7 deletions(-)
>
> diff --git a/libmultipath/print.c b/libmultipath/print.c
> index 3193dbe0..9df77247 100644
> --- a/libmultipath/print.c
> +++ b/libmultipath/print.c
On Thu, 2023-01-12 at 14:28 -0600, Benjamin Marzinski wrote:
> From: Nitin Yewale
>
> Move "multipathd show wildcards" command above the $format commands
> and
> also add $format options for "map" and "path" commands to the
> multipathd
> man page.
>
> Signed-off-by: Benjamin Marzinski
> ---
>
On Tue, 2022-12-13 at 22:35 +0100, Martin Wilck wrote:
> On Tue, 2022-12-13 at 11:50 -0600, Benjamin Marzinski wrote:
> > On Tue, Dec 13, 2022 at 08:46:28AM +0100, Martin Wilck wrote:
> > > On Tue, 2022-12-06 at 18:37 -0600, Benjamin Marzinski wrote:
> > >
> >
multipathd/cli_handlers.c | 20 +-
> multipathd/main.c | 60 ---
> --
> 6 files changed, 77 insertions(+), 35 deletions(-)
>
For the series:
Reviewed-by: Martin Wilck
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
1 - 100 of 2117 matches
Mail list logo
