Re: [dm-devel] Revert "dm: always call blk_queue_split() in dm_process_bio()"

2020-09-11 Thread Mike Snitzer
On Fri, Sep 11 2020 at 8:20am -0400, Ming Lei wrote: > On Thu, Sep 10, 2020 at 10:24:39AM -0400, Mike Snitzer wrote: > > [cc'ing dm-devel and linux-block because this is upstream concern too] > > > > On Wed, Sep 09 2020 at 1:00pm -0400, > > Vijayendra Suman wrot

Re: [dm-devel] [PATCH 06/14] block: lift setting the readahead size into the block layer

2020-09-10 Thread Mike Snitzer
On Thu, Sep 10 2020 at 5:28am -0400, Christoph Hellwig wrote: > On Wed, Sep 02, 2020 at 12:20:07PM -0400, Mike Snitzer wrote: > > On Wed, Sep 02 2020 at 11:11am -0400, > > Christoph Hellwig wrote: > > > > > On Wed, Aug 26, 2020 at 06:07:38PM -0400, Mike Snitzer

Re: [dm-devel] Revert "dm: always call blk_queue_split() in dm_process_bio()"

2020-09-10 Thread Mike Snitzer
[cc'ing dm-devel and linux-block because this is upstream concern too] On Wed, Sep 09 2020 at 1:00pm -0400, Vijayendra Suman wrote: >Hello Mike, > >While Running pgbench tool with 5.4.17 kernel build > >Following performance degrade is found out > >buffer read/write metric

Re: [dm-devel] [PATCH v2] dax: fix for do not print error message for non-persistent memory block device

2020-09-03 Thread Mike Snitzer
rted(bdev, blocksize)) { Don't think I've ever seen a one-liner fix document the diff in its patch header. Really no need for that. > Fixes: c2affe920b0e ("dax: do not print error message for non-persistent > memory block device") > Signed-off-by: Coly Li > Reviewed-and-Tested

[dm-devel] [git pull] device mapper fixes for 5.9-rc4

2020-09-02 Thread Mike Snitzer
various opencoded bm->read_only checks to use dm_bm_is_read_only() instead. Damien Le Moal (1): dm crypt: Initialize crypto wait structures Mike Snitzer (1): dm mpath: fix racey management of PG initialization Miku

Re: [dm-devel] flood of "dm-X: error: dax access failed" due to 5.9 commit 231609785cbfb

2020-09-02 Thread Mike Snitzer
On Wed, Sep 02 2020 at 12:46pm -0400, Coly Li wrote: > On 2020/9/3 00:44, Mike Snitzer wrote: > > On Wed, Sep 02 2020 at 12:40pm -0400, > > Coly Li wrote: > > > >> On 2020/9/3 00:04, Mike Snitzer wrote: > >>> 5.9 commit 231609785

Re: [dm-devel] flood of "dm-X: error: dax access failed" due to 5.9 commit 231609785cbfb

2020-09-02 Thread Mike Snitzer
On Wed, Sep 02 2020 at 12:40pm -0400, Coly Li wrote: > On 2020/9/3 00:04, Mike Snitzer wrote: > > 5.9 commit 231609785cbfb ("dax: print error message by pr_info() in > > __generic_fsdax_supported()") switched from pr_debug() to pr_info(). > > > > The justifi

Re: [dm-devel] [PATCH 06/14] block: lift setting the readahead size into the block layer

2020-09-02 Thread Mike Snitzer
On Wed, Sep 02 2020 at 11:11am -0400, Christoph Hellwig wrote: > On Wed, Aug 26, 2020 at 06:07:38PM -0400, Mike Snitzer wrote: > > On Sun, Jul 26 2020 at 11:03am -0400, > > Christoph Hellwig wrote: > > > > > Drivers shouldn't really mess with the readahead size,

[dm-devel] flood of "dm-X: error: dax access failed" due to 5.9 commit 231609785cbfb

2020-09-02 Thread Mike Snitzer
5.9 commit 231609785cbfb ("dax: print error message by pr_info() in __generic_fsdax_supported()") switched from pr_debug() to pr_info(). The justification in the commit header is really inadequate. If there is a problem that you need to drill in on, repeat the testing after enabling the dynamic

Re: [dm-devel] [PATCH 06/14] block: lift setting the readahead size into the block layer

2020-08-26 Thread Mike Snitzer
On Sun, Jul 26 2020 at 11:03am -0400, Christoph Hellwig wrote: > Drivers shouldn't really mess with the readahead size, as that is a VM > concept. Instead set it based on the optimal I/O size by lifting the > algorithm from the md driver when registering the disk. Also set > bdi->io_pages

Re: [dm-devel] [PATCH RESEND] blk-mq: insert request not through ->queue_rq into sw/scheduler queue

2020-08-18 Thread Mike Snitzer
On Tue, Aug 18 2020 at 7:52pm -0400, Ming Lei wrote: > On Tue, Aug 18, 2020 at 11:20:22AM -0400, Mike Snitzer wrote: > > On Tue, Aug 18 2020 at 10:50am -0400, > > Jens Axboe wrote: > > > > > On 8/18/20 2:07 AM, Ming Lei wrote: > > > > c616c

Re: [dm-devel] [PATCH RESEND] blk-mq: insert request not through ->queue_rq into sw/scheduler queue

2020-08-18 Thread Mike Snitzer
On Tue, Aug 18 2020 at 10:50am -0400, Jens Axboe wrote: > On 8/18/20 2:07 AM, Ming Lei wrote: > > c616cbee97ae ("blk-mq: punt failed direct issue to dispatch list") supposed > > to add request which has been through ->queue_rq() to the hw queue dispatch > > list, however it adds request running

Re: [dm-devel] [RESEND PATCH] nvme: explicitly use normal NVMe error handling when appropriate

2020-08-13 Thread Mike Snitzer
On Thu, Aug 13 2020 at 2:43pm -0400, Christoph Hellwig wrote: > On Thu, Aug 13, 2020 at 01:47:04PM -0400, Mike Snitzer wrote: > > This is just a tweak to improve the high-level fault tree of core NVMe > > error handling. No functional change, but for such basic errors, > &

Re: [dm-devel] [RESEND PATCH] nvme: explicitly use normal NVMe error handling when appropriate

2020-08-13 Thread Mike Snitzer
On Thu, Aug 13 2020 at 11:36am -0400, Christoph Hellwig wrote: > On Thu, Aug 13, 2020 at 10:48:11AM -0400, Mike Snitzer wrote: > > Commit 764e9332098c0 ("nvme-multipath: do not reset on unknown > > status"), among other things, fixed NVME_SC_CMD_INTERRUPTED error

Re: [dm-devel] [RESEND PATCH] nvme: explicitly use normal NVMe error handling when appropriate

2020-08-13 Thread Mike Snitzer
29am -0400, Meneghini, John wrote: > Mike, > > I don't see your patch at: > > https://patchwork.kernel.org/project/linux-block/list/?submitter=1643 > > Can you please upload this patch there? > > Thanks, > > /John > > On 8/13/20, 10:48 AM, "Mike

[dm-devel] [RESEND PATCH] nvme: explicitly use normal NVMe error handling when appropriate

2020-08-13 Thread Mike Snitzer
be useful for future NVME_SC that nvme_status_needs_local_error_handling() hasn't been trained for yet. Signed-off-by: Mike Snitzer --- drivers/nvme/host/core.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/co

Re: [dm-devel] nvme: explicitly use normal NVMe error handling when appropriate

2020-08-10 Thread Mike Snitzer
On Mon, Aug 10 2020 at 11:32pm -0400, Chao Leng wrote: > > > On 2020/8/11 1:22, Mike Snitzer wrote: > >On Mon, Aug 10 2020 at 10:36am -0400, > >Mike Snitzer wrote: > > > >>On Fri, Aug 07 2020 at 7:35pm -0400, > >>Sagi Grimberg wrote: > >>

[dm-devel] [PATCH] nvme: explicitly use normal NVMe error handling when appropriate

2020-08-10 Thread Mike Snitzer
On Mon, Aug 10 2020 at 10:36am -0400, Mike Snitzer wrote: > On Fri, Aug 07 2020 at 7:35pm -0400, > Sagi Grimberg wrote: > > > > > >>Hey Mike, ... > > >I think NVMe can easily fix this by having an earlier stage of checking, > > >e.g. nvme_local

Re: [dm-devel] nvme: restore use of blk_path_error() in nvme_complete_rq()

2020-08-10 Thread Mike Snitzer
On Fri, Aug 07 2020 at 7:35pm -0400, Sagi Grimberg wrote: > > >>Hey Mike, > >> > The point is: blk_path_error() has nothing to do with NVMe errors. > This is dm-multipath logic stuck in the middle of the NVMe error > handling code. > >>> > >>>No, it is a means to have multiple

Re: [dm-devel] [git pull] device mapper changes for 5.9

2020-08-07 Thread Mike Snitzer
On Fri, Aug 07 2020 at 4:11pm -0400, Linus Torvalds wrote: > On Fri, Aug 7, 2020 at 9:03 AM Mike Snitzer wrote: > > > > - DM crypt improvement to optionally avoid async processing via > > workqueues for reads and/or writes -- via "no_read_workqueue" and >

Re: [dm-devel] [git pull] device mapper changes for 5.9

2020-08-07 Thread Mike Snitzer
On Fri, Aug 07 2020 at 12:03pm -0400, Mike Snitzer wrote: > Hi Linus, > > The following changes since commit 11ba468877bb23f28956a35e896356252d63c983: > > Linux 5.8-rc5 (2020-07-12 16:34:50 -0700) > > are available in the Git repository at: > > git://git.kern

[dm-devel] [git pull] device mapper changes for 5.9

2020-08-07 Thread Mike Snitzer
ongHyeon Lee (1): dm verity: add "panic_on_corruption" error handling mode Johannes Thumshirn (1): dm: don't call report zones for more than the user requested John Dorminy (1): dm ebs: Fix incorrect checking for REQ_OP_FLUSH Mike Snitzer (7): dm mpath: changes f

Re: [dm-devel] nvme: restore use of blk_path_error() in nvme_complete_rq()

2020-08-06 Thread Mike Snitzer
removed NVMe's use of > >blk_path_error(). If you're saying it wasn't needless please explain > >why. > > > >> Fixes: 764e9332098c0 ("nvme-multipath: do not reset on unknown status") > >> Cc: sta...@vger.kerneel.org > >> Signed-off-by: Mike Sn

Re: [dm-devel] nvme: restore use of blk_path_error() in nvme_complete_rq()

2020-08-06 Thread Mike Snitzer
On Thu, Aug 06 2020 at 6:42pm -0400, Meneghini, John wrote: > On 8/6/20, 3:20 PM, "Mike Snitzer" wrote: > > From: Mike Snitzer > Date: Thu, 2 Jul 2020 01:43:27 -0400 > Subject: [PATCH] nvme: restore use of blk_path_error() in > nvme_complete_rq() &

[dm-devel] fixing 4.14-stable's broken DM cache writethrough support [was: Re: [(resend) PATCH v3: {linux-4.14.y} ] dm cache: submit writethrough writes in parallel to origin and cache]

2020-08-05 Thread Mike Snitzer
On Wed, Aug 05 2020 at 10:32am -0400, Greg KH wrote: > On Tue, Aug 04, 2020 at 02:20:38PM -0400, Mike Snitzer wrote: > > On Tue, Aug 04 2020 at 8:47am -0400, > > Greg KH wrote: > > > > > On Tue, Aug 04, 2020 at 07:33:05AM -0500, John Donnelly wro

Re: [dm-devel] dm: don't call report zones for more than the user requested

2020-08-04 Thread Mike Snitzer
On Tue, Aug 04 2020 at 7:26am -0400, Johannes Thumshirn wrote: > On 04/08/2020 12:17, Damien Le Moal wrote: > > > > Looks good. I think this needs a Cc: stable. > > Indeed, Mike can you add these two when applying or do you want me to resend? > > Fixes: d41003513e61 ("block: rework zone

[dm-devel] [git pull] device mapper fix for 5.8-rc7

2020-07-24 Thread Mike Snitzer
Hi Linus, The following changes since commit 6958c1c640af8c3f40fa8a2eee3b5b905d95b677: dm: use noio when sending kobject event (2020-07-08 12:50:51 -0400) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git

Re: [dm-devel] [PATCH v2] dm-integrity: revert adc0daad366b to fix recalculation

2020-07-23 Thread Mike Snitzer
On Thu, Jul 23 2020 at 10:42am -0400, Mikulas Patocka wrote: > In order to fix this race condition, we add a function dm_suspending that > is only true during the postsuspend phase and use it instead of > dm_suspended. > ... > Index: rhel8/drivers/md/dm.c >

Re: [dm-devel] dm-integrity: revert adc0daad366b to fix recalculation

2020-07-22 Thread Mike Snitzer
On Wed, Jul 22 2020 at 2:46pm -0400, Mikulas Patocka wrote: > Hi Mike > > Please submit this to Linus and to RHEL-8. > > Mikulas > > > > From: Mikulas Patocka > > The patch adc0daad366b62ca1bce3e2958a40b0b71a8b8b3 broke recalculation on > dm-integrity. The patch replaces a private

Re: [dm-devel] [PATCH 1/3] block: inherit the zoned characteristics in blk_stack_limits

2020-07-21 Thread Mike Snitzer
On Mon, Jul 20 2020 at 2:12am -0400, Christoph Hellwig wrote: > Lift the code from device mapper into blk_stack_limits to inherity > the stacking limitations. This ensures we do the right thing for > all stacked zoned block devices. > > Signed-off-by: Christoph Hellwig

Re: [dm-devel] [PATCH 0/8] Various cleanups

2020-07-15 Thread Mike Snitzer
On Wed, Jul 15 2020 at 5:52am -0400, Damien Le Moal wrote: > Mike, > > These patches fix various compilation warnings showing up when compiling > with W=1. The last patch addresses a static checker warning (C=1 > compilation). There are a lot more of these code checker warnings > remaining

Re: [dm-devel] dm: use noio when sending kobject event

2020-07-10 Thread Mike Snitzer
On Wed, Jul 08 2020 at 3:37pm -0400, Gabriel Krisman Bertazi wrote: > Mike Snitzer writes: > > > On Wed, Jul 08 2020 at 2:26pm -0400, > > Gabriel Krisman Bertazi wrote: > > > >> If I understand it correctly, considering the deadlock you shared, this &g

[dm-devel] [git pull] device mapper fixes for 5.8-rc5

2020-07-09 Thread Mike Snitzer
Hi Linus, The following changes since commit dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258: Linux 5.8-rc4 (2020-07-05 16:20:22 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git tags/for-5.8/dm-fixes-2 for you to fetch

Re: [dm-devel] dm: use noio when sending kobject event

2020-07-08 Thread Mike Snitzer
On Wed, Jul 08 2020 at 2:26pm -0400, Gabriel Krisman Bertazi wrote: > Mikulas Patocka writes: > > > kobject_uevent may allocate memory and it may be called while there are dm > > devices suspended. The allocation may recurse into a suspended device, > > causing a deadlock. We must set the

Re: [dm-devel] [PATCH 2/2] dm zoned: Remove set but unused variables

2020-07-08 Thread Mike Snitzer
On Tue, Jul 07 2020 at 8:20pm -0400, Damien Le Moal wrote: > In dmz_reclaim_work(), the variables nr_unmap_rnd and nr_rnd are set but > unused. Remove them. > > Fixes: f97809aec589 ("dm zoned: per-device reclaim") > Signed-off-by: Damien Le Moal > --- > drivers/md/dm-zoned-reclaim.c | 5

Re: [dm-devel] [PATCH 01/14] dm: use bio_uninit instead of bio_disassociate_blkg

2020-07-08 Thread Mike Snitzer
On Sat, Jun 27 2020 at 3:31am -0400, Christoph Hellwig wrote: > bio_uninit is the proper API to clean up a BIO that has been allocated > on stack or inside a structure that doesn't come from the BIO allocator. > Switch dm to use that instead of bio_disassociate_blkg, which really is > an

[dm-devel] [PATCH] blk-mq: consider non-idle request as "inflight" in blk_mq_rq_inflight()

2020-07-07 Thread Mike Snitzer
mq: change blk_mq_queue_busy() to blk_mq_queue_inflight()") Cc: sta...@vger.kernel.org Signed-off-by: Ming Lei Signed-off-by: Mike Snitzer --- block/blk-mq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 4f57d27bfa73..e6219c27fc65 100644 --- a/bl

Re: [dm-devel] [PATCH 0/7] Fix muitpath/multipathd flush issue

2020-07-03 Thread Mike Snitzer
On Fri, Jul 03 2020 at 11:12am -0400, Martin Wilck wrote: > On Thu, 2020-07-02 at 14:41 -0500, Benjamin Marzinski wrote: > > On Thu, Jul 02, 2020 at 04:45:21PM +, Martin Wilck wrote: > > > > > > What's wrong with deferred remove? After all, the user explicitly > > > asked > > > for a flush.

Re: [dm-devel] [PATCH 10/20] dm: stop using ->queuedata

2020-07-01 Thread Mike Snitzer
On Wed, Jul 01 2020 at 4:59am -0400, Christoph Hellwig wrote: > Instead of setting up the queuedata as well just use one private data > field. > > Signed-off-by: Christoph Hellwig Acked-by: Mike Snitzer -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman

Re: [dm-devel] remove dead bdi congestion leftovers

2020-07-01 Thread Mike Snitzer
On Wed, Jul 01 2020 at 5:06am -0400, Christoph Hellwig wrote: > Hi Jens, > > we have a lot of bdi congestion related code that is left around without > any use. This series removes it in preparation of sorting out the bdi > lifetime rules properly. I could do some git archeology to see what

[dm-devel] NVMe regression, NVMe no longer uses blk_path_error()

2020-07-01 Thread Mike Snitzer
IF NVMe's isn't a primary user of blk_path_error() it largely kills the entire point of blk_path_error(). (And no the response to this must not be: "that's fine") This commit shows NVMe's previous continued use of blk_path_error(): 8decf5d5b9f3f7 ("nvme: remove nvme_req_needs_failover") but

Re: [dm-devel] dm writecache: reject asynchronous pmem.

2020-06-30 Thread Mike Snitzer
On Tue, Jun 30 2020 at 10:10am -0400, Michal Suchánek wrote: > On Tue, Jun 30, 2020 at 09:32:01AM -0400, Mikulas Patocka wrote: > > > > > > On Tue, 30 Jun 2020, Michal Suchanek wrote: > > > > > The writecache driver does not handle asynchronous pmem. Reject it when > > > supplied as cache. >

Re: [dm-devel] [PATCH v4 1/4] dm dust: report some message results back to user directly

2020-06-28 Thread Mike Snitzer
It is on the dm-devel patchwork list to pick up for the 5.9 merge window. I've just been busy with other work. Thanks, Mike On Sat, Jun 27 2020 at 9:08pm -0400, yangerkun wrote: > Hi Mike, does there any advice for this patchset? > > Thanks, > Kun. > > 在 2020/6/20 5:10, Bryan Gurney 写道: >

[dm-devel] [git pull] device mapper fixes for 5.8-rc3

2020-06-26 Thread Mike Snitzer
Hi Linus, The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git tags/for-5.8/dm-fixes for you to fetch changes

Re: [dm-devel] [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Mike Snitzer
On Wed, Jun 24 2020 at 12:54am -0400, Damien Le Moal wrote: > On 2020/06/24 0:23, Mike Snitzer wrote: > > On Tue, Jun 23 2020 at 11:07am -0400, > > Ignat Korchagin wrote: > > > >> Do you think it may be better to break it in two flags: one for read > >>

Re: [dm-devel] [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Mike Snitzer
On Fri, Jun 19 2020 at 9:23pm -0400, Herbert Xu wrote: > On Fri, Jun 19, 2020 at 02:39:39PM -0400, Mikulas Patocka wrote: > > > > I'm looking at this and I'd like to know why does the crypto API fail in > > hard-irq context and why does it work in tasklet context. What's the exact > > reason

Re: [dm-devel] [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Mike Snitzer
On Tue, Jun 23 2020 at 11:07am -0400, Ignat Korchagin wrote: > Do you think it may be better to break it in two flags: one for read > path and one for write? So, depending on the needs and workflow these > could be enabled independently? If there is a need to split, then sure. But I think

Re: [dm-devel] [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Mike Snitzer
On Sun, Jun 21 2020 at 8:45pm -0400, Damien Le Moal wrote: > On 2020/06/20 1:56, Mike Snitzer wrote: > > On Fri, Jun 19 2020 at 12:41pm -0400, > > Ignat Korchagin wrote: > > > >> This is a follow up from the long-forgotten [1], but with some more > >

Re: [dm-devel] dm-rq: don't call blk_mq_queue_stopped in dm_stop_queue()

2020-06-19 Thread Mike Snitzer
On Fri, Jun 19 2020 at 6:52pm -0400, Ming Lei wrote: > On Sat, Jun 20, 2020 at 06:37:44AM +0800, Ming Lei wrote: > > On Fri, Jun 19, 2020 at 01:40:41PM -0400, Mike Snitzer wrote: > > > On Fri, Jun 19 2020 at 12:06pm -0400, > > > Mike Snitzer wrote: > > > &g

Re: [dm-devel] dm-rq: don't call blk_mq_queue_stopped in dm_stop_queue()

2020-06-19 Thread Mike Snitzer
On Fri, Jun 19 2020 at 12:06pm -0400, Mike Snitzer wrote: > On Fri, Jun 19 2020 at 6:11am -0400, > Ming Lei wrote: > > > Hi Mike, > > > > On Fri, Jun 19, 2020 at 05:42:50AM -0400, Mike Snitzer wrote: > > > Hi Ming, > > > > > > Thanks fo

Re: [dm-devel] [PATCH v3 1/4] dm dust: report some message results back to user directly

2020-06-19 Thread Mike Snitzer
On Fri, Jun 19 2020 at 1:23pm -0400, Bryan Gurney wrote: > On Fri, Jun 19, 2020 at 11:45 AM Mike Snitzer wrote: > > > > On Fri, Jun 19 2020 at 11:40am -0400, > > Bryan Gurney wrote: > > > > > On Fri, Jun 19, 2020 at 8:37 AM yangerkun wrote: > > &

Re: [dm-devel] [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-19 Thread Mike Snitzer
On Fri, Jun 19 2020 at 12:41pm -0400, Ignat Korchagin wrote: > This is a follow up from the long-forgotten [1], but with some more convincing > evidence. Consider the following script: > > #!/bin/bash -e > > # create 4G ramdisk > sudo modprobe brd rd_nr=1 rd_size=4194304 > > # create a

Re: [dm-devel] [RFC PATCH 2/2] dm: don't try to split REQ_OP_ZONE_APPEND bios

2020-06-19 Thread Mike Snitzer
On Fri, Jun 19 2020 at 3:54am -0400, Damien Le Moal wrote: > On 2020/06/19 15:59, Johannes Thumshirn wrote: > > REQ_OP_ZONE_APPEND bios cannot be split so return EIO if we can't fit it > > into one IO. > > > > Signed-off-by: Johannes Thumshirn > > --- > > drivers/md/dm.c | 3 +++ > > 1 file

Re: [dm-devel] [PATCH 21/29] docs: device-mapper: add dm-ebs.rst to an index file

2020-06-19 Thread Mike Snitzer
On Mon, Jun 15 2020 at 2:47am -0400, Mauro Carvalho Chehab wrote: > Solves this Sphinx warning: > Documentation/admin-guide/device-mapper/dm-ebs.rst: WARNING: document > isn't included in any toctree > > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: [dm-devel] dm-rq: don't call blk_mq_queue_stopped in dm_stop_queue()

2020-06-19 Thread Mike Snitzer
On Fri, Jun 19 2020 at 6:11am -0400, Ming Lei wrote: > Hi Mike, > > On Fri, Jun 19, 2020 at 05:42:50AM -0400, Mike Snitzer wrote: > > Hi Ming, > > > > Thanks for the patch! But I'm having a hard time understanding what > > you've written in the patch hea

Re: [dm-devel] [PATCH v3 1/4] dm dust: report some message results back to user directly

2020-06-19 Thread Mike Snitzer
On Fri, Jun 19 2020 at 11:40am -0400, Bryan Gurney wrote: > On Fri, Jun 19, 2020 at 8:37 AM yangerkun wrote: > > > > Some type of message(queryblock/countbadblocks/removebadblock) may better > > report results to user directly. Do it with DMEMIT. > > > > Signed-off-by: yangerkun > > --- > >

Re: [dm-devel] dm-rq: don't call blk_mq_queue_stopped in dm_stop_queue()

2020-06-19 Thread Mike Snitzer
Hi Ming, Thanks for the patch! But I'm having a hard time understanding what you've written in the patch header, On Fri, Jun 19 2020 at 4:42am -0400, Ming Lei wrote: > dm-rq won't stop queue, meantime blk-mq won't stop one queue too, so > remove the check. It'd be helpful if you could

Re: [dm-devel] New mode DM-Verity error handling

2020-06-18 Thread Mike Snitzer
On Thu, Jun 18 2020 at 12:50pm -0400, Sami Tolvanen wrote: > On Thu, Jun 18, 2020 at 11:44:45AM -0400, Mike Snitzer wrote: > > I do not accept that panicing the system because of verity failure is > > reasonable. > > > > In fact, even rebooting (via DM_VERITY_MOD

Re: [dm-devel] New mode DM-Verity error handling

2020-06-18 Thread Mike Snitzer
On Thu, Jun 18 2020 at 2:56am -0400, JeongHyeon Lee wrote: > Hello, Dear devcice-mapper maintainers. > > I'm JeongHyeon Lee, work in Samsung. I'm chage of DM-Verity feature with > Mr. sunwook eom. > I have a patch or suggestion about DM-Verity error handling. > > Our device (smart phone)

Re: [dm-devel] [PATCH v2 0/2] introduce interface to list all badblocks

2020-06-18 Thread Mike Snitzer
On Thu, Jun 18 2020 at 5:06am -0400, yangerkun wrote: > > This patchset will list badblocks while we do 'dmsetup status'. > > Image that we have mark block 1 and 2 as bad block, run following > command will list all bad blocks: > > $ sudo dmsetup status dust1 > 0 33552384 dust 252:17

Re: [dm-devel] dm writecache: correct uncommitted_block when discarding uncommitted entry

2020-06-17 Thread Mike Snitzer
On Sat, Jun 13 2020 at 8:40am -0400, Mikulas Patocka wrote: > > > On Fri, 12 Jun 2020, Huaisheng Ye wrote: > > > From: Huaisheng Ye > > > > When uncommitted entry has been discarded, correct wc->uncommitted_block > > for getting the exact number. > > > > Signed-off-by: Huaisheng Ye > >

Re: [dm-devel] dm ioctl: Use struct_size() helper

2020-06-17 Thread Mike Snitzer
On Tue, Jun 16 2020 at 6:06pm -0400, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this? > > It's been almost a year... and I just noticed there was a problem > with the email addresses back then... > > I just fixed the issue and this patch should now appear on >

Re: [dm-devel] [git pull v3] device mapper changes for 5.8

2020-06-10 Thread Mike Snitzer
On Tue, Jun 09 2020 at 9:59am -0400, Mike Snitzer wrote: > [resending as v3 due to my From: email addr in v2 being inexplicably wrong] The pr-tracker-bot responded to that email address and I missed it: https://www.redhat.com/archives/dm-devel/2020-June/msg00067.html I should've just loo

[dm-devel] [git pull v3] device mapper changes for 5.8

2020-06-09 Thread Mike Snitzer
dm mpath: add Historical Service Time Path Selector Martin Wilck (1): dm mpath: switch paths in dm_blk_ioctl() code path Mike Snitzer (5): dm: use DMDEBUG macros now that they use pr_debug variants dm mpath: simplify __must_push_back dm mpath: restrict queue_if_no

[dm-devel] [git pull v2] device mapper changes for 5.8

2020-06-08 Thread Mike Snitzer
ull zones for reclaim dm zoned: check superblock location Heinz Mauelshagen (2): dm: add emulated block size target dm ebs: pass discards down to underlying device Khazhismel Kumykov (1): dm mpath: add Historical Service Time Path Selector Martin Wilck (1): dm mpath

[dm-devel] [git pull] device mapper changes for 5.8

2020-06-05 Thread Mike Snitzer
Kumykov (1): dm mpath: add Historical Service Time Path Selector Martin Wilck (1): dm mpath: switch paths in dm_blk_ioctl() code path Mike Snitzer (5): dm: use DMDEBUG macros now that they use pr_debug variants dm mpath: simplify __must_push_back dm mpath: restrict q

Re: [dm-devel] [PATCH][next] dm zoned: fix memory leak of newly allocated zone on xa_insert failure

2020-06-03 Thread Mike Snitzer
On Wed, Jun 03 2020 at 12:02pm -0400, Colin King wrote: > From: Colin Ian King > > Currently if an xa_insert fails then there is a memory lead of the > recently allocated zone object. Fix this by kfree'ing zone before > returning on the error return path. > > Addresses-Coverity: ("Resource

Re: [dm-devel] [PATCHv4 00/15] dm-zoned: multiple drive support

2020-06-02 Thread Mike Snitzer
On Tue, Jun 02 2020 at 7:09am -0400, Hannes Reinecke wrote: > Hi all, > > here's the second version of my patchset to support multiple zoned > drives with dm-zoned. > This patchset: > - Converts the zone array to using xarray for better scalability > - Separates out shared structures into

Re: [dm-devel] [PATCHv2 00/15] dm-zoned: multi-device support

2020-05-27 Thread Mike Snitzer
On Wed, May 27 2020 at 2:22am -0400, Hannes Reinecke wrote: > Hi all, > > here's the second version of my patchset to support multiple zoned > drives with dm-zoned. > This patchset: > - Converts the zone array to using xarray for better scalability > - Separates out shared structures into

Re: [dm-devel] delete dm_bufio_discard_buffers

2020-05-27 Thread Mike Snitzer
On Wed, May 27 2020 at 7:04am -0400, Mikulas Patocka wrote: > Hi > > I suggest to delete dm_bufio_discard_buffers because no one is using it. > > If you need it in the future, tell me - and I will optimize it, so that it > walks the rb-tree of buffers instead of doing block-by-block lookups.

Re: [dm-devel] [PATCHv2 0/6] dm-zoned: improve cache performance

2020-05-20 Thread Mike Snitzer
On Tue, May 19 2020 at 6:36pm -0400, Damien Le Moal wrote: > On 2020/05/19 17:14, Hannes Reinecke wrote: > > Hi all, > > > > here's an update to dm-zoned to separate out cache zones. > > In the update to metadata version 2 the regular drive was split > > in emulated zones, which were handled

Re: [dm-devel] [PATCHv2 0/6] dm-zoned: improve cache performance

2020-05-19 Thread Mike Snitzer
On Tue, May 19 2020 at 4:14am -0400, Hannes Reinecke wrote: > Hi all, > > here's an update to dm-zoned to separate out cache zones. > In the update to metadata version 2 the regular drive was split > in emulated zones, which were handled just like 'normal' random > write zones. > This causes a

Re: [dm-devel] next-20200514 - build issue in drivers/md/dm-zoned-target.c

2020-05-18 Thread Mike Snitzer
On Mon, May 18 2020 at 2:25am -0400, Hannes Reinecke wrote: > On 5/16/20 1:19 PM, Valdis Klētnieks wrote: > >Am seeing a build error in next-0514. -0420 built OK. > >building a 'make allmodconfig' on a RPi4 in 32-bit mode. > > > > MODPOST 7575 modules > >ERROR: modpost: "__aeabi_uldivmod"

Re: [dm-devel] [dm:for-next 53/58] drivers/md/dm-zoned-metadata.c:779:3: error: implicit declaration of function 'export_uuid'

2020-05-15 Thread Mike Snitzer
On Fri, May 15 2020 at 3:25am -0400, Hannes Reinecke wrote: > Hi Mike, > > This is cause by missing commit d01cd62400b3 ("uuid: Add inline > helpers to import / export UUIDs"), which went into 5.7. > Mind to update your tree? Rebased on v5.7-rc5, thanks -- dm-devel mailing list

Re: [dm-devel] [dm:dm-5.8 55/57] include/linux/device-mapper.h:626:2: error: #endif without #if

2020-05-14 Thread Mike Snitzer
licit declaration of function > 'export_uuid' [-Werror=implicit-function-declaration] > 779 | export_uuid(sb->dmz_uuid, >uuid); > | ^~~ > drivers/md/dm-zoned-metadata.c: In function 'dmz_check_sb': > drivers/md/dm-zoned-metadata.c:1015:3: error: implicit declaratio

Re: [dm-devel] [PATCH 1/2] device-mapper: use dynamic debug instead of compile-time config option

2020-05-14 Thread Mike Snitzer
On Thu, May 14 2020 at 2:09am -0400, Hannes Reinecke wrote: > Switch to use dynamic debug to avoid having recompile the kernel > just to enable debugging messages. > > Signed-off-by: Hannes Reinecke FYI, I decided to always use pr_debug* rather than preserve using printk if CONFIG_DM_DEBUG

Re: [dm-devel] [PATCH 1/2] device-mapper: use dynamic debug instead of compile-time config option

2020-05-14 Thread Mike Snitzer
On Thu, May 14 2020 at 3:53am -0400, Damien Le Moal wrote: > On 2020/05/14 15:09, Hannes Reinecke wrote: > > Switch to use dynamic debug to avoid having recompile the kernel > > just to enable debugging messages. > > > > Signed-off-by: Hannes Reinecke > > --- > >

Re: [dm-devel] device-mapper: use dynamic debug instead of compile-time config option

2020-05-13 Thread Mike Snitzer
On Wed, May 13 2020 at 1:01pm -0400, Hannes Reinecke wrote: > On 5/13/20 6:25 PM, Mike Snitzer wrote: > >On Wed, May 13 2020 at 7:10am -0400, > >Hannes Reinecke wrote: > > > >>On 5/13/20 11:41 AM, Damien Le Moal wrote: > >>>On 2020/05/13 16:10,

Re: [dm-devel] device-mapper: use dynamic debug instead of compile-time config option

2020-05-13 Thread Mike Snitzer
On Wed, May 13 2020 at 7:10am -0400, Hannes Reinecke wrote: > On 5/13/20 11:41 AM, Damien Le Moal wrote: > >On 2020/05/13 16:10, Hannes Reinecke wrote: > >>Switch to use dynamic debug to avoid having recompile the kernel > >>just to enable debugging messages. > >> > >>Signed-off-by: Hannes

Re: [dm-devel] [PATCHv5 00/14] dm-zoned: metadata version 2

2020-05-12 Thread Mike Snitzer
On Mon, May 11 2020 at 2:31am -0400, Hannes Reinecke wrote: > On 5/11/20 4:46 AM, Damien Le Moal wrote: > >On 2020/05/08 18:03, Hannes Reinecke wrote: > >>Hi all, > >> > >>this patchset adds a new metadata version 2 for dm-zoned, which brings the > >>following improvements: > >> > >>- UUIDs and

Re: [dm-devel] [PATCH v4 0/2] Historical Service Time Path Selector

2020-05-11 Thread Mike Snitzer
On Mon, May 11 2020 at 1:31pm -0400, Mike Snitzer wrote: > On Mon, May 11 2020 at 1:11pm -0400, > Gabriel Krisman Bertazi wrote: > > > Mike Snitzer writes: > > > > > On Mon, May 11 2020 at 12:39pm -0400, > > > Gabriel Krisman Bertazi wrote: >

Re: [dm-devel] [PATCH v4 0/2] Historical Service Time Path Selector

2020-05-11 Thread Mike Snitzer
On Mon, May 11 2020 at 1:11pm -0400, Gabriel Krisman Bertazi wrote: > Mike Snitzer writes: > > > On Mon, May 11 2020 at 12:39pm -0400, > > Gabriel Krisman Bertazi wrote: > > > >> Hi, > >> > >> This fourth version of HST applies the suggesti

Re: [dm-devel] [PATCH v4 0/2] Historical Service Time Path Selector

2020-05-11 Thread Mike Snitzer
On Mon, May 11 2020 at 12:39pm -0400, Gabriel Krisman Bertazi wrote: > Hi, > > This fourth version of HST applies the suggestion from Mikulas Patocka > to do the ktime_get_ns inside the mpath map_bio instead of generic > device-mapper code. This means that struct dm_mpath_io gained another >

Re: [dm-devel] dm: track io errors per mapped device

2020-05-08 Thread Mike Snitzer
On Fri, May 08 2020 at 3:22pm -0400, k...@orbekk.com wrote: > On Thu, May 7, 2020, at 21:12, Chaitanya Kulkarni wrote: > > On 05/07/2020 04:06 PM, Kjetil Orbekk wrote: > > > + if (tio->error) > > > + atomic_inc(>ioerr_cnt); > > > > Given that there are so many errors

Re: [dm-devel] [PATCH 01/14] dm-zoned: add 'status' and 'message' callbacks

2020-05-08 Thread Mike Snitzer
On Fri, May 08 2020 at 2:25pm -0400, Hannes Reinecke wrote: > On 5/8/20 6:29 PM, Mike Snitzer wrote: > >On Fri, May 08 2020 at 5:03am -0400, > >Hannes Reinecke wrote: > > > >>Add callbacks to supply information for 'dmsetup status' > >>and 'dmsetup in

Re: [dm-devel] [PATCH 14/14] dm-zoned: metadata version 2

2020-05-08 Thread Mike Snitzer
On Fri, May 08 2020 at 5:03am -0400, Hannes Reinecke wrote: > Implement handling for metadata version 2. The new metadata adds > a label and UUID for the device mapper device, and additional UUID > for the underlying block devices. > It also allows for an additional regular drive to be used for

Re: [dm-devel] [PATCH 01/14] dm-zoned: add 'status' and 'message' callbacks

2020-05-08 Thread Mike Snitzer
On Fri, May 08 2020 at 5:03am -0400, Hannes Reinecke wrote: > Add callbacks to supply information for 'dmsetup status' > and 'dmsetup info', and implement the message 'reclaim' > to start the reclaim worker. Same feedback from before:

Re: [dm-devel] [PATCH -next] dm mpath: Remove unused variable ret

2020-05-07 Thread Mike Snitzer
On Thu, May 07 2020 at 8:26am -0400, Samuel Zou wrote: > This patch fixes below warning reported by coccicheck: > > drivers/md/dm-historical-service-time.c:240:14-16: Unneeded variable: "sz". > Return "0" on line 261 > > Reported-by: Hulk Robot > Signed-off-by: Samuel Zou Nack. DMEMIT()

[dm-devel] [git pull] device mapper fixes for 5.7-rc4

2020-04-30 Thread Mike Snitzer
Hi Linus, The following changes since commit 8267d8fb4819afa76b2a54dca48efdda6f0b1910: dm integrity: fix logic bug in integrity tag testing (2020-04-03 13:07:41 -0400) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git

Re: [dm-devel] [PATCH v2 0/3] Historical Service Time Path Selector

2020-04-30 Thread Mike Snitzer
On Thu, Apr 30 2020 at 1:49pm -0400, Gabriel Krisman Bertazi wrote: > Gabriel Krisman Bertazi writes: > > > Hi Mike, > > > > Please find an updated version of HST integrating the change you > > requested to also support BIO based multipath. I hope you don't mind me > > folding the function

Re: [dm-devel] dm ebs: fix bio->bi_status assignment

2020-04-29 Thread Mike Snitzer
On Wed, Apr 29 2020 at 11:07am -0400, hei...@redhat.com wrote: > From: Heinz Mauelshagen > > Assign blk_status_t to bi_status properly in __ebs_process_bios() > on error (flaw found by static checker). > > Reported-by: Dan Carpenter > Signed-off-by: Heinz Mauelshagen > --- >

Re: [dm-devel] [PATCH 3/3] block: bypass ->make_request_fn for blk-mq drivers

2020-04-28 Thread Mike Snitzer
> fast path, which is rather expensive due to spectre mitigations. > > Signed-off-by: Christoph Hellwig Makes me cringe thinking about all the indirect calls sprinkled throughout DM... Acked-by: Mike Snitzer -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 2/3] dm: remove the make_request_fn check in device_area_is_invalid

2020-04-28 Thread Mike Snitzer
oop device uses blk-mq these days anyway..). But that aside: Acked-by: Mike Snitzer Thanks. > --- > drivers/md/dm-table.c | 17 - > 1 file changed, 17 deletions(-) > > diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c > index 0a2cc197f62b4.

Re: [dm-devel] [PATCH 13/13] dm-zoned: metadata version 2

2020-04-28 Thread Mike Snitzer
On Tue, Apr 28 2020 at 6:54am -0400, Damien Le Moal wrote: > With this, everything works fine for single and dual device case. Cool. Hannes, pleasee fold Damien's changes in for v3, thanks! > But I only did very light testing (formating witth ext4, mounting, > running simple fio, unmount).

Re: [dm-devel] dm: multipath: Use updated MPATHF_QUEUE_IO on mapping for BIO-based mpath

2020-04-28 Thread Mike Snitzer
On Mon, Apr 27 2020 at 8:39pm -0400, Gabriel Krisman Bertazi wrote: > When adding devices that don't have a scsi_dh on a BIO based multipath, > I was able to consistently hit the warning below and lock-up the system. > > The problem is that __map_bio reads the flag before it potentially being

Re: [dm-devel] [PATCH v2 2/3] md: multipath: Pass io_start_time to the path selector

2020-04-28 Thread Mike Snitzer
_clone function was suggested and implemented > by Mike Snitzer . > > Cc: Mike Snitzer > Cc: Khazhismel Kumykov > Signed-off-by: Gabriel Krisman Bertazi > --- > drivers/md/dm-mpath.c | 25 +++-- > drivers/md/dm-path-selector.h | 1

Re: [dm-devel] [PATCH v2 1/3] md: multipath: Encapsulate parameters passed to selectors

2020-04-28 Thread Mike Snitzer
On Mon, Apr 27 2020 at 8:51pm -0400, Gabriel Krisman Bertazi wrote: > Different selector will use different parameters, which means .io_start > and .io_end will get their signatures modified to include more and more > parameters. This encapsulates the data in a structure so we can > simplify

Re: [dm-devel] [PATCH 0/2] Historical Service Time Path Selector

2020-04-23 Thread Mike Snitzer
On Thu, Apr 16 2020 at 5:13P -0400, Gabriel Krisman Bertazi wrote: > Hello, > > This small series implements a new path selector that leverages > historical path IO time in order to estimate future path performance. > Implementation details can be found on Patch 2. > > This selector yields

Re: [dm-devel] dm-crypt: support using encrypted keys

2020-04-23 Thread Mike Snitzer
On Thu, Apr 23 2020 at 2:47am -0400, Milan Broz wrote: > On 22/04/2020 23:40, Mike Snitzer wrote: > > On Wed, Apr 22 2020 at 12:47pm -0400, > > Milan Broz wrote: > > > >> On 21/04/2020 20:27, Mike Snitzer wrote: > >>> On Mon, Apr 20 2020 at

Re: [dm-devel] dm-crypt: support using encrypted keys

2020-04-22 Thread Mike Snitzer
On Wed, Apr 22 2020 at 12:47pm -0400, Milan Broz wrote: > On 21/04/2020 20:27, Mike Snitzer wrote: > > On Mon, Apr 20 2020 at 9:46P -0400, > > Dmitry Baryshkov wrote: > > > >> From: Dmitry Baryshkov > >> > >> Allow one to use encrypted in addi

<    4   5   6   7   8   9   10   11   12   13   >