I fixed this ~3 minutes after pushing.. amazing how quick the kbuild test robot
is!
But thanks,
Mike
On Wed, Apr 22 2020 at 5:21pm -0400,
kbuild test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git
> for-next
> head:
On Tue, Apr 21 2020 at 2:32P -0400,
Dmitry Baryshkov wrote:
> вт, 21 апр. 2020 г. в 21:27, Mike Snitzer :
> >
> > On Mon, Apr 20 2020 at 9:46P -0400,
> > Dmitry Baryshkov wrote:
> >
> > > From: Dmitry Baryshkov
> > >
> > > Allow one to
On Mon, Apr 20 2020 at 9:46P -0400,
Dmitry Baryshkov wrote:
> From: Dmitry Baryshkov
>
> Allow one to use encrypted in addition to user and login key types for
> device encryption.
>
> Signed-off-by: Dmitry Baryshkov
I fixed up some issues, please see the following incremental patch,
I'll
make no mention of this commit header which explicitly
speaks to why what you're proposing is _not_ acceptable:
commit 8a74d29d541cd86569139c6f3f44b2d210458071
Author: Mike Snitzer
Date: Tue Nov 14 15:40:52 2017 -0500
dm: discard support requires all targets in a table support discards
A
On Wed, Apr 15 2020 at 10:49am -0400,
Mikulas Patocka wrote:
>
>
> On Wed, 15 Apr 2020, Mike Snitzer wrote:
>
> > > > > + r = writecache_read_metadata(wc,
> > > > > +
> > > > > min((sector_t)bdev_logical
On Wed, Apr 15 2020 at 4:14am -0400,
Mikulas Patocka wrote:
>
>
> On Tue, 14 Apr 2020, Mike Snitzer wrote:
>
> > On Wed, Apr 08 2020 at 3:02pm -0400,
> > Mikulas Patocka wrote:
> >
> > > The dm-writecache reads metadata in the target constructor. Ho
On Wed, Apr 08 2020 at 3:02pm -0400,
Mikulas Patocka wrote:
> The dm-writecache reads metadata in the target constructor. However, when
> we reload the target, there could be another active instance running on
> the same device. This is the sequence of operations when doing a reload:
>
> 1.
On Tue, Apr 14 2020 at 2:38am -0400,
Hannes Reinecke wrote:
> On 4/11/20 2:30 PM, Bob Liu wrote:
> >On 4/9/20 2:45 PM, Hannes Reinecke wrote:
> >>Hi all,
> >>
> >>this patchset adds a new metadata version 2, which brings the following
> >>improvements:
> >>- UUIDs and labels: Adding three more
.
Mike Snitzer (2):
dm integrity: fix ppc64le warning
Revert "dm: always call blk_queue_split() in dm_process_bio()"
Mikulas Patocka (1):
dm integrity: fix logic bug in integrity tag testing
drivers/md/dm-integrity.c | 4 ++--
anks!
Mike
- Fix excessive bio splitting that caused performance regressions.
- Fix DM integrity warning on ppc64le due to missing cast.
----
Mike Snitzer (2):
dm integrity: fix ppc64le warning
Revert "dm: always call
arlier, but could you take a look at
> this patch and ack it if it looks ok to go through the nvdimm tree
> with the rest of the series?
Yes, looks fine to me.
Acked-by: Mike Snitzer
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Hi Linus,
The following changes since commit fb33c6510d5595144d585aa194d377cf74d31911:
Linux 5.6-rc6 (2020-03-15 15:01:23 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git
tags/for-5.7/dm-changes
for you to fetch
On Fri, Mar 27 2020 at 3:08am -0400,
Hannes Reinecke wrote:
> Add callbacks to supply information for 'dmsetup status'
> and 'dmsetup info', and implement the message 'reclaim'
> to start the reclaim worker.
Who/What will use the 'reclaim' message? Shouldn't it be documented?
Think the
On Tue, Mar 24 2020 at 2:59pm -0400,
Lukas Straub wrote:
> On Tue, 24 Mar 2020 13:18:22 -0400
> Mike Snitzer wrote:
>
> > On Thu, Feb 27 2020 at 8:26am -0500,
> > Lukas Straub wrote:
> >
> > > If a full metadata buffer is being written, don't read
On Thu, Feb 27 2020 at 8:26am -0500,
Lukas Straub wrote:
> If a full metadata buffer is being written, don't read it first. This
> prevents a read-modify-write cycle and increases performance on HDDs
> considerably.
>
> To do this we now calculate the checksums for all sectors in the bio in
On Mon, Mar 23 2020 at 11:54pm -0400,
Damien Le Moal wrote:
> On 2020/03/24 0:04, Hannes Reinecke wrote:
> > Add callbacks to supply information for 'dmsetup status'
> > and 'dmsetup info', and implement the message 'reclaim'
> > to start the reclaim worker.
>
> This one is nice ! Can you send
On Mon, Mar 23 2020 at 12:10pm -0400,
Hannes Reinecke wrote:
> On 3/23/20 4:39 PM, Mike Snitzer wrote:
> >On Mon, Mar 23 2020 at 11:26am -0400,
> >Hannes Reinecke wrote:
> >
> >>On 3/23/20 4:15 PM, Mike Snitzer wrote:
> >>>On Mon, Mar 23 2020 at
On Mon, Mar 23 2020 at 11:03am -0400,
Hannes Reinecke wrote:
> Hi Damien,
>
> as my original plan to upgrade bcache to work for SMR devices
> turned out to be more complex than anticipated I went for the
> simpler approach and added a 'cache' device for dm-zoned.
> It is using a normal device
On Sun, Mar 22 2020 at 3:42pm -0400,
Mikulas Patocka wrote:
> Hi
>
> Here I'm sending dm-integrity patches for the upcoming merge window.
> They supersede dm-integrity patches that I sent before.
So the dm-bufio discard support isn't needed with your latest
dm-integrity patches right?
On Wed, Mar 18 2020 at 12:34pm -0400,
Mike Snitzer wrote:
> On Wed, Mar 18 2020 at 11:44am -0400,
> Heinz Mauelshagen wrote:
>
> > Once we are on this, we should put conditionals on those
> > mempool_exit and kmem_cache_destroy
> > calls in the fec dtr, because the t
On Wed, Mar 18 2020 at 11:44am -0400,
Heinz Mauelshagen wrote:
> Once we are on this, we should put conditionals on those
> mempool_exit and kmem_cache_destroy
> calls in the fec dtr, because the target calls that destructor at
> any time on its error path thus part
> of the pools or even the
On Tue, Mar 10 2020 at 8:39am -0400,
Heinz Mauelshagen wrote:
> On 3/9/20 11:44 PM, Damien Le Moal wrote:
> >On 2020/03/10 7:26, hei...@redhat.com wrote:
> >>From: Heinz Mauelshagen
> >>
> >>dm ebs: new block size emulating target
> >>
> >>This new target is similar to the linear target except
On Wed, Mar 04 2020 at 2:06pm -0500,
Linus Torvalds wrote:
> On Wed, Mar 4, 2020 at 9:03 AM Mike Snitzer wrote:
> >
> > - Bump the minor version for DM core and all target versions that have
> > seen interface changes or important fixes during the 5.6 cycle.
>
cle.
Hou Tao (1):
dm: fix congested_fn for request-based device
Mike Snitzer (3):
dm bio record: save/restore bi_end_io and bi_integrity
dm integrity: use dm_bio_record and dm_bio_restore
dm: bump version of core and various targets
Mikulas Patocka
On Tue, Mar 03 2020 at 3:45am -0500,
Hou Tao wrote:
> We neither assign congested_fn for requested-based blk-mq device
> nor implement it correctly. So fix both.
>
> Fixes: 4aa9c692e052 ("bdi: separate out congested state into a separate
> struct")
> Signed-off-by: Hou Tao
> ---
>
On Tue, Feb 25 2020 at 5:02pm -0500,
Christoph Hellwig wrote:
> On Tue, Feb 25, 2020 at 08:54:07PM +0100, Daniel Glöckner wrote:
> > bio_reset will reset too many fields. As you can see in the context of
> > the diff, dm-integrity expects f.ex. the values modified by bio_advance
> > to stay
On Thu, Feb 13 2020 at 9:18am -0500,
Maksym Planeta wrote:
> The documentation [1] says that WQ_CPU_INTENSIVE is "meaningless" for
> unbound wq. I remove this flag from places where unbound queue is
> allocated. This is supposed to improve code readability.
>
> 1.
On Thu, Feb 06 2020 at 10:19pm -0500,
John Dorminy wrote:
> I agree that adding uuid to all messages would be gross bloat, and a
> bad idea to apply everywhere.
>
> I didn't actually realize that devices could be renamed with dmsetup.
> Thanks for pointing that out...
Also, device names can
Ha, nice catch Mikulas!! Whew what a relief...Joe: way to tip the scales in dm-cache's favor! :)On Feb 5, 2020 4:17 AM, Mikulas Patocka wrote:Here I'm sending a patch for device mapper tests suite. With this patch,
the cache is allocated on the fast device. It performs slightly better
than
On Fri, Jan 31 2020 at 7:55pm -0500,
John Dorminy wrote:
> While dm_device_name() returns the MAJOR:MINOR numbers of a device,
> some targets would like to know the pretty name of a device, and
> some targets would like to know the uuid expected for the device.
>
> The MAJOR:MINOR name is
n-disk format documentation
Joe Thornber (1):
dm space map common: fix to ensure new block isn't already in use
Mike Snitzer (3):
dm thin metadata: use pool locking at end of dm_pool_metadata_close
dm thin: fix use-after-free in metadata_pre_commit_callback
dm: fix potential
On Tue, Jan 28 2020 at 9:32am -0500,
Stefan Bader wrote:
> On 27.01.20 20:32, Mike Snitzer wrote:
> >
> > I just staged the following DM fix:
> > https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.6=28a101d6b344f5a38d482a686d18b12
On Thu, Jan 23 2020 at 1:52pm -0500,
Jens Axboe wrote:
> On 1/23/20 10:28 AM, Mike Snitzer wrote:
> > On Thu, Jan 23 2020 at 5:35am -0500,
> > Mike Snitzer wrote:
> >
> >> On Thu, Jan 23 2020 at 4:17am -0500,
> >> Stefan Bader wrote:
> >>
On Thu, Jan 23 2020 at 5:35am -0500,
Mike Snitzer wrote:
> On Thu, Jan 23 2020 at 4:17am -0500,
> Stefan Bader wrote:
>
> > When device-mapper adapted for multi-queue functionality, they
> > also re-organized the way the make-request function was set.
> >
On Thu, Jan 23 2020 at 4:17am -0500,
Stefan Bader wrote:
> When device-mapper adapted for multi-queue functionality, they
> also re-organized the way the make-request function was set.
> Before, this happened when the device-mapper logical device was
> created. Now it is done once the mapping
On Tue, Jan 21 2020 at 9:20am -0500,
Kirill Tkhai wrote:
> On 21.01.2020 16:48, Mike Snitzer wrote:
> > On Tue, Jan 21 2020 at 8:33am -0500,
> > Kirill Tkhai wrote:
> >
> >> On 21.01.2020 15:36, Kirill Tkhai wrote:
> >>> On 21.01.2020 15:24, Mike
On Tue, Jan 21 2020 at 8:33am -0500,
Kirill Tkhai wrote:
> On 21.01.2020 15:36, Kirill Tkhai wrote:
> > On 21.01.2020 15:24, Mike Snitzer wrote:
> >> On Tue, Jan 21 2020 at 5:42am -0500,
> >> Kirill Tkhai wrote:
> >>
> >>> Since d
On Tue, Jan 21 2020 at 5:42am -0500,
Kirill Tkhai wrote:
> Since dm inherits limits from underlining block devices,
> this patch directly disables max_allocate_sectors for dm
> till full allocation support is implemented.
>
> This prevents high-level primitives (generic_make_request_checks(),
On Tue, Jan 14, 2020 at 4:53 PM Eric Biggers wrote:
>
> On Tue, Jan 07, 2020 at 12:28:25PM +, Joe Thornber wrote:
> > On Tue, Jan 07, 2020 at 10:46:27AM +, Joe Thornber wrote:
> > > I'll get a patch to you later today.
> >
> > Eric,
> >
> > Patch below. I've run it through a bunch of
On Tue, Jan 14 2020 at 11:31am -0500,
Gabriel Krisman Bertazi wrote:
> Mike Snitzer writes:
>
> > On Mon, Jan 13 2020 at 5:41P -0500,
> > Gabriel Krisman Bertazi wrote:
> >
> >> From: Anatol Pomazau
> >>
> >> Add a configurable ti
Please fix your mail client so that when you reply to a message you
don't start a new thread.
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
On Thu, Jan 02 2020 at 5:45pm -0500,
Gabriel Krisman Bertazi wrote:
> From: Anatol Pomazau
>
> Add a configurable timeout mechanism to disable queue_if_no_path without
> assistance from multipathd. In reality, this reimplements the
> no_path_retry mechanism from multipathd in kernel space,
s to dm-clone and dm-integrity.
Diego Calleja (1):
dm: add dm-clone to the documentation index
Eric Biggers (1):
docs: dm-integrity: remove reference to ARC4
Hou Tao (1):
dm btree: increase rebalance threshold in __rebala
On Thu, Dec 05 2019 at 5:42P -0500,
Nikos Tsironis wrote:
> On 12/6/19 12:09 AM, Mike Snitzer wrote:
> > On Thu, Dec 05 2019 at 4:49pm -0500,
> > Nikos Tsironis wrote:
> >
> > > For dm-thin, indeed, there is not much to gain by not using
> > > blkdev
On Thu, Dec 05 2019 at 4:49pm -0500,
Nikos Tsironis wrote:
> On 12/5/19 10:07 PM, Mike Snitzer wrote:
> >On Thu, Dec 05 2019 at 2:46pm -0500,
> >Mike Snitzer wrote:
> >
> >>On Wed, Dec 04 2019 at 9:06P -0500,
> >>Nikos Tsironis wrote:
> >>
On Thu, Dec 05 2019 at 2:46pm -0500,
Mike Snitzer wrote:
> On Wed, Dec 04 2019 at 9:06P -0500,
> Nikos Tsironis wrote:
>
> > dm-clone maintains an on-disk bitmap which records which regions are
> > valid in the destination device, i.e., which regions have already been
On Wed, Dec 04 2019 at 12:06P -0500,
Nikos Tsironis wrote:
> Since we flush the data device as part of a metadata commit, it's
> redundant to then submit any deferred REQ_PREFLUSH bios.
>
> Add a check in process_deferred_bios() for deferred REQ_PREFLUSH bios
> and complete them immediately.
>
On Wed, Dec 04 2019 at 9:07P -0500,
Nikos Tsironis wrote:
> Add support for one pre-commit callback which is run right before the
> metadata are committed.
>
> This allows the thin provisioning target to run a callback before the
> metadata are committed and is required by the next commit.
>
On Thu, Dec 05 2019 at 10:31am -0500,
Nikos Tsironis wrote:
> On 12/4/19 10:17 PM, Mike Snitzer wrote:
> >On Wed, Dec 04 2019 at 2:58pm -0500,
> >Eric Wheeler wrote:
> >
> >>On Wed, 4 Dec 2019, Nikos Tsironis wrote:
> >>
> >>>The thin pro
On Wed, Dec 04 2019 at 2:58pm -0500,
Eric Wheeler wrote:
> On Wed, 4 Dec 2019, Nikos Tsironis wrote:
>
> > The thin provisioning target maintains per thin device mappings that map
> > virtual blocks to data blocks in the data device.
> >
> > When we write to a shared block, in case of
On Wed, Dec 04 2019 at 11:17am -0500,
Nikos Tsironis wrote:
> On 12/4/19 5:27 PM, Joe Thornber wrote:
> >On Wed, Dec 04, 2019 at 04:07:42PM +0200, Nikos Tsironis wrote:
> >>The thin provisioning target maintains per thin device mappings that map
> >>virtual blocks to data blocks in the data
As you can see below: your patches to remove the seemingly unused sz
variables won't even compile. The sz variable is used by the DMEMIT()
macro.
Nacked-by: Mike Snitzer
On Sun, Dec 01 2019 at 2:46am -0500,
kbuild test robot wrote:
> Hi Jieun,
>
> Thank you for the patch! Yet
On Tue, Nov 26 2019 at 1:56pm -0500,
Geert Uytterhoeven wrote:
> When the dm-clone documentation was added, it was not added to the
> documentation index, leading to a warning when building the
> documentation:
>
> Documentation/admin-guide/device-mapper/dm-clone.rst: WARNING: document
>
On Mon, Nov 25 2019 at 4:07pm -0500,
Martin Wilck wrote:
> On Mon, 2019-11-25 at 13:42 -0700, Drew Hastings wrote:
> > On Mon, Nov 25, 2019 at 12:48 PM Martin Wilck wrote:
> > > I think you are seeing this FIXME:
> > >
> > >
On Tue, Nov 26 2019 at 7:00am -0500,
Nikos Tsironis wrote:
> From: Diego Calleja
>
> It was missing from the initial commit
>
> Signed-off-by: Diego Calleja
>
> ---
> Documentation/admin-guide/device-mapper/index.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
p_recovery call chain
dm raid: streamline rs_get_progress() and its raid_status() caller side
Jeffle Xu (1):
dm thin: wakeup worker only when deferred bios exist
Krzysztof Kozlowski (1):
dm: Fix Kconfig indentation
Maged Mokhtar (1):
dm writecache: handle REQ_FUA
Mike
On Wed, Nov 20 2019 at 8:41am -0500,
Krzysztof Kozlowski wrote:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> $ sed -e 's/^/\t/' -i */Kconfig
>
> Signed-off-by: Krzysztof Kozlowski
Thanks, I've picked this up but
On Sun, Nov 17 2019 at 8:50pm -0500,
Jeffle Xu wrote:
> Single thread fio test (read, bs=4k, ioengine=libaio, iodepth=128,
> numjobs=1) over dm-thin device has poor performance versus bare nvme
> disk.
>
> Further investigation with perf indicates that queue_work_on() consumes
> over 20% CPU
On Fri, Nov 15 2019 at 5:46pm -0500,
Stephen Rothwell wrote:
> Hi all,
>
> On Fri, 15 Nov 2019 08:17:48 -0800 Randy Dunlap wrote:
> >
> > on i386:
> >
> > ld: drivers/md/dm-integrity.o: in function `calculate_device_limits':
> > dm-integrity.c:(.text.unlikely+0x1e9): undefined reference to
On Thu, Nov 14 2019 at 9:10am -0500,
Jeffle Xu wrote:
> Single thread fio test (read, bs=4k, ioengine=libaio, iodepth=128,
> numjobs=1) over dm-thin device has poor performance versus bare nvme
> disk on v5.4.0-rc7.
>
> Further investigation with perf indicates that queue_work_on() consumes
>
On Tue, Nov 12 2019 at 10:57am -0500,
Mikulas Patocka wrote:
>
>
> On Tue, 12 Nov 2019, Mike Snitzer wrote:
>
> > On Mon, Nov 11 2019 at 8:59am -0500,
> > Mikulas Patocka wrote:
> >
> > > Snapshot doesn't work with realtime kernels since
On Mon, Nov 11 2019 at 8:59am -0500,
Mikulas Patocka wrote:
> Snapshot doesn't work with realtime kernels since the commit f79ae415b64c.
> hlist_bl is implemented as a raw spinlock and the code takes two non-raw
> spinlocks while holding hlist_bl (non-raw spinlocks are blocking mutexes
> in the
On Mon, Nov 11 2019 at 11:37am -0500,
Nikos Tsironis wrote:
> On 11/11/19 3:59 PM, Mikulas Patocka wrote:
> > Snapshot doesn't work with realtime kernels since the commit f79ae415b64c.
> > hlist_bl is implemented as a raw spinlock and the code takes two non-raw
> > spinlocks while holding
er simply supplies a callback that is
> executed on each reported zone, and private data for it.
>
> Signed-off-by: Christoph Hellwig
> Signed-off-by: Shin'ichiro Kawasaki
> Signed-off-by: Damien Le Moal
Reviewed-by: Mike Snitzer
--
dm-devel mailing list
dm-devel@redhat.com
https://w
On Thu, Nov 07 2019 at 2:29pm -0500,
Maged Mokhtar wrote:
>
>
> On 07/11/2019 21:09, Mike Snitzer wrote:
> >On Thu, Nov 07 2019 at 1:55pm -0500,
> >Maged Mokhtar wrote:
> >
> >>
> >>
> >>On 06/11/2019 17:08, Mike Snitzer wrote:
> &g
On Thu, Nov 07 2019 at 1:55pm -0500,
Maged Mokhtar wrote:
>
>
> On 06/11/2019 17:08, Mike Snitzer wrote:
> >On Tue, Nov 05 2019 at 4:19pm -0500,
> >Maged Mokhtar wrote:
> >
> >>Gentle ping please.
> >>
> >>It could add flexibil
On Tue, Nov 05 2019 at 4:19pm -0500,
Maged Mokhtar wrote:
> Gentle ping please.
>
> It could add flexibility in changing cache parameters after device creation.
I'm inclined to _not_ take this type of change.
Why isn't changing the config parameters via table reload viable for
you?
--
On Mon, Nov 04 2019 at 10:43am -0500,
David Michael wrote:
> Hi,
>
> I would like to be able to use a root device configured by
> dm-mod.create with an initrd in some scenarios, but it appears that
> the default udev rules do not recognize this setup which prevents
> systemd from mounting the
d
> Damien Le Moal.
>
> Signed-off-by: Ajay Joshi
> Signed-off-by: Matias Bjorling
> Signed-off-by: Hans Holmberg
> Signed-off-by: Damien Le Moal
Acked-by: Mike Snitzer
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Hi Linus,
The following changes since commit da0c9ea146cbe92b832f1b0f694840ea8eb33cce:
Linux 5.4-rc2 (2019-10-06 14:27:30 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git
tags/for-5.4/dm-fixes
for you to fetch changes
On Fri, Oct 11 2019 at 8:43am -0400,
Nikos Tsironis wrote:
> On 10/2/19 1:15 PM, Mikulas Patocka wrote:
> > Commit 721b1d98fb517a ("dm snapshot: Fix excessive memory usage and
> > workqueue stalls") introduced a semaphore to limit the maximum number of
> > in-flight kcopyd (COW) jobs.
> >
> >
On Wed, Oct 09 2019 at 11:44am -0400,
Nikos Tsironis wrote:
> On 10/9/19 5:13 PM, Mike Snitzer wrote:> On Tue, Oct 01 2019 at 8:43am -0400,
> > Nikos Tsironis wrote:
> >
> >> On 10/1/19 3:27 PM, Guruswamy Basavaiah wrote:
> >>> Hello Nikos,
> &g
On Tue, Oct 01 2019 at 8:43am -0400,
Nikos Tsironis wrote:
> On 10/1/19 3:27 PM, Guruswamy Basavaiah wrote:
> > Hello Nikos,
> > Yes, issue is consistently reproducible with us, in a particular
> > set-up and test case.
> > I will get the access to set-up next week, will try to test and let
>
On Thu, Oct 03 2019 at 4:06P -0400,
Mikulas Patocka wrote:
>
>
> On Wed, 2 Oct 2019, Nikos Tsironis wrote:
>
> > Hi Mikulas,
> >
> > I agree that it's better to avoid holding any locks while waiting for
> > some pending kcopyd jobs to finish, but please see the comments below.
> >
> > On
On Wed, Sep 25 2019 at 2:40pm -0400,
Eric Wheeler wrote:
> Hello,
>
> We are using the 4.19.75 stable tree with dm-thin and multi-queue scsi.
> We have been using the 4.19 branch for months without issue; we just
> switched to MQ and we seem to have hit this BUG_ON. Whether or not MQ is
>
On Fri, Sep 20 2019 at 3:21pm -0400,
Milan Broz wrote:
> On 20/09/2019 19:37, Mike Snitzer wrote:
> > On Fri, Sep 20 2019 at 11:44am -0400,
> > Thibaut Sautereau wrote:
> >
> >> Hi,
> >>
> >> I just got a dm-crypt "crypt: Error allocating c
Hi Linus,
The following changes since commit 1cfd5d3399e87167b7f9157ef99daa0e959f395d:
dm table: fix invalid memory accesses with too high sector number (2019-08-23
10:11:42 -0400)
are available in the Git repository at:
On Tue, Sep 17 2019 at 11:44am -0400,
John Dorminy wrote:
>Makes sense, sorry I missed that detail.
>
>Might it be better to just extend 'dmsetup targets' to take an optional
>target-name parameter? When I saw this change, I thought 'dmsetup targets
>' surely worked already for
On Tue, Sep 17 2019 at 9:56am -0400,
John Dorminy wrote:
>I'm confused here:
>>...and then it fails on activation because DM table load detects old (or
>missing) dm-crypt feature.
>>(There was no way to get dm target version before table load if module is
>not loaded.)
>
On Tue, Sep 17 2019 at 2:32am -0400,
Christoph Hellwig wrote:
> On Mon, Sep 16, 2019 at 08:16:41PM +0200, Milan Broz wrote:
> >
> > So the main idea behind this was just use already existing functionality
> > in kernel DM, and provide simple user-friendly way to detect some
> >
On Mon, Sep 16 2019 at 5:55am -0400,
Mikulas Patocka wrote:
> This patch introduces a new ioctl DM_GET_TARGET_VERSION. It will load a
> target that is specified in the "name" entry in the parameter structure
> and return its version.
>
> This functionality is intended to be used by cryptsetup,
On Thu, Sep 12 2019 at 12:07P -0400,
Mikulas Patocka wrote:
>
>
> On Thu, 12 Sep 2019, Heinz Mauelshagen wrote:
>
> > Mikulas,
> >
> > please use list_move instead of list_del/list_add pairs.
> >
> > Heinz
>
> OK. Here I resend it.
>
>
>
> From: Mikulas Patocka
>
> This patch
On Thu, Sep 12 2019 at 8:11am -0400,
Nikos Tsironis wrote:
> Hi Mike,
>
> I examined the diff between v3 of dm-clone and the staged version and it
> looks fine.
>
> This patch set includes some minor fixes to fold in:
>
> - Rename 'md' to 'cmd' also in dm-clone-metadata.h, to be consistent
On Wed, Sep 11 2019 at 2:46pm -0400,
Nikos Tsironis wrote:
> On 9/11/19 9:22 PM, Mike Snitzer wrote:>
> > I resolved this and pushed new code, thanks!
> >
>
> Hi Mike,
>
> I just saw the report and was about to fix it, but I noticed you have
> already f
I resolved this and pushed new code, thanks!
On Wed, Sep 11 2019 at 12:03pm -0400,
kbuild test robot wrote:
> tree:
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/device-mapper/linux-dm.git
> for-next
> head: 509818079bf1fefff4ed02d6a1b994e20efc0480
> commit:
On Wed, Sep 11 2019 at 10:41am -0400,
Nikos Tsironis wrote:
> Hi Mike,
>
> I just noticed commit 6cf2a73cb2bc42 ("docs: device-mapper: move it to
> the admin-guide"), which moves Documentation/device-mapper/ to
> Documentation/admin-guide/device-mapper/.
>
> I sent a v3 which moves
On Wed, Sep 11 2019 at 9:35am -0400,
Mike Snitzer wrote:
> FYI, I added a "Fixes:" tag to the commit header and switched to
> shifting by SECTOR_SHIFT instead of 9, staged commit for 5.4 is here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-d
On Wed, Sep 11 2019 at 7:31am -0400,
Ming Lei wrote:
> Unit of 'chunk_size' is byte, instead of sector, so fix it.
>
> Without this fix, too big max_discard_sectors is applied on the request queue
> of dm-raid, finally raid code has to split the bio again.
>
> This re-split done by raid
On Fri, Sep 06 2019 at 3:45am -0400,
Martijn Coenen wrote:
> The upper limit on the cache size of a client is currently determined by
> dividing the total cache size by the number of clients. However, in some
> cases it is beneficial to give one client a higher limit than others; an
> example
On Sat, Aug 31 2019 at 5:55am -0400,
Nikos Tsironis wrote:
> On 8/29/19 7:19 PM, Mike Snitzer wrote:
> > On Tue, Jul 09 2019 at 10:15am -0400,
> > Nikos Tsironis wrote:
> >
> >> Add the dm-clone target, which allows cloning of arbitrary block
> >> dev
On Wed, Sep 04 2019 at 7:01am -0400,
Milan Broz wrote:
> On 03/09/2019 20:58, Mike Snitzer wrote:
> > On Mon, Aug 19 2019 at 10:17am -0400,
> > Ard Biesheuvel wrote:
> >
> >> Only the ESSIV IV generation mode used to use cc->cipher so it could
> >> i
On Tue, Sep 03 2019 at 3:16pm -0400,
Ard Biesheuvel wrote:
> On Tue, 3 Sep 2019 at 11:55, Mike Snitzer wrote:
> >
> > On Mon, Aug 19 2019 at 10:17am -0400,
> > Ard Biesheuvel wrote:
> >
> > > Replace the explicit ESSIV handling in the dm-crypt driver
remain. So remove it altogether.
>
> Signed-off-by: Ard Biesheuvel
Acked-by: Mike Snitzer
Might be wise to bump the dm-crypt target's version number (from
{1, 19, 0} to {1, 20, 0}) at the end of this patch too though...
But again, Herbert please feel free to pull this into your 5.4 bran
AEAD cipher_api string parsing with the TFM
> instantiation: this is needed because cipher_api is mangled by the
> ESSIV handling, and throws off the parsing of "authenc(" otherwise.
>
> Signed-off-by: Ard Biesheuvel
I really like to see this type of factoring out to the cry
size <# regions>? (or
clone_batch_size)?
Please take care of the external facing documentation to not use
"hydration". Of all the naming I dislike it the most.. sorry.
Also, please fold the following patch in before making any edits to the
.c files for v2.
This review pass is t
On Tue, Aug 27 2019 at 10:09am -0400,
Nikos Tsironis wrote:
> Hello,
>
> This is a kind reminder for this patch set. I'm bumping this thread to
> solicit your feedback.
>
> Following the discussion with Heinz, I have provided extensive
> benchmarks that show dm-clone's significant performance
Hi Linus,
More fixes than usual from DM at this stage in a release but...
The following changes since commit d45331b00ddb179e291766617259261c112db872:
Linux 5.3-rc4 (2019-08-11 13:26:41 -0700)
are available in the Git repository at:
On Fri, Aug 16 2019 at 10:09am -0400,
Bryan Gurney wrote:
> Change the "frontend" dust_remove_block, dust_add_block, and
> dust_query_block functions to store the "dust block number", instead
> of the sector number corresponding to the "dust block number"
>
> For the "backend" functions
On Thu, Aug 08 2019 at 5:40am -0400,
Mikulas Patocka wrote:
> Revert the patch bd293d071ffe65e645b4d8104f9d8fe15ea13862. A proper fix
> should be not to use GFP_KERNEL in the function do_blockdev_direct_IO.
Matthew Wilcox pointed out that the "proper fix" is loop should be using
DAX code
changes from commit in 5.3 merge.
Mike Snitzer (1):
dm table: fix various whitespace issues with recent DAX code
Pankaj Gupta (1):
dm table: fix dax_dev NULL dereference in device_synchronous()
drivers/md/dm
901 - 1000 of 2007 matches
Mail list logo
