Re: [dm-devel] [PATCH -next 2/3] md/dm-raid: cleanup multiple equivalent goto tags from raid_ctr()

2023-07-10 Thread Paul Menzel
Dear Yu, Thank you for your patch. Some minor nits, if you are interested. Am 06.07.23 um 09:16 schrieb Yu Kuai: From: Yu Kuai There are four equivalent goto tags in raid_ctr(), clean them up to use just one, there are no functional change and prepare to fix that Maybe: There *is* no

Re: [dm-devel] [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails

2023-05-31 Thread Paul Menzel
Dear Johannes, Thank you for your patches. Am 31.05.23 um 06:58 schrieb Song Liu: On Tue, May 30, 2023 at 9:25 PM Christoph Hellwig wrote: To me these look like __bio_add_page candidates, but I guess Song preferred it this way? It'll add a bit pointless boilerplate code, but I'm ok with

Re: [RFC] block: Change the granularity of io ticks from ms to ns

2022-12-06 Thread Paul Menzel
Dear Gulam, Thank you for the patch. Am 06.12.22 um 19:15 schrieb Gulam Mohamed: Use ktime to change the granularity of IO accounting in block layer from milli-seconds to nano-seconds to get the proper latency values for the devices whose latency is in micro-seconds. After changing the

[dm-devel] Problems with email threading (was: [PATCH] md: fix a crash in mempool_free)

2022-11-04 Thread Paul Menzel
Dear Neil, Just a heads-up, Mozilla Thunderbird 102.4.1 does not thread your message. Your reply contains: In-reply-to: =?utf-8?q?=3Calpine=2ELRH=2E2=2E21=2E2211031121070=2E18305=40fi?= =?utf-8?q?le01=2Eintranet=2Eprod=2Eint=2Erdu2=2Eredhat=2Ecom=3E?= References:

Re: [dm-devel] [PATCH v2 0/3] LoadPin: Enable loading from trusted dm-verity devices

2022-04-29 Thread Paul Menzel
Dear Matthias, Thank you for your patches. Am 26.04.22 um 23:31 schrieb Matthias Kaehlcke: As of now LoadPin restricts loading of kernel files to a single pinned filesystem, typically the rootfs. This works for many […] A small nit, if you should reroll the patches, please use 75

Re: [dm-devel] Raid0 performance regression

2022-01-23 Thread Paul Menzel
Dear Roger, Am 23.01.22 um 19:00 schrieb Lukas Straub: CC'ing Song Liu (md-raid maintainer) and linux-raid mailing list. On Fri, 21 Jan 2022 16:38:03 + Roger Willcocks wrote: we noticed a thirty percent drop in performance on one of our raid arrays when switching from CentOS 6.5 to

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-11-30 Thread Paul Menzel
Dear Linux folks, Am 20.03.21 um 00:00 schrieb Song Liu: On Wed, Feb 24, 2021 at 1:26 AM Guoqing Jiang wrote: On 2/24/21 10:09, Song Liu wrote: On Mon, Feb 15, 2021 at 3:08 AM Paul Menzel wrote: [+cc Donald] Am 13.02.21 um 01:49 schrieb Guoqing Jiang: Unregister sync_thread doesn't

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-11-30 Thread Paul Menzel
[Update Guoqing’s email address] Am 30.11.21 um 18:25 schrieb Paul Menzel: Dear Linux folks, Am 20.03.21 um 00:00 schrieb Song Liu: On Wed, Feb 24, 2021 at 1:26 AM Guoqing Jiang wrote: On 2/24/21 10:09, Song Liu wrote: On Mon, Feb 15, 2021 at 3:08 AM Paul Menzel wrote: [+cc Donald] Am

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-02-17 Thread Paul Menzel
[+cc Donald] Am 13.02.21 um 01:49 schrieb Guoqing Jiang: Unregister sync_thread doesn't need to hold reconfig_mutex since it doesn't reconfigure array. And it could cause deadlock problem for raid5 as follows: 1. process A tried to reap sync thread with reconfig_mutex held after echo idle