Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

On 12/08/2016 12:12 AM, Xose Vazquez Perez wrote: > On 12/07/2016 05:17 PM, Martin Wilck wrote: > >>> "controller", what controller? local hba? array controller? >>> "array" is unequivocal. >>> >> I tend to associate "array" with "RAID", and therefore I found this >> term confusing. Perhaps

Re: [dm-devel] [PATCH] multipath-tools: Replace multipath configuration output

Merged, Thanks. On Thu, May 18, 2017 at 2:06 AM, Xose Vazquez Perez wrote: > On 04/18/2017 02:07 AM, Xose Vazquez Perez wrote: > > > Cc: Christophe Varoqui > > Cc: device-mapper development > > Signed-off-by: Xose

Re: [dm-devel] [PATCH] multipath-tools: Replace multipath configuration output

On 04/18/2017 02:07 AM, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez This is missing. > --- > libmultipath/propsel.c | 6 +++--- > 1 file

[dm-devel] [PATCH] multipath-tools: Replace multipath configuration output

Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/propsel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libmultipath/propsel.c

Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

Right, pushed now. Thanks, Christophe. On Fri, Apr 14, 2017 at 1:56 AM, Xose Vazquez Perez wrote: > On 04/12/2017 09:35 AM, Christophe Varoqui wrote: > > > Merged, > > No, it's missing. > > > On Sat, Apr 8, 2017 at 3:30 PM, Xose Vazquez Perez < > xose.vazq...@gmail.com

Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

On 04/12/2017 09:35 AM, Christophe Varoqui wrote: > Merged, No, it's missing. > On Sat, Apr 8, 2017 at 3:30 PM, Xose Vazquez Perez > wrote: > > Cc: Christophe Varoqui

Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

Merged, thanks. On Sat, Apr 8, 2017 at 3:30 PM, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez > --- >

[dm-devel] [PATCH] multipath-tools: replace multipath configuration output

Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/propsel.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libmultipath/propsel.c

Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

On 12/02/2016 04:52 AM, Benjamin Marzinski wrote: > I don't really see the need for this change. But we wouldn't be pulling > it in until the next major RHEL release [...] BTW, do you(SUSE/RH) have any distro fixes/features pending for upstream? -- dm-devel mailing list dm-devel@redhat.com

Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

On Wed, 2016-12-07 at 16:44 +0100, Xose Vazquez Perez wrote: > On 11/25/2016 10:00 AM, Martin Wilck wrote: > > > I am not sure I see the merit of these changes. If it's really > > necessary to change the wording of the log messages which people > > have > > got used to, the new ones should be

Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

On 11/25/2016 10:00 AM, Martin Wilck wrote: > I am not sure I see the merit of these changes. If it's really > necessary to change the wording of the log messages which people have > got used to, the new ones should be really more self-explanatory than > the old ones. Some of them are a riddle,

Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

I also like the more structured wording you propose, and I can see how greping "setting:" can help. I'll wait a little longer to receive ack (not receive nack?) from distributors, as they face the annoyed users whose scripts break when we change our log strings format. Thanks. On Fri, Nov 25,

Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

I am not sure I see the merit of these changes. If it's really necessary to change the wording of the log messages which people have got used to, the new ones should be really more self-explanatory than the old ones. The common "setting: " formatting is nice but IMHO this alone doesn't really

[dm-devel] [PATCH] multipath-tools: replace multipath configuration output

sysfs setting -> setting: kernel sysfs detected setting-> setting: array autodetected controller setting -> setting: array configuration internal default-> setting: multipath internal overrides setting -> setting: multipath.conf overrides section LUN