Re: [dm-devel] [PATCH]multipath-tools: prevent unnecessary reinstate of stand-by paths with implicit tpgs mode and no active array paths.

2016-02-26 Thread Benjamin Marzinski
On Fri, Feb 26, 2016 at 12:32:51AM +, Shiva Krishna wrote: > > > On 2/25/16, 12:49 PM, "Benjamin Marzinski" wrote: > > >On Sat, Feb 20, 2016 at 08:23:29PM +, Shiva Krishna wrote: > > > >I understand your problem, but this isn't the right patch to fix it. For > >one

Re: [dm-devel] [PATCH]multipath-tools: prevent unnecessary reinstate of stand-by paths with implicit tpgs mode and no active array paths.

2016-02-25 Thread Hannes Reinecke
On 02/26/2016 04:49 AM, Benjamin Marzinski wrote: > On Sat, Feb 20, 2016 at 08:23:29PM +, Shiva Krishna wrote: > > I understand your problem, but this isn't the right patch to fix it. For > one this check > > + if (newstate != PATH_GHOST || pp->mpp->nr_active > 0 || > +

Re: [dm-devel] [PATCH]multipath-tools: prevent unnecessary reinstate of stand-by paths with implicit tpgs mode and no active array paths.

2016-02-25 Thread Shiva Krishna
On 2/25/16, 12:49 PM, "Benjamin Marzinski" wrote: >On Sat, Feb 20, 2016 at 08:23:29PM +, Shiva Krishna wrote: > >I understand your problem, but this isn't the right patch to fix it. For >one this check > >+ if (newstate != PATH_GHOST || pp->mpp->nr_active

Re: [dm-devel] [PATCH]multipath-tools: prevent unnecessary reinstate of stand-by paths with implicit tpgs mode and no active array paths.

2016-02-25 Thread Benjamin Marzinski
On Sat, Feb 20, 2016 at 08:23:29PM +, Shiva Krishna wrote: I understand your problem, but this isn't the right patch to fix it. For one this check + if (newstate != PATH_GHOST || pp->mpp->nr_active > 0 || + pp->tpgs != TPGS_IMPLICIT) { is pretty problematic.

[dm-devel] [PATCH]multipath-tools: prevent unnecessary reinstate of stand-by paths with implicit tpgs mode and no active array paths.

2016-02-20 Thread Shiva Krishna
multipathd treats "stand-by" path as active(ghost) and reinstate path.This causes I/O hang issues and lots of "change" udev events in cases where only stand-by paths are present in multipath map and target supports only implicit tpgs mode(active/passive arrays) This can happen during system boot