Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-10 Thread Keith Busch
On Thu, Nov 10, 2022 at 06:24:03PM +, Eric Biggers wrote: > On Thu, Nov 03, 2022 at 08:25:56AM -0700, Keith Busch wrote: > > From: Keith Busch > > > > The 6.0 kernel made some changes to the direct io interface to allow > > offsets in user addresses. This based on the hardware's capabilities

Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-10 Thread Eric Biggers
On Thu, Nov 03, 2022 at 08:25:56AM -0700, Keith Busch wrote: > From: Keith Busch > > The 6.0 kernel made some changes to the direct io interface to allow > offsets in user addresses. This based on the hardware's capabilities > reported in the request_queue's dma_alignment attribute. > >

Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-04 Thread Mikulas Patocka
On Thu, 3 Nov 2022, Keith Busch wrote: > On Thu, Nov 03, 2022 at 12:33:19PM -0400, Mikulas Patocka wrote: > > Hi > > > > The patchset seems OK - but dm-integrity also has a limitation that the > > bio vectors must be aligned on logical block size. > > > > dm-writecache and dm-verity seem to

[dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-04 Thread Keith Busch
From: Keith Busch The 6.0 kernel made some changes to the direct io interface to allow offsets in user addresses. This based on the hardware's capabilities reported in the request_queue's dma_alignment attribute. dm-crypt requires direct io be aligned to the block size. Since it was only ever

Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-04 Thread Dmitrii Tcvetkov
On Thu, 3 Nov 2022 08:25:56 -0700 Keith Busch wrote: > From: Keith Busch > > The 6.0 kernel made some changes to the direct io interface to allow > offsets in user addresses. This based on the hardware's capabilities > reported in the request_queue's dma_alignment attribute. > > dm-crypt

Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-04 Thread Keith Busch
On Thu, Nov 03, 2022 at 12:33:19PM -0400, Mikulas Patocka wrote: > Hi > > The patchset seems OK - but dm-integrity also has a limitation that the > bio vectors must be aligned on logical block size. > > dm-writecache and dm-verity seem to handle unaligned bioset, but you > should check them

Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-03 Thread Mikulas Patocka
Hi The patchset seems OK - but dm-integrity also has a limitation that the bio vectors must be aligned on logical block size. dm-writecache and dm-verity seem to handle unaligned bioset, but you should check them anyway. I'm not sure about dm-log-writes. Mikulas On Thu, 3 Nov 2022, Keith