Re: [dm-devel] [PATCH 01/23] pd: don't check blk_execute_rq return value.

2017-04-20 Thread Johannes Thumshirn
On Thu, Apr 20, 2017 at 04:02:54PM +0200, Christoph Hellwig wrote: > The driver never sets req->errors, so blk_execute_rq will always return 0. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Bart Van Assche > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

[dm-devel] [PATCH 01/23] pd: don't check blk_execute_rq return value.

2017-04-20 Thread Christoph Hellwig
The driver never sets req->errors, so blk_execute_rq will always return 0. Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche --- drivers/block/paride/pd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c

Re: [dm-devel] [PATCH 01/23] pd: don't check blk_execute_rq return value.

2017-04-19 Thread Bart Van Assche
On Wed, 2017-04-19 at 21:26 +0200, Christoph Hellwig wrote: > The driver never sets req->errors, so blk_execute_rq will always return 0. Reviewed-by: Bart Van Assche -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 01/23] pd: don't check blk_execute_rq return value.

2017-04-19 Thread Christoph Hellwig
The driver never sets req->errors, so blk_execute_rq will always return 0. Signed-off-by: Christoph Hellwig --- drivers/block/paride/pd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c index b05e151c9b38..7d2402f90