Re: [dm-devel] [PATCH 02/18] md: cleanup bio op / flags handling in raid1_write_request

2017-01-26 Thread Bart Van Assche
On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > No need for the local variables, the bio is still live and we can just > assigned the bits we want directly. Make me wonder why we can't assign > all the bio flags to start with. I assume that you ment "assign" in the patch

[dm-devel] [PATCH 02/18] md: cleanup bio op / flags handling in raid1_write_request

2017-01-25 Thread Christoph Hellwig
No need for the local variables, the bio is still live and we can just assigned the bits we want directly. Make me wonder why we can't assign all the bio flags to start with. Signed-off-by: Christoph Hellwig --- drivers/md/raid1.c | 7 ++- 1 file changed, 2 insertions(+), 5