Re: [dm-devel] [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start

2019-10-14 Thread Baruch Even
Hi, The patch looks good to me, as for gpart, I needed it so I've taken the bits and pieces that floated around and merged them all into one place from all distributions that I could find. As for users, in Debian the number of users is around 250 so it's a very low usage program but I guess

Re: [dm-devel] [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start

2019-10-12 Thread Petr Vorel
Hi Baruch, > Hi, > The patch looks good to me, as for gpart, I needed it so I've taken the > bits and pieces that floated around and merged them all into one place from > all distributions that I could find. As for users, in Debian the number > of users is around 250 so it's a very low usage

Re: [dm-devel] [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start

2019-10-08 Thread Petr Vorel
Hi Christoph, > On Wed, Oct 02, 2019 at 08:05:09AM +0200, Petr Vorel wrote: > > I tried to search in [1], with not much success, I don't know the original > > name > > of the struct and struct members are quite similar. Do you have a tip, > > where it > > could be or would you dare to search?

Re: [dm-devel] [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start

2019-10-07 Thread Christoph Hellwig
On Wed, Oct 02, 2019 at 08:05:09AM +0200, Petr Vorel wrote: > I tried to search in [1], with not much success, I don't know the original > name > of the struct and struct members are quite similar. Do you have a tip, where > it > could be or would you dare to search? No, I don't know Solaris

Re: [dm-devel] [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start

2019-10-02 Thread Petr Vorel
Hi Christoph, > On Tue, Jul 09, 2019 at 10:02:05AM +0200, Petr Vorel wrote: > > > What this really should use is fixed size types. > > If it's not specific to __kernel_daddr_t nor daddr_t ("The type of a disk > > address") and long is sufficient for all platforms, that's even better. > > I'd be

Re: [dm-devel] [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start

2019-07-09 Thread Petr Vorel
Hi Christoph, > > -//typedef int daddr_t; /* or long - check */ > > - > > struct solaris_x86_slice { > > unsigned short s_tag; /* ID tag of partition */ > > unsigned short s_flag; /* permission flags */ > > - longs_start;/* start

Re: [dm-devel] [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start

2019-07-08 Thread Christoph Hellwig
> -//typedef int daddr_t; /* or long - check */ > - > struct solaris_x86_slice { > unsigned short s_tag; /* ID tag of partition */ > unsigned short s_flag; /* permission flags */ > - longs_start;/* start sector no of partition

[dm-devel] [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start

2019-07-08 Thread Petr Vorel
It was meant to be used daddr_t (which is mostly int, only sparc and mips have it defined as int), but instead used long. But musl libc does not define daddr_t as it's deprecated, therefore use __kernel_daddr_t from . Signed-off-by: Petr Vorel --- kpartx/solaris.c | 6 ++ 1 file changed, 2